)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"d7ece2bbbd71299c8cbd18a3ae254fdca2e76598","unresolved":false,"context_lines":[{"line_number":12,"context_line":"a container where its creator_id matches with token user_id to establish"},{"line_number":13,"context_line":"ownership. Which also means that users with \u0027creator\u0027 role cannot delete"},{"line_number":14,"context_line":"any other user\u0027s secret/container in the same project. Delete by non-admin"},{"line_number":15,"context_line":"user is allowed only for secret/container which user has created originally."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I53e5529ed34ac4acc76348ca0431cb3de7934b6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_5a4e8838","line":15,"updated":"2016-05-05 16:22:57.000000000","message":"Revise this paragraph. Its too long.","commit_id":"7cb16f7e3c04a24bc34b843457ab0ca1d23b48da"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"03d5eef9535e0f685484823facc7932f894e286f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"a container where its creator_id matches with token user_id to establish"},{"line_number":13,"context_line":"ownership. Which also means that users with \u0027creator\u0027 role cannot delete"},{"line_number":14,"context_line":"any other user\u0027s secret/container in the same project. Delete by non-admin"},{"line_number":15,"context_line":"user is allowed only for secret/container which user has created originally."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I53e5529ed34ac4acc76348ca0431cb3de7934b6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_f53fa7dc","line":15,"in_reply_to":"1a122d0e_5a4e8838","updated":"2016-05-05 16:54:36.000000000","message":"I was trying to explain the change and updated delete behavior. I was trying to highlight the difference between creator and admin role. Will rephrase and break into different paragraph.","commit_id":"7cb16f7e3c04a24bc34b843457ab0ca1d23b48da"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"c4a59d828389c70179163cd46ee7d3acc334b16d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There is still a difference between \u0027admin\u0027 role and \u0027creator\u0027 role"},{"line_number":16,"context_line":"behavior around delete operation. With this change, users with \u0027creator\u0027"},{"line_number":17,"context_line":"role cannot delete any other user\u0027s secret/container is same project"},{"line_number":18,"context_line":"while user with \u0027admin\u0027 role can do that."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I53e5529ed34ac4acc76348ca0431cb3de7934b6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aa78d24_ee44cd47","line":17,"range":{"start_line":17,"start_character":53,"end_line":17,"end_character":55},"updated":"2016-07-13 01:27:36.000000000","message":"in","commit_id":"ed631e39c6c4a3c990707ecc909226763ea97cbc"}],"etc/barbican/barbican-functional.conf":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"d7ece2bbbd71299c8cbd18a3ae254fdca2e76598","unresolved":false,"context_lines":[{"line_number":24,"context_line":"admin_a_password\u003dbarbican"},{"line_number":25,"context_line":"creator_a\u003dproject_a_creator"},{"line_number":26,"context_line":"creator_a_password\u003dbarbican"},{"line_number":27,"context_line":"creator_a_2\u003dproject_a_another_creator"},{"line_number":28,"context_line":"creator_a_2_password\u003dbarbican"},{"line_number":29,"context_line":"observer_a\u003dproject_a_observer"},{"line_number":30,"context_line":"observer_a_password\u003dbarbican"}],"source_content_type":"text/plain","patch_set":3,"id":"1a122d0e_faee741f","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":37},"updated":"2016-05-05 16:22:57.000000000","message":"naming is a bit confusing. Maybe just name it \"project_a_creator_2\"\nRename in all required spaces.","commit_id":"7cb16f7e3c04a24bc34b843457ab0ca1d23b48da"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"03d5eef9535e0f685484823facc7932f894e286f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"admin_a_password\u003dbarbican"},{"line_number":25,"context_line":"creator_a\u003dproject_a_creator"},{"line_number":26,"context_line":"creator_a_password\u003dbarbican"},{"line_number":27,"context_line":"creator_a_2\u003dproject_a_another_creator"},{"line_number":28,"context_line":"creator_a_2_password\u003dbarbican"},{"line_number":29,"context_line":"observer_a\u003dproject_a_observer"},{"line_number":30,"context_line":"observer_a_password\u003dbarbican"}],"source_content_type":"text/plain","patch_set":3,"id":"1a122d0e_15ffc334","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":37},"in_reply_to":"1a122d0e_faee741f","updated":"2016-05-05 16:54:36.000000000","message":"Okay. I was just trying to highlight another creator user. If its confusing, I will change it to as suggested.","commit_id":"7cb16f7e3c04a24bc34b843457ab0ca1d23b48da"}],"etc/barbican/policy.json":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"d7ece2bbbd71299c8cbd18a3ae254fdca2e76598","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"secret:decrypt\": \"rule:secret_decrypt_non_private_read or rule:secret_project_creator or rule:secret_project_admin or rule:secret_acl_read\","},{"line_number":31,"context_line":"    \"secret:get\": \"rule:secret_non_private_read or rule:secret_project_creator or rule:secret_project_admin or rule:secret_acl_read\","},{"line_number":32,"context_line":"    \"secret:put\": \"rule:admin_or_creator and rule:secret_project_match\","},{"line_number":33,"context_line":"    \"secret:delete\": \"rule:secret_project_admin or rule:secret_project_creator\","},{"line_number":34,"context_line":"    \"secrets:post\": \"rule:admin_or_creator\","},{"line_number":35,"context_line":"    \"secrets:get\": \"rule:all_but_audit\","},{"line_number":36,"context_line":"    \"orders:post\": \"rule:admin_or_creator\","}],"source_content_type":"application/json","patch_set":3,"id":"1a122d0e_fa0af4cf","line":33,"updated":"2016-05-05 16:22:57.000000000","message":"Looks good.","commit_id":"7cb16f7e3c04a24bc34b843457ab0ca1d23b48da"}],"functionaltests/api/v1/functional/test_containers_rbac.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"0b04cf866e41716430d6b920d0529f639d794b5d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                     \u0027expected_return\u0027: 204},"},{"line_number":59,"context_line":"    \u0027with_creator_a\u0027: {\u0027user\u0027: creator_a, \u0027admin\u0027: creator_a,"},{"line_number":60,"context_line":"                       \u0027expected_return\u0027: 204},"},{"line_number":61,"context_line":"    \u0027with_creator_a\u0027: {\u0027user\u0027: creator_a_2, \u0027admin\u0027: creator_a,"},{"line_number":62,"context_line":"                       \u0027expected_return\u0027: 403},"},{"line_number":63,"context_line":"    \u0027with_observer_a\u0027: {\u0027user\u0027: observer_a, \u0027admin\u0027: admin_a,"},{"line_number":64,"context_line":"                        \u0027expected_return\u0027: 403},"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_3bc5e63b","line":61,"updated":"2016-07-25 18:47:29.000000000","message":"Please change to \u0027with_creator_a_2\u0027 to distinguish in test logs.","commit_id":"2f25c0ea091b7aacd77b5d8fb3b416732cd1055f"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"defaa2efb30e8a239607ac5402dc9eca59c6f10e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                     \u0027expected_return\u0027: 204},"},{"line_number":59,"context_line":"    \u0027with_creator_a\u0027: {\u0027user\u0027: creator_a, \u0027admin\u0027: creator_a,"},{"line_number":60,"context_line":"                       \u0027expected_return\u0027: 204},"},{"line_number":61,"context_line":"    \u0027with_creator_a\u0027: {\u0027user\u0027: creator_a_2, \u0027admin\u0027: creator_a,"},{"line_number":62,"context_line":"                       \u0027expected_return\u0027: 403},"},{"line_number":63,"context_line":"    \u0027with_observer_a\u0027: {\u0027user\u0027: observer_a, \u0027admin\u0027: admin_a,"},{"line_number":64,"context_line":"                        \u0027expected_return\u0027: 403},"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_2fa47bb7","line":61,"in_reply_to":"dada55a8_3bc5e63b","updated":"2016-07-25 20:23:29.000000000","message":"will change in next patch.","commit_id":"2f25c0ea091b7aacd77b5d8fb3b416732cd1055f"}]}
