)]}'
{"barbican/plugin/kmip_secret_store.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"8646e71d5a9fe4c8f669050cbcd7f8ccfb720f0c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            if ssl.PROTOCOL_TLSv1_2:"},{"line_number":240,"context_line":"                config.ssl_version \u003d \"PROTOCOL_TLSv1_2\""},{"line_number":241,"context_line":"                LOG.info(\"Going to use TLS1.2...\")"},{"line_number":242,"context_line":"        except AttributeError:"},{"line_number":243,"context_line":"            LOG.warning(\"TLSv1_2 is not present on the System\")"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_0a8e1a27","line":241,"updated":"2016-06-27 20:44:11.000000000","message":"Please use the _LI form for LOG.info, and _LW for LOG.warning below...see other parts of code for an example.","commit_id":"dc959099d7bfa2b5ec27dffa576d897623938516"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"fa27b97bc8572d59ce40f361560dfb0add5fc7ad","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        config \u003d conf.kmip_plugin"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Use TLSv1_2, if present"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            if ssl.PROTOCOL_TLSv1_2:"},{"line_number":240,"context_line":"                config.ssl_version \u003d \u0027PROTOCOL_TLSv1_2\u0027"},{"line_number":241,"context_line":"                LOG.info(u._LI(\u0027Going to use TLS1.2...\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_6d894a26","line":238,"updated":"2016-06-29 15:41:11.000000000","message":"We can have cleaner logic here using python\u0027s get_attr[1]. Remove the try/except and add something like:\n\nfunc \u003d getattr(ssl, \"PROTOCOL_TLSv1_2\", None)\nif func:\n    config.ssl_version \u003d \u0027PROTOCOL_TLSv1_2\u0027\n    LOG.info(u._LI(\u0027Going to use TLS1.2...\u0027))\nelse:\n    LOG.warning(u._LW(\u0027TLSv1_2 is not present on the System\u0027))\n\n[1]http://effbot.org/zone/python-getattr.htm","commit_id":"6cb0d1430289be74c206f98905d1ed5adc7d4458"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"fa27b97bc8572d59ce40f361560dfb0add5fc7ad","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # Use TLSv1_2, if present"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            if ssl.PROTOCOL_TLSv1_2:"},{"line_number":240,"context_line":"                config.ssl_version \u003d \u0027PROTOCOL_TLSv1_2\u0027"},{"line_number":241,"context_line":"                LOG.info(u._LI(\u0027Going to use TLS1.2...\u0027))"},{"line_number":242,"context_line":"        except AttributeError:"},{"line_number":243,"context_line":"            LOG.warning(u._LW(\u0027TLSv1_2 is not present on the System\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ed553a50","line":240,"updated":"2016-06-29 15:41:11.000000000","message":"Needs to be tested.","commit_id":"6cb0d1430289be74c206f98905d1ed5adc7d4458"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"436387721a69cd7862566069ef97af2c08b39334","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        config \u003d conf.kmip_plugin"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Use TLSv1_2, if present"},{"line_number":238,"context_line":"        func \u003d getattr(ssl, \"PROTOCOL_TLSv1_2\", None)"},{"line_number":239,"context_line":"        if func:"},{"line_number":240,"context_line":"            config.ssl_version \u003d \u0027PROTOCOL_TLSv1_2\u0027"},{"line_number":241,"context_line":"            LOG.info(u._LI(\u0027Going to use TLS1.2...\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_750b93d6","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":12},"updated":"2016-07-07 04:38:34.000000000","message":"I used the variable name `func` as just an example. Consider naming this something more descriptive, like `protocol`","commit_id":"db4f085e458e16fe2621ceed1f7bd0665898693a"}],"test-requirements.txt":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"436387721a69cd7862566069ef97af2c08b39334","unresolved":false,"context_lines":[{"line_number":18,"context_line":"bandit\u003e\u003d1.0.1 # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Documentation build requirements"},{"line_number":21,"context_line":"sphinx!\u003d1.3b1,\u003c1.3,\u003e\u003d1.2.1 # BSD"},{"line_number":22,"context_line":"oslosphinx!\u003d3.4.0,\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":23,"context_line":"reno\u003e\u003d1.8.0 # Apache2"},{"line_number":24,"context_line":"openstackdocstheme\u003e\u003d1.0.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":11,"id":"1aa78d24_952f1f3e","line":21,"updated":"2016-07-07 04:38:34.000000000","message":"Is this necessary?","commit_id":"db4f085e458e16fe2621ceed1f7bd0665898693a"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"f0048347a28e6272bac010b0852eb737ea92e241","unresolved":false,"context_lines":[{"line_number":18,"context_line":"bandit\u003e\u003d1.0.1 # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Documentation build requirements"},{"line_number":21,"context_line":"sphinx!\u003d1.3b1,\u003c1.3,\u003e\u003d1.2.1 # BSD"},{"line_number":22,"context_line":"oslosphinx!\u003d3.4.0,\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":23,"context_line":"reno\u003e\u003d1.8.0 # Apache2"},{"line_number":24,"context_line":"openstackdocstheme\u003e\u003d1.0.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":11,"id":"1aa78d24_c34f0890","line":21,"in_reply_to":"1aa78d24_952f1f3e","updated":"2016-07-07 18:03:59.000000000","message":"Agreed. If needed, it should be bumped in another patch.","commit_id":"db4f085e458e16fe2621ceed1f7bd0665898693a"},{"author":{"_account_id":18623,"name":"Pankaj Khandar","email":"pankaj.khandar@gmail.com","username":"Pan"},"change_message_id":"555135809169512e1ec149465275f5f4bcf29e67","unresolved":false,"context_lines":[{"line_number":18,"context_line":"bandit\u003e\u003d1.0.1 # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Documentation build requirements"},{"line_number":21,"context_line":"sphinx!\u003d1.3b1,\u003c1.3,\u003e\u003d1.2.1 # BSD"},{"line_number":22,"context_line":"oslosphinx!\u003d3.4.0,\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":23,"context_line":"reno\u003e\u003d1.8.0 # Apache2"},{"line_number":24,"context_line":"openstackdocstheme\u003e\u003d1.0.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":11,"id":"1aa78d24_15982169","line":21,"in_reply_to":"1aa78d24_c34f0890","updated":"2016-07-07 18:30:24.000000000","message":"Thanks, Diaz and Peter, No idea how this came, will remove it in next patch .. probably some mixed-up with other work i am doing.","commit_id":"db4f085e458e16fe2621ceed1f7bd0665898693a"}]}
