)]}'
{"barbican/api/controllers/secrets.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"fdc09ad48e2c14a395aa379bc7b3660e376a3947","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            # the default should be used."},{"line_number":353,"context_line":"            bits \u003d 0"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        for date_filter in \u0027created\u0027, \u0027updated\u0027, \u0027expiration\u0027:"},{"line_number":356,"context_line":"            if kw.get(date_filter) and not self._is_valid_date_filter("},{"line_number":357,"context_line":"                    kw.get(date_filter)):"},{"line_number":358,"context_line":"                _bad_query_string_parameters()"},{"line_number":359,"context_line":"        if kw.get(\u0027sort\u0027) and not self._is_valid_sorting(kw.get(\u0027sort\u0027)):"},{"line_number":360,"context_line":"            _bad_query_string_parameters()"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        ctxt \u003d controllers._get_barbican_context(pecan.request)"},{"line_number":363,"context_line":"        user_id \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9e4b3259","line":360,"range":{"start_line":355,"start_character":0,"end_line":360,"end_character":42},"updated":"2016-07-10 19:52:00.000000000","message":"Can you please write tests for the cases where these error cases occur?  Coverage is showing there aren\u0027t any.","commit_id":"fe3219845e9bec5c6da7ab3acdd543aa58c0ce01"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f79c6d55470d4134a8228ef1000fdcfda19b512b","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            # the default should be used."},{"line_number":353,"context_line":"            bits \u003d 0"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        for date_filter in \u0027created\u0027, \u0027updated\u0027, \u0027expiration\u0027:"},{"line_number":356,"context_line":"            if kw.get(date_filter) and not self._is_valid_date_filter("},{"line_number":357,"context_line":"                    kw.get(date_filter)):"},{"line_number":358,"context_line":"                _bad_query_string_parameters()"},{"line_number":359,"context_line":"        if kw.get(\u0027sort\u0027) and not self._is_valid_sorting(kw.get(\u0027sort\u0027)):"},{"line_number":360,"context_line":"            _bad_query_string_parameters()"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        ctxt \u003d controllers._get_barbican_context(pecan.request)"},{"line_number":363,"context_line":"        user_id \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_80ef9faf","line":360,"range":{"start_line":355,"start_character":0,"end_line":360,"end_character":42},"in_reply_to":"1aa78d24_9e4b3259","updated":"2016-07-18 21:15:31.000000000","message":"Done","commit_id":"fe3219845e9bec5c6da7ab3acdd543aa58c0ce01"}],"barbican/model/repositories.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"fdc09ad48e2c14a395aa379bc7b3660e376a3947","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"        return query"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _build_date_filter_query(self, query, attribute, date_filters):"},{"line_number":715,"context_line":"        \"\"\"Parses date_filters to apply each filter to the given query"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        :param query: query object to apply filters to"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3e631edf","line":714,"range":{"start_line":714,"start_character":4,"end_line":714,"end_character":32},"updated":"2016-07-10 19:52:00.000000000","message":"Can you please write tests for this?  It\u0027s a lot of new functionality.","commit_id":"fe3219845e9bec5c6da7ab3acdd543aa58c0ce01"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"f79c6d55470d4134a8228ef1000fdcfda19b512b","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"        return query"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _build_date_filter_query(self, query, attribute, date_filters):"},{"line_number":715,"context_line":"        \"\"\"Parses date_filters to apply each filter to the given query"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        :param query: query object to apply filters to"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_08260dce","line":714,"range":{"start_line":714,"start_character":4,"end_line":714,"end_character":32},"in_reply_to":"1aa78d24_3e631edf","updated":"2016-07-18 21:15:31.000000000","message":"It was tricky to test these.  I ended up writing a Fixture that populates an in-memory db with specific test data.  I couldn\u0027t find a way to do it with the current test case class heriarchy since the other unit tests in this module don\u0027t allow us to set the created_at or updated_at attributes to arbitrary values.","commit_id":"fe3219845e9bec5c6da7ab3acdd543aa58c0ce01"}],"barbican/tests/fixture.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9208c48dbf017ba9fb2ef269adad200de9b73643","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from barbican.model import models"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class SessionQueryFixture(fixtures.Fixture):"},{"line_number":21,"context_line":"    \"\"\"Fixture for testing queries on a session"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This fixture creates a SQLAlchemy sessionmaker for an in-memory"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_07108e4d","line":20,"updated":"2016-07-19 16:00:48.000000000","message":"I thought we already had in-memory unit tests, but don\u0027t mind the more explicit logic here.","commit_id":"55912386d529b4699f5d909271bc398d5254d5bf"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"083f5a1bd115f970555cf964ef9138890b15b0f7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from barbican.model import models"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class SessionQueryFixture(fixtures.Fixture):"},{"line_number":21,"context_line":"    \"\"\"Fixture for testing queries on a session"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This fixture creates a SQLAlchemy sessionmaker for an in-memory"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_9eb5dfef","line":20,"in_reply_to":"dada55a8_07108e4d","updated":"2016-07-19 19:45:43.000000000","message":"We do have an in-memory sqlite db set up for unit testing, but I feel like they\u0027re more of an integration test kind of setup, since it uses the repo to load secrets into the db, which means it doesn\u0027t have a way to assign arbitrary values to the \u0027created_at\u0027 and \u0027updated_at\u0027 properties.","commit_id":"55912386d529b4699f5d909271bc398d5254d5bf"}],"barbican/tests/model/repositories/test_repositories_secrets.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"9208c48dbf017ba9fb2ef269adad200de9b73643","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.assertEqual(1, count)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class WhenTestingQueryFilters(testtools.TestCase,"},{"line_number":252,"context_line":"                              fixtures.TestWithFixtures):"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_e758da34","line":251,"updated":"2016-07-19 16:00:48.000000000","message":"Digging this testing!","commit_id":"55912386d529b4699f5d909271bc398d5254d5bf"}]}