)]}'
{"barbican/common/config.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"e8a7fcb6e85de2180f4f9800015aabfa992652da","unresolved":false,"context_lines":[{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"db_opts \u003d ["},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027sql_connection\u0027, secret\u003dTrue),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027sql_idle_timeout\u0027, default\u003d3600),"},{"line_number":59,"context_line":"    cfg.IntOpt(\u0027sql_max_retries\u0027, default\u003d60),"},{"line_number":60,"context_line":"    cfg.IntOpt(\u0027sql_retry_interval\u0027, default\u003d1),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_17174da4","side":"PARENT","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":44},"updated":"2017-03-17 09:31:29.000000000","message":"Guess we may not want to remove this ?","commit_id":"2b2c044dd35a40261facd7c11b23e7eea5d921a2"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"572bcd73af7961726aaf2e3edfa6f10194eda7a5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"db_opts \u003d ["},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027sql_connection\u0027, secret\u003dTrue),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027sql_idle_timeout\u0027, default\u003d3600),"},{"line_number":59,"context_line":"    cfg.IntOpt(\u0027sql_max_retries\u0027, default\u003d60),"},{"line_number":60,"context_line":"    cfg.IntOpt(\u0027sql_retry_interval\u0027, default\u003d1),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_926fcb91","side":"PARENT","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":44},"in_reply_to":"1a1ced50_17174da4","updated":"2017-03-17 09:32:54.000000000","message":"I agree with Jeremy. This should be kept secret, else we will start exposing credentials.","commit_id":"2b2c044dd35a40261facd7c11b23e7eea5d921a2"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"3ae09bf8bbb40534d3fc7536ef8a0ce807dc0064","unresolved":false,"context_lines":[{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"db_opts \u003d ["},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027sql_connection\u0027, secret\u003dTrue),"},{"line_number":58,"context_line":"    cfg.IntOpt(\u0027sql_idle_timeout\u0027, default\u003d3600),"},{"line_number":59,"context_line":"    cfg.IntOpt(\u0027sql_max_retries\u0027, default\u003d60),"},{"line_number":60,"context_line":"    cfg.IntOpt(\u0027sql_retry_interval\u0027, default\u003d1),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_df4d8c9a","side":"PARENT","line":57,"range":{"start_line":57,"start_character":32,"end_line":57,"end_character":44},"in_reply_to":"1a1ced50_926fcb91","updated":"2017-03-20 13:01:30.000000000","message":"Done","commit_id":"2b2c044dd35a40261facd7c11b23e7eea5d921a2"}],"barbican/plugin/crypto/manager.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"e8a7fcb6e85de2180f4f9800015aabfa992652da","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def list_opts():"},{"line_number":54,"context_line":"    yield crypto_opt_group, crypto_opts"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class _CryptoPluginManager(named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_327c5772","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":26},"updated":"2017-03-17 09:31:29.000000000","message":"this returns the cfg.OptGroup object","commit_id":"1087ea74245463183d806105e9296abcf3531614"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"3ae09bf8bbb40534d3fc7536ef8a0ce807dc0064","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def list_opts():"},{"line_number":54,"context_line":"    yield crypto_opt_group, crypto_opts"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class _CryptoPluginManager(named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_9f02340a","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":26},"in_reply_to":"1a1ced50_327c5772","updated":"2017-03-20 13:01:30.000000000","message":"Done","commit_id":"1087ea74245463183d806105e9296abcf3531614"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"f8e22e578c64ab412e37c8ae678625514512ffc2","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def list_opts():"},{"line_number":54,"context_line":"    yield crypto_opt_group.name, crypto_opts"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class _CryptoPluginManager(named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a1ced50_8b19167c","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":31},"updated":"2017-03-20 14:21:50.000000000","message":"The \"name\" is returned here, but in \"barbican/plugin/crypto/p11_crypto.py\", the group object is returned.\n\nMy previous question is similar - why the two same functions return different values ?","commit_id":"6b2b4057f52dddaa962df75fb13d3f9272b9b389"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"92c4c6b939be540b4f75c3eb76245b0ff37b0583","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def list_opts():"},{"line_number":54,"context_line":"    yield crypto_opt_group.name, crypto_opts"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class _CryptoPluginManager(named.NamedExtensionManager):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a1ced50_0f3ead27","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":31},"in_reply_to":"1a1ced50_8b19167c","updated":"2017-03-22 13:35:32.000000000","message":"Ah. Got it now. Seems that it does not matter because oslo.config use the name automatically if a OptGroup instance is detected.\nBut I fixed it all over the changeset to be consistent.","commit_id":"6b2b4057f52dddaa962df75fb13d3f9272b9b389"}],"barbican/plugin/interface/certificate_manager.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"e8a7fcb6e85de2180f4f9800015aabfa992652da","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def list_opts():"},{"line_number":64,"context_line":"    yield cert_opt_group.name, cert_opts"},{"line_number":65,"context_line":"    yield cert_event_opt_group.name, cert_event_opts"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_12ee7b22","line":64,"range":{"start_line":64,"start_character":10,"end_line":64,"end_character":29},"updated":"2017-03-17 09:31:29.000000000","message":"this just returns the \u0027name\u0027\n\nSo why keep them different ?","commit_id":"1087ea74245463183d806105e9296abcf3531614"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"3ae09bf8bbb40534d3fc7536ef8a0ce807dc0064","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def list_opts():"},{"line_number":64,"context_line":"    yield cert_opt_group.name, cert_opts"},{"line_number":65,"context_line":"    yield cert_event_opt_group.name, cert_event_opts"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_ba9b7ec8","line":64,"range":{"start_line":64,"start_character":10,"end_line":64,"end_character":29},"in_reply_to":"1a1ced50_12ee7b22","updated":"2017-03-20 13:01:30.000000000","message":"What do you mean? It returns \"certificate\" which is used as group name. Isn\u0027t that what we want?","commit_id":"1087ea74245463183d806105e9296abcf3531614"}],"devstack/lib/barbican":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"5b134b264db16f77790ffa526602d645c5fe55b0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    sudo chown $USER $BARBICAN_CONF_DIR"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # Copy the barbican config files to the config dir"},{"line_number":97,"context_line":"    cp $BARBICAN_DIR/etc/barbican/barbican.conf $BARBICAN_CONF_DIR"},{"line_number":98,"context_line":"    cp $BARBICAN_DIR/etc/barbican/barbican-api-paste.ini $BARBICAN_CONF_DIR"},{"line_number":99,"context_line":"    cp -R $BARBICAN_DIR/etc/barbican/vassals $BARBICAN_CONF_DIR"},{"line_number":100,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"1a1ced50_d4079cc7","side":"PARENT","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":66},"updated":"2017-03-23 10:14:12.000000000","message":"Shouldn\u0027t we generate the configuration file and copy to /etc/barbican ?","commit_id":"e88d79cae0c0b757c25becf8b65c6f078bc176fa"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a309e50312d5a162a625ecbbb9c086cb00877931","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    sudo chown $USER $BARBICAN_CONF_DIR"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # Copy the barbican config files to the config dir"},{"line_number":97,"context_line":"    cp $BARBICAN_DIR/etc/barbican/barbican.conf $BARBICAN_CONF_DIR"},{"line_number":98,"context_line":"    cp $BARBICAN_DIR/etc/barbican/barbican-api-paste.ini $BARBICAN_CONF_DIR"},{"line_number":99,"context_line":"    cp -R $BARBICAN_DIR/etc/barbican/vassals $BARBICAN_CONF_DIR"},{"line_number":100,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"dfeb2761_cda9957c","side":"PARENT","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":66},"in_reply_to":"1a1ced50_d4079cc7","updated":"2017-04-05 06:03:05.000000000","message":"That\u0027s usually not what is done in a devstack env. You don\u0027t need the config file because all values in the generated config are anyway the default.\nSo setting specific values (with iniset) should be enough.","commit_id":"e88d79cae0c0b757c25becf8b65c6f078bc176fa"}],"etc/oslo-config-generator/barbican.conf":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"5b134b264db16f77790ffa526602d645c5fe55b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"namespace \u003d keystonemiddleware.auth_token"},{"line_number":14,"context_line":"namespace \u003d oslo.log"},{"line_number":15,"context_line":"namespace \u003d oslo.messaging"},{"line_number":16,"context_line":"namespace \u003d oslo.middleware.cors"},{"line_number":17,"context_line":"namespace \u003d oslo.policy"},{"line_number":18,"context_line":"namespace \u003d oslo.service.periodic_task"},{"line_number":19,"context_line":"namespace \u003d oslo.service.sslutils"}],"source_content_type":"text/plain","patch_set":20,"id":"1a1ced50_54cd6c64","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":32},"updated":"2017-03-23 10:14:12.000000000","message":"missing \u0027oslo.middleware.http_proxy_to_wsgi\u0027 which is configured in barbican-api-paste.ini, see [1]\n\n[1] https://github.com/openstack/barbican/blob/master/etc/barbican/barbican-api-paste.ini","commit_id":"99f577ccda21bf5ec03f2947654bada95c790a40"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"364bf2ac7d0d39f7a2223f5ed6a91b61a0b8a207","unresolved":false,"context_lines":[{"line_number":13,"context_line":"namespace \u003d keystonemiddleware.auth_token"},{"line_number":14,"context_line":"namespace \u003d oslo.log"},{"line_number":15,"context_line":"namespace \u003d oslo.messaging"},{"line_number":16,"context_line":"namespace \u003d oslo.middleware.cors"},{"line_number":17,"context_line":"namespace \u003d oslo.policy"},{"line_number":18,"context_line":"namespace \u003d oslo.service.periodic_task"},{"line_number":19,"context_line":"namespace \u003d oslo.service.sslutils"}],"source_content_type":"text/plain","patch_set":20,"id":"dfeb2761_ed7b3925","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":32},"in_reply_to":"1a1ced50_54cd6c64","updated":"2017-04-05 05:58:41.000000000","message":"true that, thanks Jeremy","commit_id":"99f577ccda21bf5ec03f2947654bada95c790a40"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a309e50312d5a162a625ecbbb9c086cb00877931","unresolved":false,"context_lines":[{"line_number":13,"context_line":"namespace \u003d keystonemiddleware.auth_token"},{"line_number":14,"context_line":"namespace \u003d oslo.log"},{"line_number":15,"context_line":"namespace \u003d oslo.messaging"},{"line_number":16,"context_line":"namespace \u003d oslo.middleware.cors"},{"line_number":17,"context_line":"namespace \u003d oslo.policy"},{"line_number":18,"context_line":"namespace \u003d oslo.service.periodic_task"},{"line_number":19,"context_line":"namespace \u003d oslo.service.sslutils"}],"source_content_type":"text/plain","patch_set":20,"id":"dfeb2761_adbf71a8","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":32},"in_reply_to":"dfeb2761_ed7b3925","updated":"2017-04-05 06:03:05.000000000","message":"Done","commit_id":"99f577ccda21bf5ec03f2947654bada95c790a40"}]}
