)]}'
{"doc/source/api/reference/store_backends.rst":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"e533411c61ed073894cc259fb8233ef557d3e116","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Barbican provides API to manage secret stores available in a deployment. APIs"},{"line_number":6,"context_line":"are provided for listing available secret stores and to manage project level"},{"line_number":7,"context_line":"secret store mapping.  For an introduction to multiple store backend support,"},{"line_number":8,"context_line":"see :doc:`Using Multiple Secret Store Plugins \u003c/setup/plugin_backends\u003e` . This"},{"line_number":9,"context_line":"document will focus on the details of the Barbican `/v1/secret-stores` REST API."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_8c723110","line":7,"range":{"start_line":7,"start_character":61,"end_line":7,"end_character":68},"updated":"2016-07-14 02:15:04.000000000","message":"backends.\nCheck overall.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"c343b7f4fa49f4cde679b3a69db1da6fc82d925e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Barbican provides API to manage secret stores available in a deployment. APIs"},{"line_number":6,"context_line":"are provided for listing available secret stores and to manage project level"},{"line_number":7,"context_line":"secret store mapping.  For an introduction to multiple store backend support,"},{"line_number":8,"context_line":"see :doc:`Using Multiple Secret Store Plugins \u003c/setup/plugin_backends\u003e` . This"},{"line_number":9,"context_line":"document will focus on the details of the Barbican `/v1/secret-stores` REST API."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_f96b8c1d","line":7,"range":{"start_line":7,"start_character":61,"end_line":7,"end_character":68},"in_reply_to":"1aa78d24_8c723110","updated":"2016-07-14 18:03:52.000000000","message":"Ok.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"e533411c61ed073894cc259fb8233ef557d3e116","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"         {"},{"line_number":110,"context_line":"            \"name\": \"store_crypto + p11_crypto\","},{"line_number":111,"context_line":"            \"global_default\": false,"},{"line_number":112,"context_line":"            \"store_plugin\": \"store_crypto\","},{"line_number":113,"context_line":"            \"crypto_plugin\": \"p11_crypto\","},{"line_number":114,"context_line":"            \"status\": \"Active\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_6c93855d","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":35},"updated":"2016-07-14 02:15:04.000000000","message":"Does this \"global_default\" mean \"global_default\" to the project or to the service?","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"c343b7f4fa49f4cde679b3a69db1da6fc82d925e","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"         {"},{"line_number":110,"context_line":"            \"name\": \"store_crypto + p11_crypto\","},{"line_number":111,"context_line":"            \"global_default\": false,"},{"line_number":112,"context_line":"            \"store_plugin\": \"store_crypto\","},{"line_number":113,"context_line":"            \"crypto_plugin\": \"p11_crypto\","},{"line_number":114,"context_line":"            \"status\": \"Active\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_798ddc29","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":35},"in_reply_to":"1aa78d24_6c93855d","updated":"2016-07-14 18:03:52.000000000","message":"Its global at service level i.e. any project secrets which don\u0027t have preferred store backend will use this backend for storing their secret.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0a55223c9e4864a111d32635a990e8ec9b8a0bc9","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"         {"},{"line_number":110,"context_line":"            \"name\": \"store_crypto + p11_crypto\","},{"line_number":111,"context_line":"            \"global_default\": false,"},{"line_number":112,"context_line":"            \"store_plugin\": \"store_crypto\","},{"line_number":113,"context_line":"            \"crypto_plugin\": \"p11_crypto\","},{"line_number":114,"context_line":"            \"status\": \"Active\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_a66c1709","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":35},"in_reply_to":"1aa78d24_798ddc29","updated":"2016-07-15 14:14:08.000000000","message":"Maybe we can use global_preferred instead.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ef344c5b9178ded482278aafaf2f5147d9aeb027","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"         {"},{"line_number":110,"context_line":"            \"name\": \"store_crypto + p11_crypto\","},{"line_number":111,"context_line":"            \"global_default\": false,"},{"line_number":112,"context_line":"            \"store_plugin\": \"store_crypto\","},{"line_number":113,"context_line":"            \"crypto_plugin\": \"p11_crypto\","},{"line_number":114,"context_line":"            \"status\": \"Active\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_bdd95cf5","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":35},"in_reply_to":"1aa78d24_a66c1709","updated":"2016-07-21 15:33:08.000000000","message":"I had that earlier at db model level but one of review mentioned its preference for \u0027global-default\u0027.\n\nhttps://review.openstack.org/#/c/263972/6/specs/newton/multiple-secret-backend.rst (line #154). \n\nI will modify API to refer \u0027/secret-stores/global-default\u0027 to make it consistent all across.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"e533411c61ed073894cc259fb8233ef557d3e116","unresolved":false,"context_lines":[{"line_number":307,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"GET /v1/secret-stores/global-preferred"},{"line_number":311,"context_line":"######################################"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"A project or service administrator can can request a reference to the secret"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_0ce001fa","line":310,"range":{"start_line":310,"start_character":0,"end_line":310,"end_character":38},"updated":"2016-07-14 02:15:04.000000000","message":"OK, I was a little confused between \"global-preferred\" and \"global_default\".","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"c343b7f4fa49f4cde679b3a69db1da6fc82d925e","unresolved":false,"context_lines":[{"line_number":307,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"GET /v1/secret-stores/global-preferred"},{"line_number":311,"context_line":"######################################"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"A project or service administrator can can request a reference to the secret"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_1945b8b2","line":310,"range":{"start_line":310,"start_character":0,"end_line":310,"end_character":38},"in_reply_to":"1aa78d24_0ce001fa","updated":"2016-07-14 18:03:52.000000000","message":"Looks like I can change this to /v1/secret-store/global-default to keep it as consistent terminology.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7211f1adc0464a563051b9454da086152a7adda9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/084c2098-66db-4401-8348-d969be0eddaa\""},{"line_number":48,"context_line":"               },"},{"line_number":49,"context_line":"               {"},{"line_number":50,"context_line":"                  \"name\": \"Database Backend\","},{"line_number":51,"context_line":"                  \"global_default\": true,"},{"line_number":52,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/7776adb8-e865-413c-8ccc-4f09c3fe0213\""},{"line_number":53,"context_line":"               }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_c7562729","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":43},"updated":"2016-08-17 20:05:39.000000000","message":"This is confusing.  If this is supposed to represent the simple_crypto plugin, then it should be described as \"Software only crypto","commit_id":"d1916ea9ea912946c2015e2f6f2df1e42800a06a"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7211f1adc0464a563051b9454da086152a7adda9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"         {"},{"line_number":119,"context_line":"            \"name\": \"PKCS11 HSM\","},{"line_number":120,"context_line":"            \"global_default\": false,"},{"line_number":121,"context_line":"            \"store_plugin\": \"store_crypto\","},{"line_number":122,"context_line":"            \"crypto_plugin\": \"p11_crypto\","},{"line_number":123,"context_line":"            \"status\": \"Active\","},{"line_number":124,"context_line":"            \"updated\": \"2016-06-22T05:34:37.415647\","},{"line_number":125,"context_line":"            \"created\": \"2016-05-22T05:25:35.305647\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_87270fc9","line":122,"range":{"start_line":121,"start_character":12,"end_line":122,"end_character":42},"updated":"2016-08-17 20:05:39.000000000","message":"Remove these from API.  This is internal to barbican, and probably should not be exposed to the customers.","commit_id":"d1916ea9ea912946c2015e2f6f2df1e42800a06a"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4959e063066007d21a831951e8c8195c6886e50c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":166,"context_line":"| 404  | Not Found. When multiple secret store backends support is not enabled.   |"},{"line_number":167,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"GET /v1/secret-stores/preferred"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ac06dbe_aaceeb57","line":168,"updated":"2016-08-19 19:12:58.000000000","message":"404 - when multiple secret stores not enabled OR that secret store does not exist.","commit_id":"1ed8354c3ee44e546cfc5eb9be0007f8c299fd24"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"71b98787b918de867a9704a4e45a8406392ce93b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":166,"context_line":"| 404  | Not Found. When multiple secret store backends support is not enabled.   |"},{"line_number":167,"context_line":"+------+--------------------------------------------------------------------------+"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"GET /v1/secret-stores/preferred"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ac06dbe_f07e12ad","line":168,"in_reply_to":"1ac06dbe_aaceeb57","updated":"2016-08-19 19:33:17.000000000","message":"Yes. Will correct it.","commit_id":"1ed8354c3ee44e546cfc5eb9be0007f8c299fd24"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"52374f79c272d669990b0e210af3cddf4ec522cb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"When multiple secret store backends support is not enabled in service"},{"line_number":12,"context_line":"configuration, then all of these API will return resource not found (http"},{"line_number":13,"context_line":"status code 404) error. Error message text will highlight that the support is"},{"line_number":14,"context_line":"not enabled in configuration."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"GET /v1/secret-stores"},{"line_number":17,"context_line":"#####################"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ac06dbe_69e8787d","line":14,"updated":"2016-08-19 22:07:52.000000000","message":"I think it would be good to describe the difference between \u0027global-default\u0027 and \u0027gpreferred\u0027. I think the former is a default defined across all projects, and the latter an admin configured one per project. So a per-project preferred setting overrides the default. If there is no preferred one, then the default is used.\n\nWhat happens if the default one is not set via API? Can it be configured by deployers? \n\nAlso, will non-admin users eventually be able to see what plugins are preferred/default, or be able to specify when backend they want their secret stored in via the secret-store ref?","commit_id":"492897e7e2bd373cdf5e3204f4f07df54c16ea33"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"6f7155bef57f49420b7d25e45b704e3970030221","unresolved":false,"context_lines":[{"line_number":11,"context_line":"When multiple secret store backends support is not enabled in service"},{"line_number":12,"context_line":"configuration, then all of these API will return resource not found (http"},{"line_number":13,"context_line":"status code 404) error. Error message text will highlight that the support is"},{"line_number":14,"context_line":"not enabled in configuration."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"GET /v1/secret-stores"},{"line_number":17,"context_line":"#####################"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ac06dbe_e8a23d98","line":14,"in_reply_to":"1ac06dbe_69e8787d","updated":"2016-08-23 00:18:15.000000000","message":"There are details mentioned in new plugin_backends doc file. I can add a brief detail here as well.\n\nglobal-default is read-only service configuration. Via API, project admin can set preferred store only.\n\nAs per earlier comments/discussion in its spec, the decision was that only project-admins can access these secret-stores API. Only those users can read and change them so no need to expose it to non-admin users.","commit_id":"492897e7e2bd373cdf5e3204f4f07df54c16ea33"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"52374f79c272d669990b0e210af3cddf4ec522cb","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        Request:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"          GET /v1/secret-stores/global-preferred"},{"line_number":337,"context_line":"          Headers:"},{"line_number":338,"context_line":"            X-Auth-Token: \"f9cf2d480ba3485f85bdb9d07a4959f1\""},{"line_number":339,"context_line":"            Accept: application/json"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ac06dbe_c91d2cbf","line":336,"updated":"2016-08-19 22:07:52.000000000","message":"I think you mean \u0027global-default\u0027 here?","commit_id":"492897e7e2bd373cdf5e3204f4f07df54c16ea33"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"6f7155bef57f49420b7d25e45b704e3970030221","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        Request:"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"          GET /v1/secret-stores/global-preferred"},{"line_number":337,"context_line":"          Headers:"},{"line_number":338,"context_line":"            X-Auth-Token: \"f9cf2d480ba3485f85bdb9d07a4959f1\""},{"line_number":339,"context_line":"            Accept: application/json"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1ac06dbe_28a9f57b","line":336,"in_reply_to":"1ac06dbe_c91d2cbf","updated":"2016-08-23 00:18:15.000000000","message":"Right. Will fix it.","commit_id":"492897e7e2bd373cdf5e3204f4f07df54c16ea33"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a980b1bfbad418737ac14c9ba0220e368bc59559","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":53,"context_line":"                  \"global_default\": True,"},{"line_number":54,"context_line":"                  \"crypto_plugin\": \"p11_crypto\","},{"line_number":55,"context_line":"                  \"secret_store_id\": \"4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":56,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":57,"context_line":"               },"},{"line_number":58,"context_line":"               {"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_d5e83313","line":55,"updated":"2016-08-26 21:17:17.000000000","message":"What is the \u0027secret_store_id\u0027 used for? We\u0027ve standardized on the _ref HATEAOS approach for v1 anyway.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e5ee0926e3846cce1ae95d150713571b1940c19e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":53,"context_line":"                  \"global_default\": True,"},{"line_number":54,"context_line":"                  \"crypto_plugin\": \"p11_crypto\","},{"line_number":55,"context_line":"                  \"secret_store_id\": \"4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":56,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":57,"context_line":"               },"},{"line_number":58,"context_line":"               {"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_4681f08e","line":55,"in_reply_to":"fa7ab95a_20ce945a","updated":"2016-08-31 16:24:48.000000000","message":"I agree with John that this is inconsistent with our other apis.  Its also another thing we need to keep track of.\n\nNot having this field is a little more work, but is consistent.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"792f744102d8a29fe816152ad208ba11585be722","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":53,"context_line":"                  \"global_default\": True,"},{"line_number":54,"context_line":"                  \"crypto_plugin\": \"p11_crypto\","},{"line_number":55,"context_line":"                  \"secret_store_id\": \"4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":56,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":57,"context_line":"               },"},{"line_number":58,"context_line":"               {"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_f6801a4c","line":55,"in_reply_to":"fa7ab95a_d5e83313","updated":"2016-08-31 08:53:05.000000000","message":"I was thinking that client can avoid the additional steps needed to get UUID e.g. https://github.com/openstack/castellan/blob/master/castellan/key_manager/barbican_key_manager.py#L405\n\nJohn, let me know if you prefer to remove this as I have to remove related test changes in review part 4 and 5.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"44511d25442df4e0cd420bed4244cc4c22ac84dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":53,"context_line":"                  \"global_default\": True,"},{"line_number":54,"context_line":"                  \"crypto_plugin\": \"p11_crypto\","},{"line_number":55,"context_line":"                  \"secret_store_id\": \"4d27b7a7-b82f-491d-88c0-746bd67dadc8\","},{"line_number":56,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":57,"context_line":"               },"},{"line_number":58,"context_line":"               {"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_20ce945a","line":55,"in_reply_to":"fa7ab95a_f6801a4c","updated":"2016-08-31 16:14:17.000000000","message":"No strong opinions other than this is inconsistent with our other APIs. I\u0027ll defer to others about that though.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a980b1bfbad418737ac14c9ba0220e368bc59559","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               {"},{"line_number":70,"context_line":"                  \"status\": \"ACTIVE\","},{"line_number":71,"context_line":"                  \"updated\": \"2016-08-22T23:46:45.127866\","},{"line_number":72,"context_line":"                  \"name\": \"Software Only Crypto\","},{"line_number":73,"context_line":"                  \"created\": \"2016-08-22T23:46:45.127866\","},{"line_number":74,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":75,"context_line":"                  \"global_default\": False,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_d54cb372","line":72,"updated":"2016-08-26 21:17:17.000000000","message":"Maybe we should add \"(Not Secure)\" to emphasize this is not a secure plugin option?","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"44511d25442df4e0cd420bed4244cc4c22ac84dd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               {"},{"line_number":70,"context_line":"                  \"status\": \"ACTIVE\","},{"line_number":71,"context_line":"                  \"updated\": \"2016-08-22T23:46:45.127866\","},{"line_number":72,"context_line":"                  \"name\": \"Software Only Crypto\","},{"line_number":73,"context_line":"                  \"created\": \"2016-08-22T23:46:45.127866\","},{"line_number":74,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":75,"context_line":"                  \"global_default\": False,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_601dfcbc","line":72,"in_reply_to":"fa7ab95a_56862614","updated":"2016-08-31 16:14:17.000000000","message":"That make sense, so the current name is fine.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"792f744102d8a29fe816152ad208ba11585be722","unresolved":false,"context_lines":[{"line_number":69,"context_line":"               {"},{"line_number":70,"context_line":"                  \"status\": \"ACTIVE\","},{"line_number":71,"context_line":"                  \"updated\": \"2016-08-22T23:46:45.127866\","},{"line_number":72,"context_line":"                  \"name\": \"Software Only Crypto\","},{"line_number":73,"context_line":"                  \"created\": \"2016-08-22T23:46:45.127866\","},{"line_number":74,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":75,"context_line":"                  \"global_default\": False,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_56862614","line":72,"in_reply_to":"fa7ab95a_d54cb372","updated":"2016-08-31 08:53:05.000000000","message":"In context of this API, do we need to have that text here? Asking as this name value is coming from default defined for \u0027plugin_name\u0027 in its crypto plugin.\n\nIMHO, this plugin is not as secure as a HSM option even though it can be a valid option for some when its used for non-production or not overly sensitive workloads.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a980b1bfbad418737ac14c9ba0220e368bc59559","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                  \"global_default\": False,"},{"line_number":76,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":77,"context_line":"                  \"secret_store_id\": \"0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":78,"context_line":"                  \"store_plugin\": \"kmip_plugin\""},{"line_number":79,"context_line":"               }"},{"line_number":80,"context_line":"         }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_f519b77a","line":78,"updated":"2016-08-26 21:17:17.000000000","message":"Is this representing the default plugin? If so this should change to this: \"store_plugin\": \"store crypto\".","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"44511d25442df4e0cd420bed4244cc4c22ac84dd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                  \"global_default\": False,"},{"line_number":76,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":77,"context_line":"                  \"secret_store_id\": \"0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":78,"context_line":"                  \"store_plugin\": \"kmip_plugin\""},{"line_number":79,"context_line":"               }"},{"line_number":80,"context_line":"         }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_006d1032","line":78,"in_reply_to":"fa7ab95a_5648e687","updated":"2016-08-31 16:14:17.000000000","message":"Cool, thanks.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"792f744102d8a29fe816152ad208ba11585be722","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                  \"global_default\": False,"},{"line_number":76,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":77,"context_line":"                  \"secret_store_id\": \"0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":78,"context_line":"                  \"store_plugin\": \"kmip_plugin\""},{"line_number":79,"context_line":"               }"},{"line_number":80,"context_line":"         }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fa7ab95a_5648e687","line":78,"in_reply_to":"fa7ab95a_f519b77a","updated":"2016-08-31 08:53:05.000000000","message":"Its a typo. It should be \u0027store_crypto\u0027 as we already have kmip plugin earlier.","commit_id":"24d0f0939d589d49246cea40390bd9b8a6e25041"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"0ae7c3f1726f6c8fe4ef37702c6b68773cca3577","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":73,"context_line":"                  \"global_default\": False,"},{"line_number":74,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":75,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":76,"context_line":"               }"},{"line_number":77,"context_line":"         }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"fa7ab95a_3aa5ce03","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":31},"updated":"2016-08-31 22:52:38.000000000","message":"can we rename these \"secret_store_plugin\" for consistency?  I think it will reduce confusion.","commit_id":"d46d10f51618af579a0ea1c05149da02963a1055"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"99fabedefd54b5960df2af494fc567e26ca52b66","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":73,"context_line":"                  \"global_default\": False,"},{"line_number":74,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":75,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":76,"context_line":"               }"},{"line_number":77,"context_line":"         }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a89bdaa_5c15be3d","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":31},"in_reply_to":"da7fb54a_553e2cb9","updated":"2016-09-07 17:59:15.000000000","message":"I\u0027m fine with the field name as it is.  I think its clear given the fact that this is a secret_store.","commit_id":"d46d10f51618af579a0ea1c05149da02963a1055"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"e2fa178b73d45723ba002579d33d83d4b4193d15","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                  \"secret_store_ref\": \"http://localhost:9311/v1/secret-stores/0da45858-9420-42fe-a269-011f5f35deaa\","},{"line_number":73,"context_line":"                  \"global_default\": False,"},{"line_number":74,"context_line":"                  \"crypto_plugin\": \"simple_crypto\","},{"line_number":75,"context_line":"                  \"store_plugin\": \"store_crypto\""},{"line_number":76,"context_line":"               }"},{"line_number":77,"context_line":"         }"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"da7fb54a_553e2cb9","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":31},"in_reply_to":"fa7ab95a_3aa5ce03","updated":"2016-09-02 16:19:33.000000000","message":"Its used in context of secret-stores data. So both plugins names are in turn meant for secret. IMHO, I was thinking its clear as their purpose is specified in field name.\n\nI can rename it to suggested name but then does it mean that \u0027crypto_plugin\u0027 field needs to be renamed to \u0027secret_crypto_plugin\u0027 as well.\n\nIf that\u0027s the preference, let me know and I will make this change. Want to check before making this change as it will require changes in 2  reviews.","commit_id":"d46d10f51618af579a0ea1c05149da02963a1055"}],"doc/source/setup/plugin_backends.rst":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"e533411c61ed073894cc259fb8233ef557d3e116","unresolved":false,"context_lines":[{"line_number":30,"context_line":"backend as the preferred choice for secrets created under that project. Any"},{"line_number":31,"context_line":"**new** secret created under that project will use the preferred backend to"},{"line_number":32,"context_line":"store its key material. When there is no project level storage backend"},{"line_number":33,"context_line":"selected, then new secret will use the global secret storage backend."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. code-block:: ini"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_0ceac1ac","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":45},"updated":"2016-07-14 02:15:04.000000000","message":"Maybe this be global-preferred.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"c343b7f4fa49f4cde679b3a69db1da6fc82d925e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"backend as the preferred choice for secrets created under that project. Any"},{"line_number":31,"context_line":"**new** secret created under that project will use the preferred backend to"},{"line_number":32,"context_line":"store its key material. When there is no project level storage backend"},{"line_number":33,"context_line":"selected, then new secret will use the global secret storage backend."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. code-block:: ini"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aa78d24_5966202a","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":45},"in_reply_to":"1aa78d24_0ceac1ac","updated":"2016-07-14 18:03:52.000000000","message":"I can change it to global-default if its not clear. Did not want to add global-default in every line..just want to highlight the context.","commit_id":"f508580508f5c2dcce4f205fed85ee7c614c7b3c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"3d302feccabdb2ca0d8b792516369113ba425207","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    enabled_crypto_plugins \u003d simple_crypto"},{"line_number":49,"context_line":"    enabled_crypto_plugins \u003d"},{"line_number":50,"context_line":"    enabled_crypto_plugins \u003d p11_crypto"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Here secret store backend refers to combination of secret store and crypto"},{"line_number":53,"context_line":"plugin used to store a secret. In service configuration, ordering of these"},{"line_number":54,"context_line":"plugin matters as secret store definitions are created exactly in the order"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_0a4fa66b","line":51,"updated":"2016-08-17 19:58:24.000000000","message":"[secretstore]\nenable_multiple_secret_stores \u003d True\nenabled_secretstore_plugins \u003d store_crypto\nenabled_secretstore_plugins \u003d kmip_crypto\n\n[crypto]\nenabled_crypto_plugins \u003d simple_crypto\nenabled_crypto_plugins \u003d p11_crypto","commit_id":"d1916ea9ea912946c2015e2f6f2df1e42800a06a"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7211f1adc0464a563051b9454da086152a7adda9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    enabled_crypto_plugins \u003d simple_crypto"},{"line_number":49,"context_line":"    enabled_crypto_plugins \u003d"},{"line_number":50,"context_line":"    enabled_crypto_plugins \u003d p11_crypto"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Here secret store backend refers to combination of secret store and crypto"},{"line_number":53,"context_line":"plugin used to store a secret. In service configuration, ordering of these"},{"line_number":54,"context_line":"plugin matters as secret store definitions are created exactly in the order"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_0ab846c7","line":51,"in_reply_to":"3ac371cc_0a4fa66b","updated":"2016-08-17 20:05:39.000000000","message":"[secretstore]\nenable_multiple_secret_stores \u003d True\n\n[secretstore:kmip]\nsecret_store_plugin \u003d kmip_plugin\nglobal_default \u003d True\n\n[secretstore:pkcs11]\nsecret_store_plugin \u003d store_crypto\ncrypto_plugin \u003d p11_crypto\n\n[secretstore:software]\nsecret_store_plugin \u003d store_crypto\ncrypto_plugin \u003d simple_crypto","commit_id":"d1916ea9ea912946c2015e2f6f2df1e42800a06a"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"be3a987c8c6252f266685e0e1ae83d537cbfc84f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    enabled_crypto_plugins \u003d simple_crypto"},{"line_number":49,"context_line":"    enabled_crypto_plugins \u003d"},{"line_number":50,"context_line":"    enabled_crypto_plugins \u003d p11_crypto"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Here secret store backend refers to combination of secret store and crypto"},{"line_number":53,"context_line":"plugin used to store a secret. In service configuration, ordering of these"},{"line_number":54,"context_line":"plugin matters as secret store definitions are created exactly in the order"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3ac371cc_85438741","line":51,"in_reply_to":"3ac371cc_0ab846c7","updated":"2016-08-17 20:21:59.000000000","message":"[secretstore]\nenable_multiple_secret_stores \u003d True\nstores_lookup \u003d kmip, pkcs11, software\n\n[secretstore:kmip]\nsecret_store_plugin \u003d kmip_plugin\nglobal_default \u003d True\n\n[secretstore:pkcs11]\nsecret_store_plugin \u003d store_crypto\ncrypto_plugin \u003d p11_crypto\n\n[secretstore:software]\nsecret_store_plugin \u003d store_crypto\ncrypto_plugin \u003d simple_crypto","commit_id":"d1916ea9ea912946c2015e2f6f2df1e42800a06a"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4959e063066007d21a831951e8c8195c6886e50c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Multiple backends support may be needed in specific deployment/ use-case"},{"line_number":25,"context_line":"scenarios and can be enabled via configuration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For this, a Barbican deployment will have at least 2 secret storage backend"},{"line_number":28,"context_line":"added in service configuration. Project administrators will have choice of"},{"line_number":29,"context_line":"pre-selecting one backend as the preferred choice for secrets created under"},{"line_number":30,"context_line":"that project. Any **new** secret created under that project will use the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ac06dbe_0d0479be","line":27,"range":{"start_line":27,"start_character":32,"end_line":27,"end_character":75},"updated":"2016-08-19 19:12:58.000000000","message":"Its possible that a Barbican deployment could set enable_multiple_secret_stores \u003d True and for there to be only one secret store configured.\n\nThe number of secret stores configured is really determined by the number of entries in the lookup line.\n\nIn that sense, then - maybe the directives should be something like:\n\nuse_secret_store_lookup_suffix \u003d True\nstores_lookup_suffix \u003d X,Y,Z\n\nOr better yet, what if you were to check for the presence of the attribute: stores_lookup_suffix  ?\n\nIf the suffix is not present, then we are using the old config (and only one secret store).  If the attribute is presnet, then we instantiate stores as specified in the lookup_suffix.","commit_id":"1ed8354c3ee44e546cfc5eb9be0007f8c299fd24"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"71b98787b918de867a9704a4e45a8406392ce93b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Multiple backends support may be needed in specific deployment/ use-case"},{"line_number":25,"context_line":"scenarios and can be enabled via configuration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For this, a Barbican deployment will have at least 2 secret storage backend"},{"line_number":28,"context_line":"added in service configuration. Project administrators will have choice of"},{"line_number":29,"context_line":"pre-selecting one backend as the preferred choice for secrets created under"},{"line_number":30,"context_line":"that project. Any **new** secret created under that project will use the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1ac06dbe_70a4e256","line":27,"range":{"start_line":27,"start_character":32,"end_line":27,"end_character":75},"in_reply_to":"1ac06dbe_0d0479be","updated":"2016-08-19 19:33:17.000000000","message":"There is no restriction that minimum of 2 backends must be configured for multiple backends. \n\nAs long as, the flag is explicitly enabled and there is one global-default storage backend defined (so one backend in suffix), it should pass through validation and it should work.\n\nI was just trying to highlight that multiple backend is not useful unless you have at least 2 backends.\n\nDo you want me to re-word this or have suggestion?","commit_id":"1ed8354c3ee44e546cfc5eb9be0007f8c299fd24"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e8de3337985ba558e389b0fd453ab079d04a4118","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Multiple backends support may be needed in specific deployment/ use-case"},{"line_number":25,"context_line":"scenarios and can be enabled via configuration."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For this, a Barbican deployment will have more than one secret storage backend"},{"line_number":28,"context_line":"added in service configuration. Project administrators will have choice of"},{"line_number":29,"context_line":"pre-selecting one backend as the preferred choice for secrets created under"},{"line_number":30,"context_line":"that project. Any **new** secret created under that project will use the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1ac06dbe_dc968d93","line":27,"range":{"start_line":27,"start_character":31,"end_line":27,"end_character":47},"updated":"2016-08-19 20:20:26.000000000","message":"may have more","commit_id":"f20f613a47b253cb4c8ea18bbc19926dcbf74b35"}]}