)]}'
{"barbican/model/models.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"806603029677a6fcbc57492577a08f776c1e6613","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"    \"\"\"List of secret stores defined via service configuration."},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"    This class provides a list of secret stores with their respective"},{"line_number":1388,"context_line":"    crypto plugin names."},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    SecretStores deletes are NOT soft-deletes."},{"line_number":1391,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_5a12920a","line":1388,"updated":"2016-08-31 22:58:12.000000000","message":"I think this should say \u0027...respective secret-store and crypto plugin names\u0027, to distinguish the two levels of plugins this actually captures.","commit_id":"30a9c0d096398a3874c72a1ff661a8b69af7071f"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"b63008c11498be54c802492af96f9db7a86f76b4","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"    \"\"\"List of secret stores defined via service configuration."},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"    This class provides a list of secret stores with their respective"},{"line_number":1388,"context_line":"    crypto plugin names."},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    SecretStores deletes are NOT soft-deletes."},{"line_number":1391,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_d5fcb340","line":1388,"in_reply_to":"fa7ab95a_5a12920a","updated":"2016-08-31 23:25:20.000000000","message":"Agree, this should be corrected. Will address in next patch.","commit_id":"30a9c0d096398a3874c72a1ff661a8b69af7071f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"e156ac9c5375ad8255877d955741d984e0addd50","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"    def _do_extra_dict_fields(self):"},{"line_number":1426,"context_line":"        \"\"\"Sub-class hook method: return dict of fields.\"\"\""},{"line_number":1427,"context_line":"        return {\u0027secret_store_id\u0027: self.id,"},{"line_number":1428,"context_line":"                \u0027store_plugin\u0027: self.store_plugin,"},{"line_number":1429,"context_line":"                \u0027crypto_plugin\u0027: self.crypto_plugin,"},{"line_number":1430,"context_line":"                \u0027global_default\u0027: self.global_default,"},{"line_number":1431,"context_line":"                \u0027name\u0027: self.name}"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_6cc04251","line":1428,"updated":"2016-09-12 17:38:48.000000000","message":"I think this should be\n\n    \u0027secret_store_plugin\u0027: self.store_plugin,","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"607b446f9fcd6372e31fab3fe4077684e93ebeef","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"    def _do_extra_dict_fields(self):"},{"line_number":1426,"context_line":"        \"\"\"Sub-class hook method: return dict of fields.\"\"\""},{"line_number":1427,"context_line":"        return {\u0027secret_store_id\u0027: self.id,"},{"line_number":1428,"context_line":"                \u0027store_plugin\u0027: self.store_plugin,"},{"line_number":1429,"context_line":"                \u0027crypto_plugin\u0027: self.crypto_plugin,"},{"line_number":1430,"context_line":"                \u0027global_default\u0027: self.global_default,"},{"line_number":1431,"context_line":"                \u0027name\u0027: self.name}"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_e1c5388e","line":1428,"in_reply_to":"9a89bdaa_6cc04251","updated":"2016-09-12 18:50:31.000000000","message":"Yes, change has been made on REST API response side where field is renamed to \u0027secret_store_plugin\u0027.\n\nhttps://review.openstack.org/#/c/358162/10/barbican/api/controllers/secretstores.py (Line# 47)","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"}],"barbican/model/repositories.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"83494981d8a3d7e16b3b57a780d15993ba411add","unresolved":false,"context_lines":[{"line_number":2238,"context_line":"        \"\"\"Returns preferred secret store for a project if set."},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        :param project_id: ID of project whose preferred secret store is set"},{"line_number":2241,"context_line":"        :param external_project_id: external ID of project to delete quotas"},{"line_number":2242,"context_line":"        :param suppress_exception: when True, NotFound is not raised"},{"line_number":2243,"context_line":"        :param session: SQLAlchemy session object."},{"line_number":2244,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_512dd793","line":2241,"range":{"start_line":2241,"start_character":59,"end_line":2241,"end_character":75},"updated":"2016-09-07 04:33:21.000000000","message":"incorrect comment.","commit_id":"30a9c0d096398a3874c72a1ff661a8b69af7071f"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"3d465b4002af151f501e53073add3bdfb0ebb3c4","unresolved":false,"context_lines":[{"line_number":2238,"context_line":"        \"\"\"Returns preferred secret store for a project if set."},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"        :param project_id: ID of project whose preferred secret store is set"},{"line_number":2241,"context_line":"        :param external_project_id: external ID of project to delete quotas"},{"line_number":2242,"context_line":"        :param suppress_exception: when True, NotFound is not raised"},{"line_number":2243,"context_line":"        :param session: SQLAlchemy session object."},{"line_number":2244,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_0a7a2cbd","line":2241,"range":{"start_line":2241,"start_character":59,"end_line":2241,"end_character":75},"in_reply_to":"9a89bdaa_512dd793","updated":"2016-09-07 09:30:26.000000000","message":"Right...will fix in next patch.","commit_id":"30a9c0d096398a3874c72a1ff661a8b69af7071f"}],"barbican/tests/model/test_models.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"e156ac9c5375ad8255877d955741d984e0addd50","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        ss \u003d models.SecretStores(name, store_plugin, crypto_plugin,"},{"line_number":690,"context_line":"                                 global_default\u003dTrue)"},{"line_number":691,"context_line":"        self.assertEqual(store_plugin,"},{"line_number":692,"context_line":"                         ss.to_dict_fields()[\u0027store_plugin\u0027])"},{"line_number":693,"context_line":"        self.assertEqual(crypto_plugin,"},{"line_number":694,"context_line":"                         ss.to_dict_fields()[\u0027crypto_plugin\u0027])"},{"line_number":695,"context_line":"        self.assertEqual(True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_8cb3c699","line":692,"updated":"2016-09-12 17:38:48.000000000","message":"I think this should be\n\n    ss.to_dict_fields()[\u0027secret_store_plugin\u0027])","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"607b446f9fcd6372e31fab3fe4077684e93ebeef","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        ss \u003d models.SecretStores(name, store_plugin, crypto_plugin,"},{"line_number":690,"context_line":"                                 global_default\u003dTrue)"},{"line_number":691,"context_line":"        self.assertEqual(store_plugin,"},{"line_number":692,"context_line":"                         ss.to_dict_fields()[\u0027store_plugin\u0027])"},{"line_number":693,"context_line":"        self.assertEqual(crypto_plugin,"},{"line_number":694,"context_line":"                         ss.to_dict_fields()[\u0027crypto_plugin\u0027])"},{"line_number":695,"context_line":"        self.assertEqual(True,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_c143d411","line":692,"in_reply_to":"9a89bdaa_8cb3c699","updated":"2016-09-12 18:50:31.000000000","message":"Change has been made on rest API side and not in model.\n\nhttps://review.openstack.org/#/c/358162/10/barbican/api/controllers/secretstores.py (Line 47)","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"e156ac9c5375ad8255877d955741d984e0addd50","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # check with required input only"},{"line_number":702,"context_line":"        ss \u003d models.SecretStores(name, store_plugin)"},{"line_number":703,"context_line":"        self.assertEqual(store_plugin,"},{"line_number":704,"context_line":"                         ss.to_dict_fields()[\u0027store_plugin\u0027])"},{"line_number":705,"context_line":"        self.assertIsNone(ss.to_dict_fields()[\u0027crypto_plugin\u0027])"},{"line_number":706,"context_line":"        self.assertIsNone(ss.to_dict_fields()[\u0027global_default\u0027])"},{"line_number":707,"context_line":"        self.assertEqual(models.States.ACTIVE,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_2ca55a46","line":704,"updated":"2016-09-12 17:38:48.000000000","message":"I think this should be\n\n    ss.to_dict_fields()[\u0027secret_store_plugin\u0027])","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"607b446f9fcd6372e31fab3fe4077684e93ebeef","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # check with required input only"},{"line_number":702,"context_line":"        ss \u003d models.SecretStores(name, store_plugin)"},{"line_number":703,"context_line":"        self.assertEqual(store_plugin,"},{"line_number":704,"context_line":"                         ss.to_dict_fields()[\u0027store_plugin\u0027])"},{"line_number":705,"context_line":"        self.assertIsNone(ss.to_dict_fields()[\u0027crypto_plugin\u0027])"},{"line_number":706,"context_line":"        self.assertIsNone(ss.to_dict_fields()[\u0027global_default\u0027])"},{"line_number":707,"context_line":"        self.assertEqual(models.States.ACTIVE,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_4150a4d4","line":704,"in_reply_to":"9a89bdaa_2ca55a46","updated":"2016-09-12 18:50:31.000000000","message":"See above comment.","commit_id":"29edae6da2e8fea94a913530f89f737e1ad2695c"}]}
