)]}'
{"barbican/api/controllers/secretstores.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"9340a134ef9ca191eee3a2c84e3b049c5789305b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @controllers.enforce_rbac(\u0027secretstore_preferred:post\u0027)"},{"line_number":86,"context_line":"    def on_post(self, external_project_id, **kwargs):"},{"line_number":87,"context_line":"        LOG.debug(u._(\u0027Start: Set project preferred secret-store for store \u0027),"},{"line_number":88,"context_line":"                  \u0027id %s\u0027, self.secret_store.id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        project \u003d res.get_or_create_project(external_project_id)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_8359035d","line":88,"range":{"start_line":88,"start_character":18,"end_line":88,"end_character":25},"updated":"2016-08-27 14:25:15.000000000","message":"Better move this into brackets to keep the whole message for translation.","commit_id":"296050a2ed78bc3994a091a957f0474668ad552f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"7697b698774f846b4d67428cdb6df818f7d15c85","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            item \u003d convert_secret_store_to_response_format(store)"},{"line_number":175,"context_line":"            resp_list.append(item)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        resp \u003d {\u0027secret-stores\u0027: resp_list}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return resp"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_ca16dbf0","line":177,"updated":"2016-09-14 16:44:12.000000000","message":"Please change to:\n\n    resp \u003d {\u0027secret_stores\u0027: resp_list}\n\nJSON fields should use underscore (_) instead of hyphen (-) per the API Working Group\u0027s guideline: \n\nhttps://github.com/openstack/api-wg/blob/master/guidelines/naming.rst","commit_id":"0937e503ba92ec5150e4c974aead569a2388239f"}],"etc/barbican/policy.json":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"39fc00f4585c29e2698e2628d864e5dc91adebba","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"secretstores:get\": \"rule:admin\","},{"line_number":85,"context_line":"    \"secretstores:get_global_default\": \"rule:admin\","},{"line_number":86,"context_line":"    \"secretstores:get_preferred\": \"rule:admin\","},{"line_number":87,"context_line":"    \"secretstore_preferred:post\": \"rule:admin\","},{"line_number":88,"context_line":"    \"secretstore_preferred:delete\": \"rule:admin\","},{"line_number":89,"context_line":"    \"secretstore:get\": \"rule:admin\""},{"line_number":90,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"7a8ec9b2_20675b26","line":87,"updated":"2016-09-14 18:10:41.000000000","message":"I don\u0027t recall, but were #87 and #88 supposed to be service_admin access only?","commit_id":"6535e559cdf6f388a3c8c6292ccc41aad93842dc"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"9e9d085a3a6ff43e151378d3c8d751b31d6404d1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"secretstores:get\": \"rule:admin\","},{"line_number":85,"context_line":"    \"secretstores:get_global_default\": \"rule:admin\","},{"line_number":86,"context_line":"    \"secretstores:get_preferred\": \"rule:admin\","},{"line_number":87,"context_line":"    \"secretstore_preferred:post\": \"rule:admin\","},{"line_number":88,"context_line":"    \"secretstore_preferred:delete\": \"rule:admin\","},{"line_number":89,"context_line":"    \"secretstore:get\": \"rule:admin\""},{"line_number":90,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"7a8ec9b2_f3262fb9","line":87,"in_reply_to":"7a8ec9b2_20675b26","updated":"2016-09-14 18:13:41.000000000","message":"Its a project level setting, so a project admin should be able to do so. \nJust now, I checked API docs to verify and it says same.\nhttps://review.openstack.org/#/c/341803/13/doc/source/api/reference/store_backends.rst (Line #264)","commit_id":"6535e559cdf6f388a3c8c6292ccc41aad93842dc"},{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"fdd6d9d416bc75352ceada7f279faf80a4f96ab5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"secretstores:get\": \"rule:admin\","},{"line_number":85,"context_line":"    \"secretstores:get_global_default\": \"rule:admin\","},{"line_number":86,"context_line":"    \"secretstores:get_preferred\": \"rule:admin\","},{"line_number":87,"context_line":"    \"secretstore_preferred:post\": \"rule:admin\","},{"line_number":88,"context_line":"    \"secretstore_preferred:delete\": \"rule:admin\","},{"line_number":89,"context_line":"    \"secretstore:get\": \"rule:admin\""},{"line_number":90,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"7a8ec9b2_d3ff73a8","line":87,"in_reply_to":"7a8ec9b2_f3262fb9","updated":"2016-09-14 18:17:45.000000000","message":"Cool, and thanks for reminding me that the global default is set via config file rather than via an API call. If this was set via API, we\u0027d want to use the service_admin.","commit_id":"6535e559cdf6f388a3c8c6292ccc41aad93842dc"}]}
