)]}'
{"barbican/api/app.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a3b68b43e14a352e46ce2b1bf5c5a0c22057c378","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if newrelic_loaded:"},{"line_number":58,"context_line":"        request_hooks.insert(0, hooks.NewRelicHook())"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resources.initialize_secret_stores_data()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Create WSGI app"},{"line_number":63,"context_line":"    wsgi_app \u003d pecan.Pecan("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_6bbbb50f","line":60,"updated":"2016-09-13 03:20:07.000000000","message":"This seems out of place to me....we have a database init section of code that this probably fits better into, such as at this line: https://github.com/openstack/barbican/blob/master/barbican/model/repositories.py#L203","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"a1cce45e01cf96d7dc253c50b455b065b8672c0e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if newrelic_loaded:"},{"line_number":58,"context_line":"        request_hooks.insert(0, hooks.NewRelicHook())"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resources.initialize_secret_stores_data()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Create WSGI app"},{"line_number":63,"context_line":"    wsgi_app \u003d pecan.Pecan("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_a7131264","line":60,"in_reply_to":"9a89bdaa_6bbbb50f","updated":"2016-09-13 13:45:38.000000000","message":"Let me try moving there. After the comment, now I can see it can be treated similar to database initialization logic (ofcourse post logic).\n\nThere can be a concern raised that db logic is invoking plugin logic which seems bit higher in code execution hierarchy.","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"}],"barbican/common/resources.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a3b68b43e14a352e46ce2b1bf5c5a0c22057c378","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return project"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def initialize_secret_stores_data():"},{"line_number":55,"context_line":"    \"\"\"Initializes secret stores data in database."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    This logic is executed only when wsgi app is built."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ab5e9de6","line":54,"updated":"2016-09-13 03:20:07.000000000","message":"Like my previous comment, I think this should go into repositories.py module.","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"a1cce45e01cf96d7dc253c50b455b065b8672c0e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return project"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def initialize_secret_stores_data():"},{"line_number":55,"context_line":"    \"\"\"Initializes secret stores data in database."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    This logic is executed only when wsgi app is built."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ca749b69","line":54,"in_reply_to":"9a89bdaa_ab5e9de6","updated":"2016-09-13 13:45:38.000000000","message":"Yes. Agree. Will move there.","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"}],"functionaltests/api/v1/behaviors/secretstores_behaviors.py":[{"author":{"_account_id":7789,"name":"John Wood","email":"john.wood@rackspace.com","username":"woodster"},"change_message_id":"a3b68b43e14a352e46ce2b1bf5c5a0c22057c378","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class SecretStoresBehaviors(base_behaviors.BaseBehaviors):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def get_all_secrets(self, extra_headers\u003dNone, use_auth\u003dTrue,"},{"line_number":21,"context_line":"                        user_name\u003dNone):"},{"line_number":22,"context_line":"        \"\"\"Retreives list of secret stores available in barbican\"\"\""},{"line_number":23,"context_line":"        resp \u003d self.client.get(\u0027secret-stores\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_6b0015ac","line":20,"updated":"2016-09-13 03:20:07.000000000","message":"Please change to  \u0027get_all_secret_stores\u0027","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"a1cce45e01cf96d7dc253c50b455b065b8672c0e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class SecretStoresBehaviors(base_behaviors.BaseBehaviors):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def get_all_secrets(self, extra_headers\u003dNone, use_auth\u003dTrue,"},{"line_number":21,"context_line":"                        user_name\u003dNone):"},{"line_number":22,"context_line":"        \"\"\"Retreives list of secret stores available in barbican\"\"\""},{"line_number":23,"context_line":"        resp \u003d self.client.get(\u0027secret-stores\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_6704aa14","line":20,"in_reply_to":"9a89bdaa_6b0015ac","updated":"2016-09-13 13:45:38.000000000","message":"Okay..will change that.","commit_id":"7c33bd840bfb83bb5b7986e902eee77aca87386e"}]}
