)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"614770df5c1beaffba9ea1375a2adeea2375afd9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve devstack configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_f3ee27b3","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":42},"updated":"2016-10-12 10:47:25.000000000","message":"need to update to castellan","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"6385cd940a396d533014c0eda0c32a289e81563a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve devstack configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_5a4c3c42","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":42},"in_reply_to":"fa6399be_1a21e49f","updated":"2016-10-12 14:03:14.000000000","message":"These services already use Castellan to talk to the key management service, regardless of what the config file says. The config option merely points Castellan to Barbican.","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"e36a9753f37acd005356baf24f02d16deed80ef4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve devstack configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_4dc5648c","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":42},"in_reply_to":"fa6399be_5a4c3c42","updated":"2016-10-12 14:19:04.000000000","message":"Hmm... Yeah, I got it. Thanks. :)","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"a306b237b06de5066831ab0817a393000c929930","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve devstack configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_1a21e49f","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":42},"in_reply_to":"fa6399be_c4e074cf","updated":"2016-10-12 13:59:13.000000000","message":"Shouldn\u0027t this be changed to \"use Castellan for key management ...\"?","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"bb88449c56473d0c04e74499936265e6963990d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve devstack configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_c4e074cf","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":42},"in_reply_to":"fa6399be_f3ee27b3","updated":"2016-10-12 13:08:42.000000000","message":"Can you clarify what you mean here?","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"ed5d545f5f0dbd62490f514f4a60c6e3e0acd3b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc3b017596a3d401fd62adb07f2d12913c2cef9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_73ffb734","line":11,"updated":"2016-10-26 13:48:19.000000000","message":"Since Glance is also included, it should be added to the commit message.","commit_id":"8148642702d9bbe3af594315528b89112acc3fe1"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"2fa6d96930cf3aff4e6cde1b4883a778d1b81792","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a function to lib/barbican which"},{"line_number":10,"context_line":"configures Nova and Cinder to use Barbican for"},{"line_number":11,"context_line":"key management when the Barbican plugin gets"},{"line_number":12,"context_line":"installed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc3b017596a3d401fd62adb07f2d12913c2cef9a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_f490fc97","line":11,"in_reply_to":"ba5da102_73ffb734","updated":"2016-10-27 10:07:21.000000000","message":"Done","commit_id":"8148642702d9bbe3af594315528b89112acc3fe1"}],"devstack/lib/barbican":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e21e1c11c198cae4b918b83f533fb4cff0b78337","unresolved":false,"context_lines":[{"line_number":184,"context_line":"# Set the correct config options in Nova and Cinder"},{"line_number":185,"context_line":"function configure_core_services {"},{"line_number":186,"context_line":"    if -z $NOVA_CONF; then"},{"line_number":187,"context_line":"        iniset $NOVA_CONF key_manager api_class \u0027nova.key_manager.barbican.BarbicanKeyManager\u0027"},{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_beb64388","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":94},"updated":"2016-09-22 20:50:18.000000000","message":"This should work, but better to use\n\n    iniset $NOVA_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027","commit_id":"89a8467e1bb31f73a42a7ecfb0c008779286547d"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1fb36cf9e9957f0d1f156c7cc44e153d419d2c22","unresolved":false,"context_lines":[{"line_number":184,"context_line":"# Set the correct config options in Nova and Cinder"},{"line_number":185,"context_line":"function configure_core_services {"},{"line_number":186,"context_line":"    if -z $NOVA_CONF; then"},{"line_number":187,"context_line":"        iniset $NOVA_CONF key_manager api_class \u0027nova.key_manager.barbican.BarbicanKeyManager\u0027"},{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_dbbf785e","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":94},"in_reply_to":"5a8bc5a2_beb64388","updated":"2016-09-23 13:58:28.000000000","message":"Done","commit_id":"89a8467e1bb31f73a42a7ecfb0c008779286547d"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e21e1c11c198cae4b918b83f533fb4cff0b78337","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027cinder.key_mgr.barbican.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_3e823395","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":90},"updated":"2016-09-22 20:50:18.000000000","message":"iniset $CINDER_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027","commit_id":"89a8467e1bb31f73a42a7ecfb0c008779286547d"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1fb36cf9e9957f0d1f156c7cc44e153d419d2c22","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027cinder.key_mgr.barbican.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_1bbac06e","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":90},"in_reply_to":"5a8bc5a2_3e823395","updated":"2016-09-23 13:58:28.000000000","message":"Done","commit_id":"89a8467e1bb31f73a42a7ecfb0c008779286547d"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"d7ee8df1d0d84452f00cd0653a092ac7e86c7152","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# start_barbican - Start running processes, including screen"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a8bc5a2_76ae7b86","line":192,"updated":"2016-09-23 14:09:41.000000000","message":"Though not technically required (since Glance just follows Castellan\u0027s default) I think it would be best to include a line for glance as well:\n\niniset $GLANCE_API_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027","commit_id":"9e674d14f34e35d0df20bb65c96a5c2b04a04eee"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"c3799723a273f9a44f9bc0e7eba3597693e6d600","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if -z $CINDER_CONF; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# start_barbican - Start running processes, including screen"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a8bc5a2_472c59ab","line":192,"in_reply_to":"5a8bc5a2_76ae7b86","updated":"2016-09-23 19:23:54.000000000","message":"Done","commit_id":"9e674d14f34e35d0df20bb65c96a5c2b04a04eee"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"614770df5c1beaffba9ea1375a2adeea2375afd9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if is_service_enabled c-vol; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_1338fb9f","line":191,"range":{"start_line":191,"start_character":28,"end_line":191,"end_character":35},"updated":"2016-10-12 10:47:25.000000000","message":"The group name in cinder.conf is \u0027key_manager\u0027","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"a91f04e8e5459e2514a0865d9286749788917f21","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if is_service_enabled c-vol; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_6d47881d","line":191,"range":{"start_line":191,"start_character":28,"end_line":191,"end_character":35},"in_reply_to":"fa6399be_1338fb9f","updated":"2016-10-12 14:19:48.000000000","message":"Can you please check the group name in cinder.conf?","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"6968e85604e1f3a7508b9e94d53a9df98ae018c7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    fi"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    if is_service_enabled c-vol; then"},{"line_number":191,"context_line":"        iniset $CINDER_CONF key_mgr api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_f876c3d5","line":191,"range":{"start_line":191,"start_character":28,"end_line":191,"end_character":35},"in_reply_to":"fa6399be_6d47881d","updated":"2016-10-13 14:11:26.000000000","message":"The key_mgr option still works, but is being deprecated in favor of the key_manager option group. So I\u0027m switching to the key_manager option group.","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"614770df5c1beaffba9ea1375a2adeea2375afd9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"},{"line_number":195,"context_line":"        iniset $GLANCE_API_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_d3dcc314","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":117},"updated":"2016-10-12 10:47:25.000000000","message":"I haven\u0027t seen any \u0027key_manager\u0027 configuration in glance. Can you give a reference of that?","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"7a708821f7fed32c277b7c4c65187864582a1700","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"},{"line_number":195,"context_line":"        iniset $GLANCE_API_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_eab0e1df","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":117},"in_reply_to":"fa6399be_d3dcc314","updated":"2016-10-12 13:25:33.000000000","message":"https://review.openstack.org/#/c/376302/3/doc/source/signature.rst","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"a306b237b06de5066831ab0817a393000c929930","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if is_service_enabled g-api; then"},{"line_number":195,"context_line":"        iniset $GLANCE_API_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"},{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":"}"},{"line_number":198,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa6399be_97306d03","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":117},"in_reply_to":"fa6399be_eab0e1df","updated":"2016-10-12 13:59:13.000000000","message":"Thanks. I saw it\u0027s under review. Nice work!","commit_id":"5c47b20e56844f41f0617cc6e59a6b3583de6d13"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"b72c406acb11879b898d9dbcb5588106cc205474","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    setup_develop $BARBICANCLIENT_DIR"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"# Set the correct config options in Nova and Cinder"},{"line_number":185,"context_line":"function configure_core_services {"},{"line_number":186,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":187,"context_line":"        iniset $NOVA_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba5da102_51260f69","line":184,"range":{"start_line":184,"start_character":36,"end_line":184,"end_character":51},"updated":"2016-10-27 15:09:02.000000000","message":"Better add glance here as well.","commit_id":"55dae1038e8b4c7a39c2213d1b7e4a6e5eda13c3"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"9f354fc177eaa8d6e3e125b4b9d6e4ed87e9cd30","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    setup_develop $BARBICANCLIENT_DIR"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"# Set the correct config options in Nova and Cinder"},{"line_number":185,"context_line":"function configure_core_services {"},{"line_number":186,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":187,"context_line":"        iniset $NOVA_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba5da102_0687edb5","line":184,"range":{"start_line":184,"start_character":36,"end_line":184,"end_character":51},"in_reply_to":"ba5da102_51260f69","updated":"2016-10-28 10:05:35.000000000","message":"Done","commit_id":"55dae1038e8b4c7a39c2213d1b7e4a6e5eda13c3"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"b72c406acb11879b898d9dbcb5588106cc205474","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # Start the retry scheduler server up."},{"line_number":210,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # Configure cinder and nova to use Barbican"},{"line_number":213,"context_line":"    configure_core_services"},{"line_number":214,"context_line":"}"},{"line_number":215,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba5da102_d11a1f17","line":212,"range":{"start_line":212,"start_character":16,"end_line":212,"end_character":31},"updated":"2016-10-27 15:09:02.000000000","message":"ditto","commit_id":"55dae1038e8b4c7a39c2213d1b7e4a6e5eda13c3"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"9f354fc177eaa8d6e3e125b4b9d6e4ed87e9cd30","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # Start the retry scheduler server up."},{"line_number":210,"context_line":"    run_process barbican-retry \"$BARBICAN_BIN_DIR/barbican-retry --config-file\u003d$BARBICAN_CONF_DIR/barbican-api.conf\""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # Configure cinder and nova to use Barbican"},{"line_number":213,"context_line":"    configure_core_services"},{"line_number":214,"context_line":"}"},{"line_number":215,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba5da102_2694f1e0","line":212,"range":{"start_line":212,"start_character":16,"end_line":212,"end_character":31},"in_reply_to":"ba5da102_d11a1f17","updated":"2016-10-28 10:05:35.000000000","message":"Done","commit_id":"55dae1038e8b4c7a39c2213d1b7e4a6e5eda13c3"}],"devstack/plugin.sh":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"a67c18dd74332d2c475261b23c083a9fbd8b5480","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    fi"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Set the correct config options in Nova, Cinder and Glance"},{"line_number":59,"context_line":"function configure_core_services {"},{"line_number":60,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":61,"context_line":"        iniset $NOVA_CONF key_manager api_class \u0027castellan.key_manager.barbican_key_manager.BarbicanKeyManager\u0027"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba5da102_2c14244b","line":58,"updated":"2016-11-03 16:38:35.000000000","message":"This function should be in https://github.com/openstack/barbican/blob/baf5edfbf9eff60ede03fd167e124960c126e525/devstack/lib/barbican","commit_id":"723962569ff51216422373210b9fc44dfc54ed14"}]}
