)]}'
{"barbican/plugin/kmip_secret_store.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"672594585448678978ba525727350e3811835fb1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               help\u003du._(\u0027Address of the KMIP server\u0027)"},{"line_number":58,"context_line":"               ),"},{"line_number":59,"context_line":"    cfg.IntOpt(\u0027port\u0027,"},{"line_number":60,"context_line":"               default\u003d5696,"},{"line_number":61,"context_line":"               help\u003du._(\u0027Port for the KMIP server\u0027),"},{"line_number":62,"context_line":"               ),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027ssl_version\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_906f02fb","line":60,"range":{"start_line":60,"start_character":27,"end_line":60,"end_character":28},"updated":"2017-01-06 16:02:52.000000000","message":"This is ok but ultimately shouldn\u0027t matter given the PyKMIP client parses the port as an int.","commit_id":"cfa3bb5144bf17ddcbe6f0d4e5a6e21d2f24b536"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"e9876d41879a819107a7366e06a5ed6ff9df9866","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003du._(\u0027Port for the KMIP server\u0027),"},{"line_number":62,"context_line":"               ),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027ssl_version\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027PROTOCOL_TLSv1\u0027,"},{"line_number":65,"context_line":"               help\u003du._(\u0027SSL version, maps to the module ssl\\\u0027s constants\u0027),"},{"line_number":66,"context_line":"               ),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027ca_certs\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_60c2ac86","line":64,"updated":"2017-01-08 20:17:05.000000000","message":"If we do decide to change the default version, you\u0027ll need to change it here in addition to the config file.","commit_id":"9b5768da745ee98c20c51e9c574f57bd0b21d262"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"7fe69512114f18e60837a1cfd2d1d9a52a87a9e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               help\u003du._(\u0027Port for the KMIP server\u0027),"},{"line_number":62,"context_line":"               ),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027ssl_version\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027PROTOCOL_TLSv1\u0027,"},{"line_number":65,"context_line":"               help\u003du._(\u0027SSL version, maps to the module ssl\\\u0027s constants\u0027),"},{"line_number":66,"context_line":"               ),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027ca_certs\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_4df7a0d2","line":64,"in_reply_to":"ba5201f7_60c2ac86","updated":"2017-01-09 02:01:17.000000000","message":"Yes! Sorry, I forgot to update this. I will do it after we decide to change the default version.","commit_id":"9b5768da745ee98c20c51e9c574f57bd0b21d262"}],"etc/barbican/barbican.conf":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"672594585448678978ba525727350e3811835fb1","unresolved":false,"context_lines":[{"line_number":316,"context_line":"keyfile \u003d \u0027/path/to/certs/cert.key\u0027"},{"line_number":317,"context_line":"certfile \u003d \u0027/path/to/certs/cert.crt\u0027"},{"line_number":318,"context_line":"ca_certs \u003d \u0027/path/to/certs/LocalCA.crt\u0027"},{"line_number":319,"context_line":"ssl_version \u003d \u0027PROTOCOL_TLSv1\u0027"},{"line_number":320,"context_line":"pkcs1_only \u003d False"},{"line_number":321,"context_line":"plugin_name \u003d \u0027KMIP HSM\u0027"},{"line_number":322,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"ba5201f7_d087cab2","line":319,"range":{"start_line":319,"start_character":15,"end_line":319,"end_character":29},"updated":"2017-01-06 16:02:52.000000000","message":"PROTOCOL_TLSv1 is not considered secure nowadays and shouldn\u0027t be used as the default (ideally you\u0027d want TLSv1.2, but that\u0027s not always supported). Instead consider PROTOCOL_SSLv23 which is the compatibility setting that supports all protocols in Python ssl (including TLSv1 and TLSv1.2 if supported). If we were clamping to the newest Python2.7 (.13) or Python3.4+ we could be even stricter here but backwards compatibility bites us.","commit_id":"cfa3bb5144bf17ddcbe6f0d4e5a6e21d2f24b536"}]}
