)]}'
{"barbican/tests/api/controllers/test_consumers.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"d19483023a817d1b9ae21c7777a4a34881224543","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertEqual(200, consumer_resp.status_int)"},{"line_number":54,"context_line":"        self.assertEqual(consumer, [self.consumer_a])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_can_get_consumers(self):"},{"line_number":57,"context_line":"        resp, container_uuid \u003d create_container("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_dccd7286","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":51},"updated":"2017-01-28 10:19:56.000000000","message":"The order should be changed to (expected, observed).","commit_id":"2c404aac40bee4a35a7d675ed264b08958b8b243"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"acd1b36d52cf52273e2dbb6202c64f7cc539a3c7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertEqual(200, consumer_resp.status_int)"},{"line_number":54,"context_line":"        self.assertEqual(consumer, [self.consumer_a])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_can_get_consumers(self):"},{"line_number":57,"context_line":"        resp, container_uuid \u003d create_container("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_ede6fa13","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":51},"in_reply_to":"3a461143_dccd7286","updated":"2017-01-28 20:04:54.000000000","message":"Done","commit_id":"2c404aac40bee4a35a7d675ed264b08958b8b243"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"c51d1492c10535c9657f1fb6aeec52062bbc95bd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(200, consumer_get_resp.status_int)"},{"line_number":137,"context_line":"        self.assertEqual([], consumer_get_resp.json[\"consumers\"])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_container_not_found(self):"},{"line_number":140,"context_line":"        consumer_resp, consumers \u003d create_consumer("},{"line_number":141,"context_line":"            self.app,"},{"line_number":142,"context_line":"            container_id\u003d\"bad_container_id\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_89df1c0c","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":36},"updated":"2017-01-30 06:30:34.000000000","message":"Shouldn\u0027t the name be `test_create_container_not_found`?\nOr you want to add testcases for both \"test_get_container_not_found\" and \"test_create_container_not_found\"?","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b95d7bed5b2527046233fc9567a9efc2cae16d68","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self.assertEqual(200, consumer_get_resp.status_int)"},{"line_number":137,"context_line":"        self.assertEqual([], consumer_get_resp.json[\"consumers\"])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_container_not_found(self):"},{"line_number":140,"context_line":"        consumer_resp, consumers \u003d create_consumer("},{"line_number":141,"context_line":"            self.app,"},{"line_number":142,"context_line":"            container_id\u003d\"bad_container_id\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_553930f1","line":139,"range":{"start_line":139,"start_character":8,"end_line":139,"end_character":36},"in_reply_to":"3a461143_89df1c0c","updated":"2017-01-30 17:59:28.000000000","message":"changed to `test_fails_create_container_not_found`. Added the test for the get as well.","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"c51d1492c10535c9657f1fb6aeec52062bbc95bd","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":"        self.assertEqual(404, consumer_resp.status_int)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_delete_consumer_not_found(self):"},{"line_number":150,"context_line":"        request \u003d {"},{"line_number":151,"context_line":"            \u0027name\u0027: self.consumer_a[\"name\"],"},{"line_number":152,"context_line":"            \u0027URL\u0027: self.consumer_a[\"URL\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_49f1b494","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":38},"updated":"2017-01-30 06:30:34.000000000","message":"Shouldn\u0027t the name be `test_delete_container_not_found`?","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b95d7bed5b2527046233fc9567a9efc2cae16d68","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":"        self.assertEqual(404, consumer_resp.status_int)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_delete_consumer_not_found(self):"},{"line_number":150,"context_line":"        request \u003d {"},{"line_number":151,"context_line":"            \u0027name\u0027: self.consumer_a[\"name\"],"},{"line_number":152,"context_line":"            \u0027URL\u0027: self.consumer_a[\"URL\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_983cafc9","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":38},"in_reply_to":"3a461143_49f1b494","updated":"2017-01-30 17:59:28.000000000","message":"Done, and added one for consumer not found.","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"85ee3e3fc9e9b4f5ef8c90e6960f35bebf891264","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assertEqual(404, consumer_del_resp.status_int)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# ----------------------- Helper Functions ---------------------------"},{"line_number":167,"context_line":"def create_container(app, name\u003dNone, container_type\u003dNone, expect_errors\u003dFalse,"},{"line_number":168,"context_line":"                     headers\u003dNone):"},{"line_number":169,"context_line":"    request \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_32d75a4c","line":166,"updated":"2017-01-30 16:33:55.000000000","message":"Helper functions should be named with an underscore in front (ex., _create_container instead of create_container)","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"0b802bff292c973361c2f2462da569af0753a753","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assertEqual(404, consumer_del_resp.status_int)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# ----------------------- Helper Functions ---------------------------"},{"line_number":167,"context_line":"def create_container(app, name\u003dNone, container_type\u003dNone, expect_errors\u003dFalse,"},{"line_number":168,"context_line":"                     headers\u003dNone):"},{"line_number":169,"context_line":"    request \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_e7ec2ef5","line":166,"in_reply_to":"3a461143_2638fcee","updated":"2017-01-30 19:41:02.000000000","message":"I\u0027m following the structure of the other tests. I will think about a future patch moving all helper methods to a parent class","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b95d7bed5b2527046233fc9567a9efc2cae16d68","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assertEqual(404, consumer_del_resp.status_int)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# ----------------------- Helper Functions ---------------------------"},{"line_number":167,"context_line":"def create_container(app, name\u003dNone, container_type\u003dNone, expect_errors\u003dFalse,"},{"line_number":168,"context_line":"                     headers\u003dNone):"},{"line_number":169,"context_line":"    request \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_7529cc36","line":166,"in_reply_to":"3a461143_32d75a4c","updated":"2017-01-30 17:59:28.000000000","message":"They are helper methods, but they must be public since they need to be used within all the classes. There is only one now, but in the future there may be multiple.","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"},{"author":{"_account_id":23185,"name":"Samantha Blanco","email":"samantha.blanco@att.com","username":"sblanco"},"change_message_id":"28048952dbc8c0f4d4f1ab129b8088e7ed5e42a1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        self.assertEqual(404, consumer_del_resp.status_int)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# ----------------------- Helper Functions ---------------------------"},{"line_number":167,"context_line":"def create_container(app, name\u003dNone, container_type\u003dNone, expect_errors\u003dFalse,"},{"line_number":168,"context_line":"                     headers\u003dNone):"},{"line_number":169,"context_line":"    request \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_2638fcee","line":166,"in_reply_to":"3a461143_7529cc36","updated":"2017-01-30 18:29:50.000000000","message":"I see. Then wouldn\u0027t it be better to move them somewhere they can be inherited for other tests?","commit_id":"53595ef7eab2d6790cddc69d25b201e38efab7c7"}]}
