)]}'
{"barbican/plugin/ipavault.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"aa05bcb772ba6393999877fb9bbe60713d8e1b00","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _bootstrap(self):"},{"line_number":87,"context_line":"        if not self._api.isdone(\u0027bootstrap\u0027):"},{"line_number":88,"context_line":"            # set client keytab env var for authentication"},{"line_number":89,"context_line":"            if self._keytab is not None:"},{"line_number":90,"context_line":"                os.environ[\u0027KRB5_CLIENT_KTNAME\u0027] \u003d self._keytab"},{"line_number":91,"context_line":"            if self._ccache is not None:"},{"line_number":92,"context_line":"                os.environ[\u0027KRB5CCNAME\u0027] \u003d self._ccache"},{"line_number":93,"context_line":"            if self._krb5config is not None:"},{"line_number":94,"context_line":"                os.environ[\u0027KRB5_CONFIG\u0027] \u003d self._krb5config"},{"line_number":95,"context_line":"            # TODO(alee) - band-aid for \"A PKCS #11 module returned"},{"line_number":96,"context_line":"            # CKR_DEVICE_ERROR\""},{"line_number":97,"context_line":"            # https://github.com/avocado-framework/avocado/issues/1112#issuecomment-206999400"},{"line_number":98,"context_line":"            os.environ[\u0027NSS_STRICT_NOFORK\u0027] \u003d \u0027DISABLED\u0027"},{"line_number":99,"context_line":"            self._api.bootstrap(**self._ipa_config)"},{"line_number":100,"context_line":"            self._api.finalize()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_b085c05a","line":98,"range":{"start_line":89,"start_character":12,"end_line":98,"end_character":56},"updated":"2017-02-16 09:10:34.000000000","message":"This adds params into env, does it matter if we deploy barbican with HA?","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"7f01c553275135f072f635986c00dd5184e1583c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _bootstrap(self):"},{"line_number":87,"context_line":"        if not self._api.isdone(\u0027bootstrap\u0027):"},{"line_number":88,"context_line":"            # set client keytab env var for authentication"},{"line_number":89,"context_line":"            if self._keytab is not None:"},{"line_number":90,"context_line":"                os.environ[\u0027KRB5_CLIENT_KTNAME\u0027] \u003d self._keytab"},{"line_number":91,"context_line":"            if self._ccache is not None:"},{"line_number":92,"context_line":"                os.environ[\u0027KRB5CCNAME\u0027] \u003d self._ccache"},{"line_number":93,"context_line":"            if self._krb5config is not None:"},{"line_number":94,"context_line":"                os.environ[\u0027KRB5_CONFIG\u0027] \u003d self._krb5config"},{"line_number":95,"context_line":"            # TODO(alee) - band-aid for \"A PKCS #11 module returned"},{"line_number":96,"context_line":"            # CKR_DEVICE_ERROR\""},{"line_number":97,"context_line":"            # https://github.com/avocado-framework/avocado/issues/1112#issuecomment-206999400"},{"line_number":98,"context_line":"            os.environ[\u0027NSS_STRICT_NOFORK\u0027] \u003d \u0027DISABLED\u0027"},{"line_number":99,"context_line":"            self._api.bootstrap(**self._ipa_config)"},{"line_number":100,"context_line":"            self._api.finalize()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_f001f86b","line":98,"range":{"start_line":89,"start_character":12,"end_line":98,"end_character":56},"in_reply_to":"fa31d9ce_5019e421","updated":"2017-02-16 09:20:44.000000000","message":"OK, thanks for the explaination.","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3a4a8c83e8c37ac58e91bb2c15ba81eddfa8eed2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _bootstrap(self):"},{"line_number":87,"context_line":"        if not self._api.isdone(\u0027bootstrap\u0027):"},{"line_number":88,"context_line":"            # set client keytab env var for authentication"},{"line_number":89,"context_line":"            if self._keytab is not None:"},{"line_number":90,"context_line":"                os.environ[\u0027KRB5_CLIENT_KTNAME\u0027] \u003d self._keytab"},{"line_number":91,"context_line":"            if self._ccache is not None:"},{"line_number":92,"context_line":"                os.environ[\u0027KRB5CCNAME\u0027] \u003d self._ccache"},{"line_number":93,"context_line":"            if self._krb5config is not None:"},{"line_number":94,"context_line":"                os.environ[\u0027KRB5_CONFIG\u0027] \u003d self._krb5config"},{"line_number":95,"context_line":"            # TODO(alee) - band-aid for \"A PKCS #11 module returned"},{"line_number":96,"context_line":"            # CKR_DEVICE_ERROR\""},{"line_number":97,"context_line":"            # https://github.com/avocado-framework/avocado/issues/1112#issuecomment-206999400"},{"line_number":98,"context_line":"            os.environ[\u0027NSS_STRICT_NOFORK\u0027] \u003d \u0027DISABLED\u0027"},{"line_number":99,"context_line":"            self._api.bootstrap(**self._ipa_config)"},{"line_number":100,"context_line":"            self._api.finalize()"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_5019e421","line":98,"range":{"start_line":89,"start_character":12,"end_line":98,"end_character":56},"in_reply_to":"fa31d9ce_b085c05a","updated":"2017-02-16 09:15:01.000000000","message":"it doesn\u0027t; these parameters are mostly used to communicate to FreeIPA. So, for instance, the KRB5_CLIENT_KTNAME will be a file that\u0027s unique to each node that\u0027s running barbican-api.","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"26a546835e5dca5a308c6f4068cdfb224c9edf5d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                result \u003d ipa.Command.vault_retrieve(key_id,"},{"line_number":181,"context_line":"                                                    service\u003dservice)"},{"line_number":182,"context_line":"                secret \u003d result[u\u0027result\u0027][u\u0027data\u0027]"},{"line_number":183,"context_line":"            except NotFound as e:"},{"line_number":184,"context_line":"                raise sstore.SecretGeneralException(e)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_ee1ea80a","line":182,"updated":"2017-02-08 18:48:25.000000000","message":"is this the only format we are gonna get for the results? Should we handle KeyError?","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"03685d85b99bcc8dfc0e6bbc4b2eef6bdbf81633","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        \"\"\"Delete a secret from the KRA"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        There is currently no way to delete a secret in Dogtag."},{"line_number":197,"context_line":"        We will be implementing such a method shortly."},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        pass    # pragma: no cover"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_7ec86e75","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":10},"updated":"2017-02-28 17:41:57.000000000","message":"For sake of documentation, can you please elaborate in tthis docstring if \"we\" is RedHat or the Barbican team?","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"}],"barbican/tests/plugin/test_ipavault.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"03685d85b99bcc8dfc0e6bbc4b2eef6bdbf81633","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import barbican.plugin.interface.secret_store as sstore"},{"line_number":22,"context_line":"from barbican.tests import utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    from barbican.plugin import ipavault as ipav"},{"line_number":26,"context_line":"    from ipalib.errors import NotFound"},{"line_number":27,"context_line":"    imports_ok \u003d True"},{"line_number":28,"context_line":"except ImportError:"},{"line_number":29,"context_line":"    # ipa imports probably not available"},{"line_number":30,"context_line":"    imports_ok \u003d False"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@testtools.skipIf(not imports_ok, \"IPA vault imports not available\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_1e14d2f3","line":30,"range":{"start_line":24,"start_character":0,"end_line":30,"end_character":22},"updated":"2017-02-28 17:41:57.000000000","message":"I noticed this on the oslo-config-generator patch -- Do these tests (and the dogtag tests) ever get run anywhere?  They aren\u0027t being run in the python27 gates and pretty sure the dogtag gate only runs the functional tests.","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"}],"bindep.txt":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"03685d85b99bcc8dfc0e6bbc4b2eef6bdbf81633","unresolved":false,"context_lines":[{"line_number":10,"context_line":"389-ds-base [platform:rpm]"},{"line_number":11,"context_line":"pki-ca [platform:rpm]"},{"line_number":12,"context_line":"pki-kra [platform:rpm]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Required for the IPA-Vault plugin"},{"line_number":15,"context_line":"python2-ipalib [platform:rpm]"},{"line_number":16,"context_line":"python3-ipalib [platform:rpm]"},{"line_number":17,"context_line":"python-ipalib [platform:ubuntu]"}],"source_content_type":"text/plain","patch_set":7,"id":"ba2be162_1e469223","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":31},"updated":"2017-02-28 17:41:57.000000000","message":"You don\u0027t want these to use the pypi packages and put these into global requirements? This way seems like it would be harder to manage the required version number, if needed.","commit_id":"7ac4b01a2d1cafd2e4bbab893570f78f784bc044"}]}
