)]}'
{"functionaltests/api/v1/behaviors/secret_behaviors.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"0298af1cd738b3e4deb6ff57caf91fb024235668","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param alg: Optional algorithm for filtering secrets"},{"line_number":149,"context_line":"        :param mode: Optional mode for filtering secrets"},{"line_number":150,"context_line":"        :param bits: Optional bit length for filtering secrets"},{"line_number":151,"context_line":"        :param secret_type: Optional secret type for filtering secrets"},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        params \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":154,"context_line":"        if name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_8d1032aa","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":26},"updated":"2017-03-21 02:06:23.000000000","message":"The new params should be added here.\n\nAnd `name` filter is also missing, can you add it ?","commit_id":"4de84c3347d61b1129b5700b62eb85192f29b223"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"d1f732c5e1c451d409312974a46b534bfc7a8f7b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param alg: Optional algorithm for filtering secrets"},{"line_number":149,"context_line":"        :param mode: Optional mode for filtering secrets"},{"line_number":150,"context_line":"        :param bits: Optional bit length for filtering secrets"},{"line_number":151,"context_line":"        :param secret_type: Optional secret type for filtering secrets"},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        params \u003d {\u0027limit\u0027: limit, \u0027offset\u0027: offset}"},{"line_number":154,"context_line":"        if name:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_12950d87","line":151,"range":{"start_line":151,"start_character":8,"end_line":151,"end_character":26},"in_reply_to":"1a1ced50_8d1032aa","updated":"2017-03-29 20:26:00.000000000","message":"Good points. Seconded!","commit_id":"4de84c3347d61b1129b5700b62eb85192f29b223"}],"functionaltests/api/v1/functional/test_secrets.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"44f4dd8e8c0eeefc186a4895e6f1b007be591299","unresolved":false,"context_lines":[{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"        two_phase_model \u003d secret_models.SecretModel(expiration\u003dexpiration_1)"},{"line_number":1170,"context_line":"        resp, secret_ref_1 \u003d self.behaviors.create_secret(two_phase_model)"},{"line_number":1171,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":1172,"context_line":"        payload \u003d \"gF6+lLoF3ohA9aPRpt+6bQ\u003d\u003d\""},{"line_number":1173,"context_line":"        payload_content_type \u003d \"application/octet-stream\""},{"line_number":1174,"context_line":"        payload_content_encoding \u003d \"base64\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_194d6a6c","line":1171,"updated":"2017-03-09 01:03:07.000000000","message":"NIT: It would be useful to leave a comment about what we\u0027re asserting here","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d34e97aa465e6b45c59c6c47c005a352b04a575b","unresolved":false,"context_lines":[{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"        two_phase_model \u003d secret_models.SecretModel(expiration\u003dexpiration_1)"},{"line_number":1170,"context_line":"        resp, secret_ref_1 \u003d self.behaviors.create_secret(two_phase_model)"},{"line_number":1171,"context_line":"        self.assertEqual(201, resp.status_code)"},{"line_number":1172,"context_line":"        payload \u003d \"gF6+lLoF3ohA9aPRpt+6bQ\u003d\u003d\""},{"line_number":1173,"context_line":"        payload_content_type \u003d \"application/octet-stream\""},{"line_number":1174,"context_line":"        payload_content_encoding \u003d \"base64\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_60ded26e","line":1171,"in_reply_to":"9a30ddce_194d6a6c","updated":"2017-03-15 19:51:20.000000000","message":"Done","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"44f4dd8e8c0eeefc186a4895e6f1b007be591299","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"            secret_ref_1, payload\u003dpayload,"},{"line_number":1177,"context_line":"            payload_content_type\u003dpayload_content_type,"},{"line_number":1178,"context_line":"            payload_content_encoding\u003dpayload_content_encoding)"},{"line_number":1179,"context_line":"        self.assertEqual(204, update_resp.status_code)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"        time.sleep(1)"},{"line_number":1182,"context_line":"        model \u003d secret_models.SecretModel(expiration\u003dexpiration_2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_79782690","line":1179,"updated":"2017-03-09 01:03:07.000000000","message":"NIT: It would be useful to leave a comment about what we\u0027re asserting here","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d34e97aa465e6b45c59c6c47c005a352b04a575b","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"            secret_ref_1, payload\u003dpayload,"},{"line_number":1177,"context_line":"            payload_content_type\u003dpayload_content_type,"},{"line_number":1178,"context_line":"            payload_content_encoding\u003dpayload_content_encoding)"},{"line_number":1179,"context_line":"        self.assertEqual(204, update_resp.status_code)"},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"        time.sleep(1)"},{"line_number":1182,"context_line":"        model \u003d secret_models.SecretModel(expiration\u003dexpiration_2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_a0e8ca11","line":1179,"in_reply_to":"9a30ddce_79782690","updated":"2017-03-15 19:51:20.000000000","message":"Done","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"44f4dd8e8c0eeefc186a4895e6f1b007be591299","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"        self.assertEqual(1, len(secrets_list))"},{"line_number":1199,"context_line":"        self.assertEqual(secret_ref_1, secrets_list[0].secret_ref)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"        # Search fo secrets with time \u003c secret 2, i.e. secret 1"},{"line_number":1202,"context_line":"        query_dict \u003d {date_type: \u0027lt:\u0027 + time_to_search_2}"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        resp, secrets_list, next_ref, prev_ref \u003d self.behaviors.get_secrets("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_7951060e","line":1201,"updated":"2017-03-09 01:03:07.000000000","message":"typo? (and in the copy/pasted lines)","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d34e97aa465e6b45c59c6c47c005a352b04a575b","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"        self.assertEqual(1, len(secrets_list))"},{"line_number":1199,"context_line":"        self.assertEqual(secret_ref_1, secrets_list[0].secret_ref)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"        # Search fo secrets with time \u003c secret 2, i.e. secret 1"},{"line_number":1202,"context_line":"        query_dict \u003d {date_type: \u0027lt:\u0027 + time_to_search_2}"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        resp, secrets_list, next_ref, prev_ref \u003d self.behaviors.get_secrets("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_20f4daf0","line":1201,"in_reply_to":"9a30ddce_7951060e","updated":"2017-03-15 19:51:20.000000000","message":"Jackie, that\u0027s just how I talk ;)\nDone","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"44f4dd8e8c0eeefc186a4895e6f1b007be591299","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"            **query_dict)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1218,"context_line":"        self.assertEqual(2, len(secrets_list))"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        # Search fo secrets with time \u003e secret 1, i.e. secret 2"},{"line_number":1221,"context_line":"        query_dict \u003d {date_type: \u0027gt:\u0027 + time_to_search_1}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_79866666","line":1218,"updated":"2017-03-09 01:03:07.000000000","message":"Would it be worth it to also assert that the secrets in secrets_list are indeed secret_ref_1 and secret_ref_2? It would be REALLY weird if that wasn\u0027t the case, but it may not hurt to add the extra assertions","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"d34e97aa465e6b45c59c6c47c005a352b04a575b","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"            **query_dict)"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1218,"context_line":"        self.assertEqual(2, len(secrets_list))"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":"        # Search fo secrets with time \u003e secret 1, i.e. secret 2"},{"line_number":1221,"context_line":"        query_dict \u003d {date_type: \u0027gt:\u0027 + time_to_search_1}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_00627ead","line":1218,"in_reply_to":"9a30ddce_79866666","updated":"2017-03-15 19:51:20.000000000","message":"Couldn\u0027t hurt","commit_id":"a44f4158796d0b2bbf0ee2717d35c1129640eb63"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"d7fdbf5b1b6f15300c0155994ed2de9fa69a7f31","unresolved":false,"context_lines":[{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1220,"context_line":"        self.assertEqual(2, len(secrets_list))"},{"line_number":1221,"context_line":"        self.assertEqual(secret_ref_1, secrets_list[0].secret_ref)"},{"line_number":1222,"context_line":"        self.assertEqual(secret_ref_2, secrets_list[1].secret_ref)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        # Search for secrets with time \u003e secret 1, i.e. secret 2"},{"line_number":1225,"context_line":"        query_dict \u003d {date_type: \u0027gt:\u0027 + time_to_search_1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_733b07d2","line":1222,"range":{"start_line":1221,"start_character":0,"end_line":1222,"end_character":66},"updated":"2017-03-15 21:26:48.000000000","message":"Is it guaranteed that secret_ref_1 will come before secret_ref_2?","commit_id":"4de84c3347d61b1129b5700b62eb85192f29b223"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"eefcf8cc1927267499064fee458c73b8d88c78aa","unresolved":false,"context_lines":[{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1220,"context_line":"        self.assertEqual(2, len(secrets_list))"},{"line_number":1221,"context_line":"        self.assertEqual(secret_ref_1, secrets_list[0].secret_ref)"},{"line_number":1222,"context_line":"        self.assertEqual(secret_ref_2, secrets_list[1].secret_ref)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        # Search for secrets with time \u003e secret 1, i.e. secret 2"},{"line_number":1225,"context_line":"        query_dict \u003d {date_type: \u0027gt:\u0027 + time_to_search_1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_93c0837e","line":1222,"range":{"start_line":1221,"start_character":0,"end_line":1222,"end_character":66},"in_reply_to":"3a1ff146_733b07d2","updated":"2017-03-15 21:29:44.000000000","message":"Yup, the secrets are returned in the order of the oldest secret first.","commit_id":"4de84c3347d61b1129b5700b62eb85192f29b223"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"3c6eec07b415b4b9d22039506bd7f436a71fc55d","unresolved":false,"context_lines":[{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":1220,"context_line":"        self.assertEqual(2, len(secrets_list))"},{"line_number":1221,"context_line":"        self.assertEqual(secret_ref_1, secrets_list[0].secret_ref)"},{"line_number":1222,"context_line":"        self.assertEqual(secret_ref_2, secrets_list[1].secret_ref)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        # Search for secrets with time \u003e secret 1, i.e. secret 2"},{"line_number":1225,"context_line":"        query_dict \u003d {date_type: \u0027gt:\u0027 + time_to_search_1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_5371abdf","line":1222,"range":{"start_line":1221,"start_character":0,"end_line":1222,"end_character":66},"in_reply_to":"3a1ff146_93c0837e","updated":"2017-03-15 21:47:52.000000000","message":"Done","commit_id":"4de84c3347d61b1129b5700b62eb85192f29b223"}]}
