)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"c8c564f5660f77d1c18bf04677edf8910f881623","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If ListingSecretsTestCase\u0027s parent class is SecretsTestCase, all"},{"line_number":10,"context_line":"of the tests in SecretsTestCase are also run again, which is not"},{"line_number":11,"context_line":"the intended behavior."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia936577f6ef5485a45db0755ebe9dfd2bdabfdfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_1bee26b4","line":11,"updated":"2017-02-22 22:06:35.000000000","message":"Also, a comment should be added as to why you deleted the other cleanup lines.","commit_id":"deedd408851f369fe2a02cde96d8a4dc2567db7f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"5a0d60316dab7caf9bb8beb502f23dec3409691b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If ListingSecretsTestCase\u0027s parent class is SecretsTestCase, all"},{"line_number":10,"context_line":"of the tests in SecretsTestCase are also run again, which is not"},{"line_number":11,"context_line":"the intended behavior."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia936577f6ef5485a45db0755ebe9dfd2bdabfdfe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_5bf5fe54","line":11,"in_reply_to":"da36d5c6_1bee26b4","updated":"2017-02-22 22:12:40.000000000","message":"Done","commit_id":"deedd408851f369fe2a02cde96d8a4dc2567db7f"}],"functionaltests/api/v1/functional/test_secrets.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"b1df363d5c8afe71f6c985d7ce2d783d5b47b3bf","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _cleanup_all_secrets(self):"},{"line_number":148,"context_line":"        for user_name in self.client.get_all_functional_test_user_names():"},{"line_number":149,"context_line":"            self.behaviors.delete_all_secrets_for_user(user_name\u003duser_name)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @testcase.attr(\u0027negative\u0027)"},{"line_number":152,"context_line":"    def test_secret_create_with_only_content_type_no_payload(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_6328a9e1","side":"PARENT","line":149,"updated":"2017-04-25 17:05:23.000000000","message":"delete_all_secrets_for_user seems to only be used here. Can you remove it from functionaltests/api/v1/behaviors/secret_behaviors.py","commit_id":"6752fa23b5801244c85c9021d1f69efb8d539266"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"aef58593ee2b13a608d5c71bf5329c0a734389cd","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _cleanup_all_secrets(self):"},{"line_number":148,"context_line":"        for user_name in self.client.get_all_functional_test_user_names():"},{"line_number":149,"context_line":"            self.behaviors.delete_all_secrets_for_user(user_name\u003duser_name)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @testcase.attr(\u0027negative\u0027)"},{"line_number":152,"context_line":"    def test_secret_create_with_only_content_type_no_payload(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_c34f7d90","side":"PARENT","line":149,"in_reply_to":"5ff73747_6328a9e1","updated":"2017-04-25 17:09:29.000000000","message":"Done","commit_id":"6752fa23b5801244c85c9021d1f69efb8d539266"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"d197d1f233d94e23693cbb8f32a8140ca9d374f4","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"        },"},{"line_number":1125,"context_line":"    })"},{"line_number":1126,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":1127,"context_line":"    def test_secret_list_with_filter(self, secret_1_dict, secret_2_dict,"},{"line_number":1128,"context_line":"                                     query_dict):"},{"line_number":1129,"context_line":"        secret_1 \u003d secret_models.SecretModel(**secret_1_dict)"},{"line_number":1130,"context_line":"        secret_2 \u003d secret_models.SecretModel(**secret_2_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_d10f44df","line":1127,"range":{"start_line":1127,"start_character":8,"end_line":1127,"end_character":36},"updated":"2017-03-02 02:40:22.000000000","message":"Why not move this testcase to SecretsTestCase ?","commit_id":"b90f2bcaf4d625506eb98a141daed8a8a65eb88b"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"4d9bfb85b610ec136e28166a5351c6a292d3ae18","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"        },"},{"line_number":1125,"context_line":"    })"},{"line_number":1126,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":1127,"context_line":"    def test_secret_list_with_filter(self, secret_1_dict, secret_2_dict,"},{"line_number":1128,"context_line":"                                     query_dict):"},{"line_number":1129,"context_line":"        secret_1 \u003d secret_models.SecretModel(**secret_1_dict)"},{"line_number":1130,"context_line":"        secret_2 \u003d secret_models.SecretModel(**secret_2_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_3a158d3f","line":1127,"range":{"start_line":1127,"start_character":8,"end_line":1127,"end_character":36},"in_reply_to":"ba2be162_93cf5b28","updated":"2017-03-03 08:27:12.000000000","message":"OK, thanks for the explanation !","commit_id":"b90f2bcaf4d625506eb98a141daed8a8a65eb88b"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"2aec9914040dc83efaed4bb5df97f27c3a0b5738","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"        },"},{"line_number":1125,"context_line":"    })"},{"line_number":1126,"context_line":"    @testcase.attr(\u0027positive\u0027)"},{"line_number":1127,"context_line":"    def test_secret_list_with_filter(self, secret_1_dict, secret_2_dict,"},{"line_number":1128,"context_line":"                                     query_dict):"},{"line_number":1129,"context_line":"        secret_1 \u003d secret_models.SecretModel(**secret_1_dict)"},{"line_number":1130,"context_line":"        secret_2 \u003d secret_models.SecretModel(**secret_2_dict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_93cf5b28","line":1127,"range":{"start_line":1127,"start_character":8,"end_line":1127,"end_character":36},"in_reply_to":"ba2be162_d10f44df","updated":"2017-03-02 20:27:00.000000000","message":"Maybe this isn\u0027t as important as before since we aren\u0027t running the tests in parallel in the gate, but I created a ListingSecretsTestCase to exclude it from the tests that are run in parallel:\n\nhttps://github.com/openstack/barbican/blob/master/functionaltests/run_tests_parallel.sh#L26\n\nOtherwise, if this test is run in parallel, there are probably other secrets being created in the other tests and the list command returns extra secrets that aren\u0027t included in this test.","commit_id":"b90f2bcaf4d625506eb98a141daed8a8a65eb88b"}]}