)]}'
{"barbican/plugin/vault_secret_store.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"37325f92119621526bafe59e6089bcbce15d3fc9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        meta_dict \u003d {VaultSecretStore.KEY_ID: key}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        self._store_secret_attributes(meta_dict, secret_dto)"},{"line_number":178,"context_line":"        return meta_dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_78e35ad9","line":175,"updated":"2017-02-24 22:28:38.000000000","message":"Would it be better to store the whole key path here in the metadata? That way you wouldn\u0027t have to recreate the key path for the delete and retrieve operations.\n\nOr maybe create some small utitity function that you can use in each of these:\n\ndef build_vault_keypath(conf, keyid):\n    return \u0027secret/\u0027 + conf.vault_barbican_path + keyid","commit_id":"f257337d19a291fb7533683769f085ae33a29a11"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"4e104765fcb59a20c1fbf8676d310d9e12695225","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        keyid \u003d str(secret_metadata[VaultSecretStore.KEY_ID])"},{"line_number":179,"context_line":"        keypath \u003d self._get_vault_path(keyid)"},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            client.delete(keypath)"},{"line_number":182,"context_line":"        except Exception as e:"},{"line_number":183,"context_line":"            LOG.exception(u._LE(\"Error destroying secret\"))"},{"line_number":184,"context_line":"            raise ss.SecretGeneralException(e)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_12f852c4","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":18},"updated":"2017-02-27 14:39:30.000000000","message":"should be \"self.client.delete(keypath)\"","commit_id":"a01e3550b9db1adf35a991995570853d79c91c86"}],"requirements.txt":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"37325f92119621526bafe59e6089bcbce15d3fc9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"cffi # MIT"},{"line_number":7,"context_line":"cryptography!\u003d1.3.0,\u003e\u003d1.0 # BSD/Apache-2.0"},{"line_number":8,"context_line":"eventlet!\u003d0.18.3,\u003e\u003d0.18.2 # MIT"},{"line_number":9,"context_line":"hvac\u003e\u003d0.2.17"},{"line_number":10,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0 # MIT"},{"line_number":11,"context_line":"oslo.config!\u003d3.18.0,\u003e\u003d3.14.0 # Apache-2.0"},{"line_number":12,"context_line":"oslo.context\u003e\u003d2.12.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"da36d5c6_64349649","line":9,"updated":"2017-02-24 22:28:38.000000000","message":"This will need to go into global requirements","commit_id":"f257337d19a291fb7533683769f085ae33a29a11"}]}