)]}'
{"install-guide/source/conf.py":[{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a266a8c73945dcb06423de1fe4e9422027d1886a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# All configuration values have a default; values that are commented out"},{"line_number":21,"context_line":"# serve to show the default."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":"# import sys"},{"line_number":25,"context_line":"import subprocess"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_00c61367","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":9},"updated":"2017-03-07 16:59:22.000000000","message":"This is now unused.","commit_id":"dd8735a65ae5ee408963bb254e171cce54e69432"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a266a8c73945dcb06423de1fe4e9422027d1886a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"giturl \u003d (u\u0027https://git.openstack.org/cgit/openstack/barbican/\u0027"},{"line_number":78,"context_line":"          \u0027tree/install-guide/source\u0027)"},{"line_number":79,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":80,"context_line":"gitsha \u003d subprocess.Popen("},{"line_number":81,"context_line":"    git_cmd, stdout\u003dsubprocess.PIPE).communicate()[0].strip(\u0027\\n\u0027)"},{"line_number":82,"context_line":"html_context \u003d {\"gitsha\": gitsha, \"bug_tag\": bug_tag,"},{"line_number":83,"context_line":"                \"giturl\": giturl,"},{"line_number":84,"context_line":"                \"bug_project\": \"barbican\"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_5b20fa9b","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":65},"updated":"2017-03-07 16:59:22.000000000","message":"This doesn\u0027t work.  Try using\n\n  gitsha \u003d subprocess.Popen(git_cmd, shell\u003dTrue).communicate()[0]\n\nI tested the above command and it seems to work.","commit_id":"dd8735a65ae5ee408963bb254e171cce54e69432"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"734c1f9e4cb1646ceab6d10d435d604821111d21","unresolved":false,"context_lines":[{"line_number":76,"context_line":"giturl \u003d (u\u0027https://git.openstack.org/cgit/openstack/barbican/\u0027"},{"line_number":77,"context_line":"          \u0027tree/install-guide/source\u0027)"},{"line_number":78,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":79,"context_line":"gitsha \u003d  subprocess.Popen(git_cmd, shell\u003dTrue).communicate()[0].strip(\u0027\\n\u0027)"},{"line_number":80,"context_line":"html_context \u003d {\"gitsha\": gitsha, \"bug_tag\": bug_tag,"},{"line_number":81,"context_line":"                \"giturl\": giturl,"},{"line_number":82,"context_line":"                \"bug_project\": \"barbican\"}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_002898e1","line":79,"updated":"2017-03-08 20:17:27.000000000","message":"Though this works, it\u0027s not very readable. It may be cleaner to do this:\n\n    git_out \u003d subprocess.Popen(\n                git_cmd,\n                shell\u003dTrue,\n                universal_newlines\u003dTrue,\n                stdout\u003dsubprocess.PIPE,\n                stderr\u003dsubprocess.PIPE)\n\n    git_stdout, git_stderr \u003d result.communicate(input\u003dNone)\n\n    gitsha \u003d git_stdout\n\nAnd if you want to catch errors:\n\n    if git_out.returncode !\u003d 0:\n        print git_stderr","commit_id":"cda0b5be15a0c1869e75d031b1cfa501a9d17034"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"560dc9bbce8ab6a0afada4b87639c9ef2e00c112","unresolved":false,"context_lines":[{"line_number":76,"context_line":"giturl \u003d (u\u0027https://git.openstack.org/cgit/openstack/barbican/\u0027"},{"line_number":77,"context_line":"          \u0027tree/install-guide/source\u0027)"},{"line_number":78,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":79,"context_line":"git_out \u003d subprocess.Popen(git_cmd, shell\u003dTrue,"},{"line_number":80,"context_line":"            universal_newlines\u003dTrue,"},{"line_number":81,"context_line":"            stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"            stderr\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_b641b1ab","line":79,"updated":"2017-03-09 15:45:17.000000000","message":"I noticed that you\u0027re still getting Jenkins failures. Have you verified that passing in the git_cmd argument to subprocess.Popen is valid? I usually pass in an array of strings, rather than an entire string, when calling subprocess.Popen.\n\nSee the Python subprocess documentation for more information:\nhttps://docs.python.org/3/library/subprocess.html#popen-constructor","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"90563639b935517a80d6f2059d0ba7e72d280b60","unresolved":false,"context_lines":[{"line_number":76,"context_line":"giturl \u003d (u\u0027https://git.openstack.org/cgit/openstack/barbican/\u0027"},{"line_number":77,"context_line":"          \u0027tree/install-guide/source\u0027)"},{"line_number":78,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":79,"context_line":"git_out \u003d subprocess.Popen(git_cmd, shell\u003dTrue,"},{"line_number":80,"context_line":"            universal_newlines\u003dTrue,"},{"line_number":81,"context_line":"            stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"            stderr\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_d40e1d3a","line":79,"in_reply_to":"9a30ddce_b641b1ab","updated":"2017-03-09 16:34:02.000000000","message":"When shell-True, it is recommended to pass the args as string, so I don\u0027t think that is the issue.","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"90563639b935517a80d6f2059d0ba7e72d280b60","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            universal_newlines\u003dTrue,"},{"line_number":81,"context_line":"            stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"            stderr\u003dsubprocess.PIPE)"},{"line_number":83,"context_line":"git_stdout, git_stderr \u003d result.communicate(input\u003dNone)"},{"line_number":84,"context_line":"gitsha \u003d git_stdout"},{"line_number":85,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":86,"context_line":"  print git_stderr"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_cf9848c3","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":31},"updated":"2017-03-09 16:34:02.000000000","message":"this should be `git_out`  and not `result`","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},"change_message_id":"3d73944c57abb7b63821d69b2e1a421ef84521c1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            universal_newlines\u003dTrue,"},{"line_number":81,"context_line":"            stdout\u003dsubprocess.PIPE,"},{"line_number":82,"context_line":"            stderr\u003dsubprocess.PIPE)"},{"line_number":83,"context_line":"git_stdout, git_stderr \u003d result.communicate(input\u003dNone)"},{"line_number":84,"context_line":"gitsha \u003d git_stdout"},{"line_number":85,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":86,"context_line":"  print git_stderr"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_dce548a4","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":31},"in_reply_to":"9a30ddce_cf9848c3","updated":"2017-03-10 05:35:22.000000000","message":"++","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},"change_message_id":"3d73944c57abb7b63821d69b2e1a421ef84521c1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"git_stdout, git_stderr \u003d result.communicate(input\u003dNone)"},{"line_number":84,"context_line":"gitsha \u003d git_stdout"},{"line_number":85,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":86,"context_line":"  print git_stderr"},{"line_number":87,"context_line":"html_context \u003d {\"gitsha\": gitsha, \"bug_tag\": bug_tag,"},{"line_number":88,"context_line":"                \"giturl\": giturl,"},{"line_number":89,"context_line":"                \"bug_project\": \"barbican\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_1c044048","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":7},"updated":"2017-03-10 05:35:22.000000000","message":"please use print(git_stderr)","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"90563639b935517a80d6f2059d0ba7e72d280b60","unresolved":false,"context_lines":[{"line_number":83,"context_line":"git_stdout, git_stderr \u003d result.communicate(input\u003dNone)"},{"line_number":84,"context_line":"gitsha \u003d git_stdout"},{"line_number":85,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":86,"context_line":"  print git_stderr"},{"line_number":87,"context_line":"html_context \u003d {\"gitsha\": gitsha, \"bug_tag\": bug_tag,"},{"line_number":88,"context_line":"                \"giturl\": giturl,"},{"line_number":89,"context_line":"                \"bug_project\": \"barbican\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_af44f41a","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":7},"updated":"2017-03-09 16:34:02.000000000","message":"use py3 compatible print(git_stderr)","commit_id":"63aa31246a8ba2e9069a6d2ace70ef7b41a7e91c"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"1e07042796e1a0809b13e93cd76227c207cad2d2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          \u0027tree/install-guide/source\u0027)"},{"line_number":78,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":79,"context_line":"args \u003d shlex.split(git_cmd)"},{"line_number":80,"context_line":"git_out \u003d subprocess.Popen(args, shell\u003dTrue,"},{"line_number":81,"context_line":"                           universal_newlines\u003dTrue,"},{"line_number":82,"context_line":"                           stdout\u003dsubprocess.PIPE,"},{"line_number":83,"context_line":"                           stderr\u003dsubprocess.PIPE)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a1ff146_e982aa51","line":80,"updated":"2017-03-15 22:29:56.000000000","message":"From https://docs.python.org/2/library/subprocess.html#subprocess.Popen:\n\n  If shell is True, it is recommended to pass args as a string rather than as a sequence.\n\nSo you could remove the shlex import, remove line 79, and pass in git_cmd instead of args in line 80.","commit_id":"307f157a80473dbe5bea93fd109fddc56e38a8b8"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"1e07042796e1a0809b13e93cd76227c207cad2d2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                           universal_newlines\u003dTrue,"},{"line_number":82,"context_line":"                           stdout\u003dsubprocess.PIPE,"},{"line_number":83,"context_line":"                           stderr\u003dsubprocess.PIPE)"},{"line_number":84,"context_line":"git_stdout, git_stderr \u003d git_out.communicate(input\u003dNone)"},{"line_number":85,"context_line":"gitsha \u003d git_stdout"},{"line_number":86,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":87,"context_line":"    print(git_stderr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a1ff146_a991929b","line":84,"updated":"2017-03-15 22:29:56.000000000","message":"Here on this line, you could say:\n\n  gitsha, git_stderr \u003d ...\n\nand remove line 85","commit_id":"307f157a80473dbe5bea93fd109fddc56e38a8b8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"5919f805524512302c710d49a8d1ea4dad7baafc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                           universal_newlines\u003dTrue,"},{"line_number":82,"context_line":"                           stdout\u003dsubprocess.PIPE,"},{"line_number":83,"context_line":"                           stderr\u003dsubprocess.PIPE)"},{"line_number":84,"context_line":"git_stdout, git_stderr \u003d git_out.communicate(input\u003dNone)"},{"line_number":85,"context_line":"gitsha \u003d git_stdout"},{"line_number":86,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":87,"context_line":"    print(git_stderr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a1ff146_69fa3abf","line":84,"in_reply_to":"3a1ff146_a991929b","updated":"2017-03-15 22:36:09.000000000","message":"Doing this would be slightly more efficient, but keeping git_stdout would be more readable. I guess it just depends on what\u0027s more important?","commit_id":"307f157a80473dbe5bea93fd109fddc56e38a8b8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"5919f805524512302c710d49a8d1ea4dad7baafc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                           stderr\u003dsubprocess.PIPE)"},{"line_number":84,"context_line":"git_stdout, git_stderr \u003d git_out.communicate(input\u003dNone)"},{"line_number":85,"context_line":"gitsha \u003d git_stdout"},{"line_number":86,"context_line":"if git_out.returncode !\u003d 0:"},{"line_number":87,"context_line":"    print(git_stderr)"},{"line_number":88,"context_line":"html_context \u003d {\"gitsha\": gitsha, \"bug_tag\": bug_tag,"},{"line_number":89,"context_line":"                \"giturl\": giturl,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a1ff146_29276265","line":86,"updated":"2017-03-15 22:36:09.000000000","message":"This should probably be checked before assigning the gitsha value. And possibly throw `gitsha \u003d git_stdout` in an else block.","commit_id":"307f157a80473dbe5bea93fd109fddc56e38a8b8"}]}
