)]}'
{"barbican/cmd/pkcs11_migrate_kek_signatures.py":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"9b2a513c63e9bbba21c03d6f5f01725fc8a7042c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                self.pkcs11.verify_hmac(hmac_key, hmac, kek_data, self.session)"},{"line_number":61,"context_line":"                sig_good \u003d True"},{"line_number":62,"context_line":"            except P11CryptoPluginException as e:"},{"line_number":63,"context_line":"                if \u0027CKR_SIGNATURE_INVALID\u0027 in e:"},{"line_number":64,"context_line":"                    sig_good \u003d False"},{"line_number":65,"context_line":"                else:"},{"line_number":66,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_6c81f4c3","line":63,"updated":"2017-06-20 03:37:46.000000000","message":"I think we should convert e var to string instead of using it as an object in this case.","commit_id":"df1a327d45855300066a7e63af08878aee2e1d08"}],"barbican/tests/common/test_validators.py":[{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"9b2a513c63e9bbba21c03d6f5f01725fc8a7042c","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            self.validator.validate(self.secret_req)"},{"line_number":417,"context_line":"        except excep.InvalidObject as e:"},{"line_number":418,"context_line":"            self.assertIsNotNone(e)"},{"line_number":419,"context_line":"            self.assertIsNotNone(e.message)"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            self.fail(\u0027No validation exception was raised\u0027)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_0cf5e083","side":"PARENT","line":419,"updated":"2017-06-20 03:37:46.000000000","message":"I think e is an object, so we need to keep this one to check if message is None or use six lib instead.","commit_id":"bc963d55aabc1ff282c4cd5d1d25e71dcac1151b"}]}
