)]}'
{"barbican/model/repositories.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"LOG \u003d utils.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"_ENGINE \u003d None"},{"line_number":48,"context_line":"_SESSION_FACTORY \u003d None"},{"line_number":49,"context_line":"BASE \u003d models.BASE"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_f5109c02","side":"PARENT","line":46,"updated":"2017-09-07 06:18:12.000000000","message":"change not related!","commit_id":"9eb9c807576a25c381237f111f101c1ab9d93e4d"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":73,"context_line":"_TRANSPORT_KEY_REPOSITORY \u003d None"},{"line_number":74,"context_line":"_SECRET_STORES_REPOSITORY \u003d None"},{"line_number":75,"context_line":"_PROJECT_SECRET_STORE_REPOSITORY \u003d None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"CONF \u003d config.CONF"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_b5f694d6","side":"PARENT","line":76,"updated":"2017-09-07 06:18:12.000000000","message":"ditto!","commit_id":"9eb9c807576a25c381237f111f101c1ab9d93e4d"}],"barbican/objects/base.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","username":"liujiong"},"change_message_id":"e648a0a6173adb1a10584b7aaa6e0111f2c1dfd2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    as appropriate."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027barbican_object\u0027"},{"line_number":48,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027barbican\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":28,"id":"df87a7cf_96b515f1","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":44},"updated":"2017-12-15 08:08:57.000000000","message":"According to https://docs.openstack.org/oslo.versionedobjects/latest/user/usage.html#create-base-object-with-the-project-namespace, this param is used only for backward compatibility and should not be set in new projects. Do we need to set it?","commit_id":"e02e99425be5ba9805da34d63b5fcdd6635ca2dc"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"8b3720b6deade4943c2f87f9d1c96c8f97105008","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    as appropriate."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027barbican_object\u0027"},{"line_number":48,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027barbican\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":28,"id":"df87a7cf_35db76ed","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":44},"in_reply_to":"df87a7cf_6c50be5f","updated":"2017-12-20 04:24:01.000000000","message":"I removed this line of code in this patch: \nhttps://review.openstack.org/#/c/528972/3/barbican/objects/base.py","commit_id":"e02e99425be5ba9805da34d63b5fcdd6635ca2dc"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"350cee70a31834e3fb85ab5d97d54befad521ab2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    as appropriate."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027barbican_object\u0027"},{"line_number":48,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027barbican\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":28,"id":"df87a7cf_6c50be5f","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":44},"in_reply_to":"df87a7cf_96b515f1","updated":"2017-12-15 10:01:29.000000000","message":"Oh yes, Because we are creating a new object so we don\u0027t need it. I will update in next patch.","commit_id":"e02e99425be5ba9805da34d63b5fcdd6635ca2dc"}],"barbican/objects/fields.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ElementTypeError \u003d fields.ElementTypeError"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Import fields from oslo.versionedobjects"},{"line_number":21,"context_line":"BooleanField \u003d fields.BooleanField"},{"line_number":22,"context_line":"UnspecifiedDefault \u003d fields.UnspecifiedDefault"},{"line_number":23,"context_line":"IntegerField \u003d fields.IntegerField"},{"line_number":24,"context_line":"NonNegativeIntegerField \u003d fields.NonNegativeIntegerField"},{"line_number":25,"context_line":"UUIDField \u003d fields.UUIDField"},{"line_number":26,"context_line":"FloatField \u003d fields.FloatField"},{"line_number":27,"context_line":"NonNegativeFloatField \u003d fields.NonNegativeFloatField"},{"line_number":28,"context_line":"StringField \u003d fields.StringField"},{"line_number":29,"context_line":"SensitiveStringField \u003d fields.SensitiveStringField"},{"line_number":30,"context_line":"EnumField \u003d fields.EnumField"},{"line_number":31,"context_line":"DateTimeField \u003d fields.DateTimeField"},{"line_number":32,"context_line":"DictOfStringsField \u003d fields.DictOfStringsField"},{"line_number":33,"context_line":"DictOfNullableStringsField \u003d fields.DictOfNullableStringsField"},{"line_number":34,"context_line":"DictOfIntegersField \u003d fields.DictOfIntegersField"},{"line_number":35,"context_line":"ListOfStringsField \u003d fields.ListOfStringsField"},{"line_number":36,"context_line":"SetOfIntegersField \u003d fields.SetOfIntegersField"},{"line_number":37,"context_line":"ListOfSetsOfIntegersField \u003d fields.ListOfSetsOfIntegersField"},{"line_number":38,"context_line":"ListOfDictOfNullableStringsField \u003d fields.ListOfDictOfNullableStringsField"},{"line_number":39,"context_line":"DictProxyField \u003d fields.DictProxyField"},{"line_number":40,"context_line":"ObjectField \u003d fields.ObjectField"},{"line_number":41,"context_line":"ListOfObjectsField \u003d fields.ListOfObjectsField"},{"line_number":42,"context_line":"VersionPredicateField \u003d fields.VersionPredicateField"},{"line_number":43,"context_line":"FlexibleBooleanField \u003d fields.FlexibleBooleanField"},{"line_number":44,"context_line":"DictOfListOfStringsField \u003d fields.DictOfListOfStringsField"},{"line_number":45,"context_line":"IPAddressField \u003d fields.IPAddressField"},{"line_number":46,"context_line":"IPV4AddressField \u003d fields.IPV4AddressField"},{"line_number":47,"context_line":"IPV6AddressField \u003d fields.IPV6AddressField"},{"line_number":48,"context_line":"IPV4AndV6AddressField \u003d fields.IPV4AndV6AddressField"},{"line_number":49,"context_line":"IPNetworkField \u003d fields.IPNetworkField"},{"line_number":50,"context_line":"IPV4NetworkField \u003d fields.IPV4NetworkField"},{"line_number":51,"context_line":"IPV6NetworkField \u003d fields.IPV6NetworkField"},{"line_number":52,"context_line":"AutoTypedField \u003d fields.AutoTypedField"},{"line_number":53,"context_line":"BaseEnumField \u003d fields.BaseEnumField"},{"line_number":54,"context_line":"MACAddressField \u003d fields.MACAddressField"},{"line_number":55,"context_line":"ListOfIntegersField \u003d fields.ListOfIntegersField"},{"line_number":56,"context_line":"PCIAddressField \u003d fields.PCIAddressField"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(danms): These are things we need to import for some of our"},{"line_number":59,"context_line":"# own implementations below, our tests, or other transitional"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_f57f7c63","line":56,"range":{"start_line":21,"start_character":0,"end_line":56,"end_character":40},"updated":"2017-09-07 06:18:12.000000000","message":"It should be a alphabet list.","commit_id":"7022b4a49855879280584989d51a3ccbc7a9ebcf"}],"barbican/objects/kekdatum.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@object_base.VersionedObjectRegistry.register"},{"line_number":22,"context_line":"class KEKDatum(base.BarbicanObject, base.BarbicanPersistentObject,"},{"line_number":23,"context_line":"               object_base.VersionedObjectDictCompat):"},{"line_number":24,"context_line":"    fields \u003d {"},{"line_number":25,"context_line":"        \u0027plugin_name\u0027: fields.StringField(),"},{"line_number":26,"context_line":"        \u0027kek_label\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_d5dda070","line":23,"range":{"start_line":22,"start_character":6,"end_line":23,"end_character":54},"updated":"2017-09-07 06:18:12.000000000","message":"Shall we introduce \u0027VERSION\u0027?","commit_id":"7022b4a49855879280584989d51a3ccbc7a9ebcf"}],"barbican/objects/secret.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@object_base.VersionedObjectRegistry.register"},{"line_number":25,"context_line":"class Secret(base.BarbicanObject, base.BarbicanPersistentObject,"},{"line_number":26,"context_line":"             object_base.VersionedObjectDictCompat):"},{"line_number":27,"context_line":"    \"\"\"This class represents Secret object\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027name\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_95bcb806","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":45},"updated":"2017-09-07 06:18:12.000000000","message":"How about VERSION\u003d\u00271.0\u0027?","commit_id":"7022b4a49855879280584989d51a3ccbc7a9ebcf"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03a09f632cb55d6d0ed619b0f00b0c75bb1a7b89","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _from_db_object(secret, db_secret):"},{"line_number":53,"context_line":"        for field in secret.fields:"},{"line_number":54,"context_line":"            if field \u003d\u003d \u0027secret_store_metadata\u0027:"},{"line_number":55,"context_line":"                raw_ss_meta_obj \u003d db_secret[\u0027secret_store_metadata\u0027]"},{"line_number":56,"context_line":"                if raw_ss_meta_obj:"},{"line_number":57,"context_line":"                    raw_ss_meta_obj_dict \u003d \\"},{"line_number":58,"context_line":"                        {key:"},{"line_number":59,"context_line":"                            secret_store_metadatum.SecretStoreMetadatum."},{"line_number":60,"context_line":"                            _from_db_object("},{"line_number":61,"context_line":"                                secret_store_metadatum.SecretStoreMetadatum(),"},{"line_number":62,"context_line":"                                value) for"},{"line_number":63,"context_line":"                            key, value in raw_ss_meta_obj.items()}"},{"line_number":64,"context_line":"                    secret[field] \u003d raw_ss_meta_obj_dict"},{"line_number":65,"context_line":"                else:"},{"line_number":66,"context_line":"                    secret[field] \u003d raw_ss_meta_obj"},{"line_number":67,"context_line":"            elif field \u003d\u003d \u0027secret_user_metadata\u0027:"},{"line_number":68,"context_line":"                raw_su_meta_obj \u003d \\"},{"line_number":69,"context_line":"                    db_secret[\u0027secret_user_metadata\u0027]"},{"line_number":70,"context_line":"                if raw_su_meta_obj:"},{"line_number":71,"context_line":"                    raw_su_meta_obj_dict \u003d \\"},{"line_number":72,"context_line":"                        {key:"},{"line_number":73,"context_line":"                            secret_user_metadatum.SecretUserMetadatum."},{"line_number":74,"context_line":"                            _from_db_object("},{"line_number":75,"context_line":"                                secret_user_metadatum.SecretUserMetadatum(),"},{"line_number":76,"context_line":"                                value) for"},{"line_number":77,"context_line":"                            key, value in raw_su_meta_obj.items()}"},{"line_number":78,"context_line":"                    secret[field] \u003d raw_su_meta_obj_dict"},{"line_number":79,"context_line":"                else:"},{"line_number":80,"context_line":"                    secret[field] \u003d raw_su_meta_obj"},{"line_number":81,"context_line":"            elif field \u003d\u003d \u0027encrypted_data\u0027:"},{"line_number":82,"context_line":"                raw_en_data_obj \u003d db_secret[\u0027encrypted_data\u0027]"},{"line_number":83,"context_line":"                if raw_en_data_obj:"},{"line_number":84,"context_line":"                    raw_en_data_obj_list \u003d \\"},{"line_number":85,"context_line":"                        [enda.EncryptedDatum._from_db_object("},{"line_number":86,"context_line":"                            enda.EncryptedDatum(), raw)"},{"line_number":87,"context_line":"                            for raw in raw_en_data_obj]"},{"line_number":88,"context_line":"                    secret[field] \u003d raw_en_data_obj_list"},{"line_number":89,"context_line":"                else:"},{"line_number":90,"context_line":"                    secret[field] \u003d raw_en_data_obj"},{"line_number":91,"context_line":"            else:"},{"line_number":92,"context_line":"                secret[field] \u003d db_secret[field]"},{"line_number":93,"context_line":"        secret[\u0027secret_acls\u0027] \u003d db_secret.secret_acls"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f287b81_356624c3","line":90,"range":{"start_line":53,"start_character":0,"end_line":90,"end_character":51},"updated":"2017-09-07 06:18:12.000000000","message":"How about if \u0027secret_store_metadata\u0027 in secret.fields:\n              ....\n          if \u0027secret_user_metadata\u0027 in secret.fields:\n              .... ?","commit_id":"7022b4a49855879280584989d51a3ccbc7a9ebcf"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ace284b13ea1b59dc034416cc29127cc6ff88924","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    db_repo \u003d repo.get_secret_repository()"},{"line_number":56,"context_line":"    synthetic_fields \u003d [\u0027encrypted_data\u0027, \u0027secret_acls\u0027,"},{"line_number":57,"context_line":"                        \u0027secret_store_metadata\u0027, \u0027secret_user_metadata\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def get_secret_list(cls, external_project_id,"},{"line_number":61,"context_line":"                        offset_arg\u003dNone, limit_arg\u003dNone,"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_24348edd","line":58,"updated":"2018-05-15 02:46:09.000000000","message":"So, this is a general question which will help me understand how this patch is constructed.\n\nAs far as I can understand, the new OVO contains a reference to the old model object and the old repo for that object.  It also contains a field for the version (which is the whole point of this).\n\nFrom what I can see, what you\u0027ve basically done for each object is: \n1) add the reference to the repo and old model object\n2) re-implemented the repo calls by calling the relevant call.\n3) added a definition of the fields in terms of parameters in fields.*\n4) any fields that are orm relationships are defined and also added to synthetic_fields[]\n\nSome questions:\n\n1) So, if I later add a new field, I\u0027ll need to add to the fields hash in the OVO, as well as to the old model object, and increment the version, right?\n\n2) Whats the relationship between the fields in the OVO and the fields in the model object.  For instance, it looks like many fields in the underlying object are not nullable or have a default, whereas the ones in the OVO are nullable.  There are also some with uniqueness constraints etc.  Do any of those things matter?\n\n3) I noticed that Project for instance has a whole slew of ORM relationships, but none are defined in the new Project OVO object  -- is this a mistake -- or if not, whats the criteria for determining whether or not to create a field in the OVO?\n\n4. For some OVO, it looks like you added status -- isn\u0027t this in the BaseObject?","commit_id":"7454944672e03e9dd3a134737bfa8f6ac27d6de7"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"bc829c7285ebf823ce2b4b5324a08edb10d95d45","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    db_repo \u003d repo.get_secret_repository()"},{"line_number":56,"context_line":"    synthetic_fields \u003d [\u0027encrypted_data\u0027, \u0027secret_acls\u0027,"},{"line_number":57,"context_line":"                        \u0027secret_store_metadata\u0027, \u0027secret_user_metadata\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def get_secret_list(cls, external_project_id,"},{"line_number":61,"context_line":"                        offset_arg\u003dNone, limit_arg\u003dNone,"}],"source_content_type":"text/x-python","patch_set":52,"id":"5f7c97a3_ac301309","line":58,"in_reply_to":"5f7c97a3_24348edd","updated":"2018-05-21 04:12:36.000000000","message":"Basically, OVO in Barbican, for now, is an abstract to interact with coding and database. When you want to create, delete, update a record in database them I have to call OVO instead of initializing Models.\n\n1. Yes, you are right.\n\n2. As the feature of SQLAIchemy, the relationship is to load information from other tables which have relation to the main table via foreign keys. And this information will be used surely.  So foreign keys in OVO simply is to load information from other tables which are loaded from models.\n\n3. Yes, I know this. But the relationship tables are not used anymore, so it isn\u0027t necessary to declare them.\n\n4. Some classes in Model (SecretACL for example) have this line of code \"self.status \u003d States.ACTIVE\" in the __init__ method. It means the status attribute in the classes is always ACTIVE so the classed in OVO need to append the status field to overwrite the status file in BarbicanObject.","commit_id":"7454944672e03e9dd3a134737bfa8f6ac27d6de7"}]}
