)]}'
{"barbican/model/models.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":1374,"context_line":""},{"line_number":1375,"context_line":"        # Note(namnh): Due to OVO will check this condition, so no need to"},{"line_number":1376,"context_line":"        # check here."},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        self.store_plugin \u003d store_plugin"},{"line_number":1379,"context_line":"        self.name \u003d name"},{"line_number":1380,"context_line":"        self.crypto_plugin \u003d crypto_plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b0986169","line":1377,"updated":"2018-07-01 14:15:50.000000000","message":"Same comment as is previous patch. Lets add a comment and remove this check only when the OVO switch is done.\n\nIn any case, the way this patch is implemented, you\u0027re adding a comment about removing a check - with no check there!","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":1374,"context_line":""},{"line_number":1375,"context_line":"        # Note(namnh): Due to OVO will check this condition, so no need to"},{"line_number":1376,"context_line":"        # check here."},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        self.store_plugin \u003d store_plugin"},{"line_number":1379,"context_line":"        self.name \u003d name"},{"line_number":1380,"context_line":"        self.crypto_plugin \u003d crypto_plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_aa94ee41","line":1377,"in_reply_to":"5f7c97a3_b0986169","updated":"2018-08-14 16:46:45.000000000","message":"This comment was updated by other my patch set.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"        super(ProjectSecretStore, self).__init__()"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        # Note(namnh): Due to OVO will check this condition, so no need to"},{"line_number":1427,"context_line":"        # check here."},{"line_number":1428,"context_line":"        self.project_id \u003d project_id"},{"line_number":1429,"context_line":"        self.secret_store_id \u003d secret_store_id"},{"line_number":1430,"context_line":"        self.status \u003d States.ACTIVE"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_509f8d50","line":1427,"updated":"2018-07-01 14:15:50.000000000","message":"ditto","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"}],"barbican/tests/model/test_models.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":652,"context_line":"    #                       models.SecretStores, None, store_plugin)"},{"line_number":653,"context_line":"    #     self.assertRaises(exception.MissingArgumentError,"},{"line_number":654,"context_line":"    #                       models.SecretStores, \"\", store_plugin)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def test_secret_stores_check_to_dict_fields(self):"},{"line_number":657,"context_line":"        name \u003d \"pkcs11 backend\""},{"line_number":658,"context_line":"        store_plugin \u003d \u0027store_crypto\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_30a451a3","line":655,"updated":"2018-07-01 14:15:50.000000000","message":"same comment as before.  Remove tests and check after OVO switch made.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":652,"context_line":"    #                       models.SecretStores, None, store_plugin)"},{"line_number":653,"context_line":"    #     self.assertRaises(exception.MissingArgumentError,"},{"line_number":654,"context_line":"    #                       models.SecretStores, \"\", store_plugin)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def test_secret_stores_check_to_dict_fields(self):"},{"line_number":657,"context_line":"        name \u003d \"pkcs11 backend\""},{"line_number":658,"context_line":"        store_plugin \u003d \u0027store_crypto\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2a821e00","line":655,"in_reply_to":"5f7c97a3_30a451a3","updated":"2018-08-14 16:46:45.000000000","message":"sure","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"}],"barbican/tests/objects/test_ovo_project_secret_store.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"6551b1ef3ac39671a3c5071964bc364d1f2f96c7","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _create_secret_stores_obj(self, name, store_plugin, crypto_plugin\u003dNone,"},{"line_number":36,"context_line":"                                  global_default\u003dNone):"},{"line_number":37,"context_line":"        secret_stores_obj \u003d objects.SecretStores(name\u003dname,"},{"line_number":38,"context_line":"                                                 store_plugin\u003dstore_plugin,"},{"line_number":39,"context_line":"                                                 crypto_plugin\u003dcrypto_plugin,"},{"line_number":40,"context_line":"                                                 global_default\u003dglobal_default)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1bbce6da","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":25},"updated":"2018-08-07 20:49:36.000000000","message":"This is better in terms of readability, but I was objecting to the fact that the object being returned is of type SecretStores instead of SecretStore when in fact, its referring to one secret store.\n\nI think the underlying object name SecretStores should be changed to SecretStore.","commit_id":"85ceb4f1894973cb2dfb7d47d5665bc5e88b8c98"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"f730eafb25af38d75ea888f69c71f3291f6eb3a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _create_secret_stores_obj(self, name, store_plugin, crypto_plugin\u003dNone,"},{"line_number":36,"context_line":"                                  global_default\u003dNone):"},{"line_number":37,"context_line":"        secret_stores_obj \u003d objects.SecretStores(name\u003dname,"},{"line_number":38,"context_line":"                                                 store_plugin\u003dstore_plugin,"},{"line_number":39,"context_line":"                                                 crypto_plugin\u003dcrypto_plugin,"},{"line_number":40,"context_line":"                                                 global_default\u003dglobal_default)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5646ac23","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":25},"in_reply_to":"3f79a3b5_1bbce6da","updated":"2018-08-08 06:31:48.000000000","message":"Should I do in another patch that changes object name SecretStores to SecretStore?","commit_id":"85ceb4f1894973cb2dfb7d47d5665bc5e88b8c98"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7581b564883123c39cf4ca628ec141b661f20976","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _create_secret_stores_obj(self, name, store_plugin, crypto_plugin\u003dNone,"},{"line_number":36,"context_line":"                                  global_default\u003dNone):"},{"line_number":37,"context_line":"        secret_stores_obj \u003d objects.SecretStores(name\u003dname,"},{"line_number":38,"context_line":"                                                 store_plugin\u003dstore_plugin,"},{"line_number":39,"context_line":"                                                 crypto_plugin\u003dcrypto_plugin,"},{"line_number":40,"context_line":"                                                 global_default\u003dglobal_default)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ab66a828","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":25},"in_reply_to":"3f79a3b5_5646ac23","updated":"2018-08-08 21:26:31.000000000","message":"Ok - thats fine.  Lets get that patch in this week before we forget.","commit_id":"85ceb4f1894973cb2dfb7d47d5665bc5e88b8c98"}],"barbican/tests/objects/test_ovo_project_ss.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from barbican.common import exception"},{"line_number":19,"context_line":"from barbican import objects"},{"line_number":20,"context_line":"from barbican.tests.objects import test_ovo_base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestProjectSecretStore(test_ovo_base.OVOTestCase):"},{"line_number":24,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f0b7b9d6","line":21,"updated":"2018-07-01 14:15:50.000000000","message":"Is there any reason not to use the full filename --\ntest_ovo_project_secret_store.py ?","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from barbican.common import exception"},{"line_number":19,"context_line":"from barbican import objects"},{"line_number":20,"context_line":"from barbican.tests.objects import test_ovo_base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestProjectSecretStore(test_ovo_base.OVOTestCase):"},{"line_number":24,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c3bdb2d8","line":21,"in_reply_to":"3f79a3b5_ff032c0c","updated":"2018-08-14 16:46:45.000000000","message":"@Phuong: Thanks for your helping to update my patch. \n@Ade: Yeah, it should be update the name of file.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from barbican.common import exception"},{"line_number":19,"context_line":"from barbican import objects"},{"line_number":20,"context_line":"from barbican.tests.objects import test_ovo_base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestProjectSecretStore(test_ovo_base.OVOTestCase):"},{"line_number":24,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff032c0c","line":21,"in_reply_to":"5f7c97a3_f0b7b9d6","updated":"2018-08-07 10:37:46.000000000","message":"Done","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                             global_default\u003dNone):"},{"line_number":37,"context_line":"        s_stores \u003d objects.SecretStores(name\u003dname, store_plugin\u003dstore_plugin,"},{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_50cd4d5c","line":39,"updated":"2018-07-01 14:15:50.000000000","message":"Must have missed this before, but why is this objects.SecretStores as opposed to objects.SecretStore ?  SecretStores implies a list of SecretStore objects.\n\nThis makes this confusing to read.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ef9f9005446e05211f47eec249ca1878c6bcd74c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                             global_default\u003dNone):"},{"line_number":37,"context_line":"        s_stores \u003d objects.SecretStores(name\u003dname, store_plugin\u003dstore_plugin,"},{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bb0ff22c","line":39,"in_reply_to":"3f79a3b5_62730382","updated":"2018-08-07 20:45:09.000000000","message":"Yes - please rename.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                             global_default\u003dNone):"},{"line_number":37,"context_line":"        s_stores \u003d objects.SecretStores(name\u003dname, store_plugin\u003dstore_plugin,"},{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c38b721c","line":39,"in_reply_to":"3f79a3b5_bb0ff22c","updated":"2018-08-14 16:46:45.000000000","message":"@Ade: I don\u0027t think that it should be renamed. Each object in Barbican OVO represents a table in database or a mode in the model.py file. So that\u0027s why this object should be \"SecretStores\".\n\nAnw, let me think it again.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                             global_default\u003dNone):"},{"line_number":37,"context_line":"        s_stores \u003d objects.SecretStores(name\u003dname, store_plugin\u003dstore_plugin,"},{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_62730382","line":39,"in_reply_to":"5f7c97a3_50cd4d5c","updated":"2018-08-07 10:37:46.000000000","message":"SecretStores is the name of object, is that correct? I will rename to prevent confusing. WDYT?","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_project(self):"},{"line_number":44,"context_line":"        external_id \u003d \u0027keystone_project_id\u0027 + uuidutils.generate_uuid("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_10d7d5f0","line":41,"updated":"2018-07-01 14:15:50.000000000","message":"This should return s_store \u003d\u003d 1 SecretStore object.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ef9f9005446e05211f47eec249ca1878c6bcd74c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_project(self):"},{"line_number":44,"context_line":"        external_id \u003d \u0027keystone_project_id\u0027 + uuidutils.generate_uuid("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fb26cab7","line":41,"in_reply_to":"3f79a3b5_a2ffdb65","updated":"2018-08-07 20:45:09.000000000","message":"right - same comment as above.\n\n1 SecretStores object is confusing, one SecretStore object is not.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_project(self):"},{"line_number":44,"context_line":"        external_id \u003d \u0027keystone_project_id\u0027 + uuidutils.generate_uuid("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e30c6ea6","line":41,"in_reply_to":"3f79a3b5_f00260b4","updated":"2018-08-14 16:46:45.000000000","message":"@Ade: If the name of the object is SecretStores then the result should return 1. But the \"create\" method is inherited by Base OVO class, so it will return a object. Let me think it again.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"f730eafb25af38d75ea888f69c71f3291f6eb3a5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_project(self):"},{"line_number":44,"context_line":"        external_id \u003d \u0027keystone_project_id\u0027 + uuidutils.generate_uuid("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f00260b4","line":41,"in_reply_to":"3f79a3b5_fb26cab7","updated":"2018-08-08 06:31:48.000000000","message":"Please check my update code. Tks.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                        crypto_plugin\u003dcrypto_plugin,"},{"line_number":39,"context_line":"                                        global_default\u003dglobal_default)"},{"line_number":40,"context_line":"        s_stores.create(session\u003dself.session)"},{"line_number":41,"context_line":"        return s_stores"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_project(self):"},{"line_number":44,"context_line":"        external_id \u003d \u0027keystone_project_id\u0027 + uuidutils.generate_uuid("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a2ffdb65","line":41,"in_reply_to":"5f7c97a3_10d7d5f0","updated":"2018-08-07 10:37:46.000000000","message":"return 1 SecretStores object","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return project"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _create_project_store(self, project_id, secret_store_id):"},{"line_number":51,"context_line":"        project_ss \u003d objects.ProjectSecretStore("},{"line_number":52,"context_line":"            project_id\u003dproject_id,"},{"line_number":53,"context_line":"            secret_store_id\u003dsecret_store_id)"},{"line_number":54,"context_line":"        project_ss.create(session\u003dself.session)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_90fc4573","line":51,"updated":"2018-07-01 14:15:50.000000000","message":"def_create_project_secret_store()","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return project"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _create_project_store(self, project_id, secret_store_id):"},{"line_number":51,"context_line":"        project_ss \u003d objects.ProjectSecretStore("},{"line_number":52,"context_line":"            project_id\u003dproject_id,"},{"line_number":53,"context_line":"            secret_store_id\u003dsecret_store_id)"},{"line_number":54,"context_line":"        project_ss.create(session\u003dself.session)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e3e30ed8","line":51,"in_reply_to":"3f79a3b5_62f9c37e","updated":"2018-08-14 16:46:45.000000000","message":"thanks all for your coment and updating","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return project"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def _create_project_store(self, project_id, secret_store_id):"},{"line_number":51,"context_line":"        project_ss \u003d objects.ProjectSecretStore("},{"line_number":52,"context_line":"            project_id\u003dproject_id,"},{"line_number":53,"context_line":"            secret_store_id\u003dsecret_store_id)"},{"line_number":54,"context_line":"        project_ss.create(session\u003dself.session)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_62f9c37e","line":51,"in_reply_to":"5f7c97a3_90fc4573","updated":"2018-08-07 10:37:46.000000000","message":"Done","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return project_ss"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_ovo_get_by_entity_id(self):"},{"line_number":58,"context_line":"        \"\"\"Tests for \u0027get\u0027 call by project secret store id\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        project \u003d self._create_project()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_30ebf1a4","line":58,"updated":"2018-07-01 14:15:50.000000000","message":"This is testing the create but not the \u0027get\u0027 call.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return project_ss"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_ovo_get_by_entity_id(self):"},{"line_number":58,"context_line":"        \"\"\"Tests for \u0027get\u0027 call by project secret store id\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        project \u003d self._create_project()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_82f65f8f","line":58,"in_reply_to":"5f7c97a3_30ebf1a4","updated":"2018-08-07 10:37:46.000000000","message":"Done","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        project \u003d self._create_project()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        prject_ss \u003d self._create_project_store(project.id,"},{"line_number":63,"context_line":"                                               self.default_secret_store.id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertIsNotNone(prject_ss)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_70f16996","line":62,"updated":"2018-07-01 14:15:50.000000000","message":"project_ss not prject_ss","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        project \u003d self._create_project()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        prject_ss \u003d self._create_project_store(project.id,"},{"line_number":63,"context_line":"                                               self.default_secret_store.id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertIsNotNone(prject_ss)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_63cffe55","line":62,"in_reply_to":"3f79a3b5_22f3cba0","updated":"2018-08-14 16:46:45.000000000","message":"thanks","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        project \u003d self._create_project()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        prject_ss \u003d self._create_project_store(project.id,"},{"line_number":63,"context_line":"                                               self.default_secret_store.id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertIsNotNone(prject_ss)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_22f3cba0","line":62,"in_reply_to":"5f7c97a3_70f16996","updated":"2018-08-07 10:37:46.000000000","message":"Done","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertRaises(exception.ConstraintCheck,"},{"line_number":120,"context_line":"                          self._create_project_store,"},{"line_number":121,"context_line":"                          project1.id, s_store2.id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_ovo_do_entity_name(self):"},{"line_number":124,"context_line":"        \"\"\"Code coverage for entity_name which is used in case of exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3040d1a2","line":121,"updated":"2018-07-01 14:15:50.000000000","message":"Does the constraint check exception have any information as to why this fails?  I\u0027m just wondering what the user experience for this is.  Does it make sense to have the OVO pass through an exception more specific and descriptive exception?  Or to do a pre-check?","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertRaises(exception.ConstraintCheck,"},{"line_number":120,"context_line":"                          self._create_project_store,"},{"line_number":121,"context_line":"                          project1.id, s_store2.id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_ovo_do_entity_name(self):"},{"line_number":124,"context_line":"        \"\"\"Code coverage for entity_name which is used in case of exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_29d55244","line":121,"in_reply_to":"3f79a3b5_9b69d6bf","updated":"2018-08-14 16:46:45.000000000","message":"It is hard to pre-check this. Because OVO don\u0027t need to do this.\n\n@Ade: As design database, we have a uniquecontrain in here [1]. That\u0027s why there is this unittest.\n\n\n[1] https://github.com/openstack/barbican/blob/master/barbican/model/migration/alembic_migrations/versions/39cf2e645cba_model_for_multiple_backend_support.py#L49","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ef9f9005446e05211f47eec249ca1878c6bcd74c","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertRaises(exception.ConstraintCheck,"},{"line_number":120,"context_line":"                          self._create_project_store,"},{"line_number":121,"context_line":"                          project1.id, s_store2.id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_ovo_do_entity_name(self):"},{"line_number":124,"context_line":"        \"\"\"Code coverage for entity_name which is used in case of exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9b69d6bf","line":121,"in_reply_to":"3f79a3b5_aa19ed79","updated":"2018-08-07 20:45:09.000000000","message":"sure","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertRaises(exception.ConstraintCheck,"},{"line_number":120,"context_line":"                          self._create_project_store,"},{"line_number":121,"context_line":"                          project1.id, s_store2.id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_ovo_do_entity_name(self):"},{"line_number":124,"context_line":"        \"\"\"Code coverage for entity_name which is used in case of exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aa19ed79","line":121,"in_reply_to":"5f7c97a3_3040d1a2","updated":"2018-08-07 10:37:46.000000000","message":"Can I do a pre-check in a difference patchset in the following file? \n\nhttps://github.com/openstack/barbican/blob/08ca2287dd845011d940a722f6418c3b73c6c7ae/barbican/model/repositories.py#L487","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"040c03687a261a7cd8216bb966de162de929bdce","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f01339b6","line":200,"updated":"2018-07-01 14:15:50.000000000","message":"Is there a test for a non-empty get_project_entities?","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7581b564883123c39cf4ca628ec141b661f20976","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ab3468fc","line":200,"in_reply_to":"3f79a3b5_70289033","updated":"2018-08-08 21:26:31.000000000","message":"Please add a TODO here to let us know that there is still work to be done to implement this.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"f730eafb25af38d75ea888f69c71f3291f6eb3a5","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_70289033","line":200,"in_reply_to":"3f79a3b5_9b731681","updated":"2018-08-08 06:31:48.000000000","message":"Because ProjectSecretStore.get_project_entities function is not implemented completely so this function will always return an empty list.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"f7557e909bf723e1423b53445b66bd03416a0754","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c2cef361","line":200,"in_reply_to":"3f79a3b5_ab3468fc","updated":"2018-08-14 16:46:45.000000000","message":"@Ade: This method is written in BarbicanObject.","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"ef9f9005446e05211f47eec249ca1878c6bcd74c","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9b731681","line":200,"in_reply_to":"3f79a3b5_ae56e405","updated":"2018-08-07 20:45:09.000000000","message":"I\u0027m not sure I understand what you mean by that?","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e2329c16c4b4f9b0d27a5caba66248c73eb148eb","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def test_ovo_get_project_entities(self):"},{"line_number":198,"context_line":"        entities \u003d objects.ProjectSecretStore.get_project_entities("},{"line_number":199,"context_line":"            uuidutils.generate_uuid(dashed\u003dFalse), session\u003dself.session)"},{"line_number":200,"context_line":"        self.assertEqual([], entities)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_ovo_create_or_update_for_project(self):"},{"line_number":203,"context_line":"        project1 \u003d self._create_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ae56e405","line":200,"in_reply_to":"5f7c97a3_f01339b6","updated":"2018-08-07 10:37:46.000000000","message":"function to get project entities is not implemented\n\nhttps://github.com/openstack/barbican/blob/08ca2287dd845011d940a722f6418c3b73c6c7ae/barbican/model/repositories.py#L514","commit_id":"5aa1a48b74226863dd2465560a490e53e89636a0"}]}