)]}'
{"barbican/plugin/crypto/pkcs11.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"87f8caeeefdd387c8cc1331bf142bbdd94b5c6a2","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        self.gcmtagsize \u003d 16"},{"line_number":395,"context_line":"        self.generate_iv \u003d generate_iv"},{"line_number":396,"context_line":"        self.always_set_cka_sensitive \u003d always_set_cka_sensitive"},{"line_number":397,"context_line":"        self.hmac_keywrap_mechanism \u003d CKM_NAMES[hmac_keywrap_mechanism]"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        # Validate configuration and RNG"},{"line_number":400,"context_line":"        session \u003d self.get_session()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_bd5e06e4","line":397,"updated":"2019-03-07 04:29:37.000000000","message":"What happens if hmac_keywrap_mechanism is None?  The way this is currently written, if the parameter is not passed in, we\u0027ll get a nasty uncaught exception.  Is this really an optional parameter?\n\nShould there be checks similar to lines 372/3 above?","commit_id":"f1ab45c382b540e11e14060a5aa47ee26922cecb"}]}