)]}'
{"devstack/lib/barbican":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"6ae1af67915465eac481a8b34ad257d534dc8a61","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            screen -S ${existing_ses} -X quit"},{"line_number":78,"context_line":"        fi"},{"line_number":79,"context_line":"        pid\u003d$(sudo ps -ef | grep \"vault server\" | grep -v grep | awk \u0027{print $2}\u0027)"},{"line_number":80,"context_line":"        sudo kill -9 $pid"},{"line_number":81,"context_line":"        sudo rm -f ${vault_token_file} vault.log"},{"line_number":82,"context_line":"    fi"},{"line_number":83,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_87a688ac","line":80,"updated":"2019-12-13 21:35:49.000000000","message":"My personal preference is to write lines 79 and 80 as:\n\nsudo pkill -f -9 \"vault server\"\n\nas I think it\u0027s a bit cleaner.  Really a nit though.","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e84f30b1e56bb4a48dcd729cdfec48a208c4ddb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            screen -S ${existing_ses} -X quit"},{"line_number":78,"context_line":"        fi"},{"line_number":79,"context_line":"        pid\u003d$(sudo ps -ef | grep \"vault server\" | grep -v grep | awk \u0027{print $2}\u0027)"},{"line_number":80,"context_line":"        sudo kill -9 $pid"},{"line_number":81,"context_line":"        sudo rm -f ${vault_token_file} vault.log"},{"line_number":82,"context_line":"    fi"},{"line_number":83,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_1378967c","line":80,"in_reply_to":"3fa7e38b_87a688ac","updated":"2019-12-14 07:52:32.000000000","message":"Done","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a7ff79bbdbcb4319ed64f16d116da8c862708588","unresolved":false,"context_lines":[{"line_number":575,"context_line":"function install_vault {"},{"line_number":576,"context_line":"    # Install vault if needed"},{"line_number":577,"context_line":"    if [[ ! -x \"$(command -v vault)\" ]]; then"},{"line_number":578,"context_line":"        wget https://releases.hashicorp.com/vault/0.10.3/vault_0.10.3_linux_amd64.zip"},{"line_number":579,"context_line":"        unzip vault_0.10.3_linux_amd64.zip"},{"line_number":580,"context_line":"        sudo mv vault /usr/bin"},{"line_number":581,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_848c46d9","line":578,"range":{"start_line":578,"start_character":50,"end_line":578,"end_character":85},"updated":"2019-12-13 20:52:00.000000000","message":"I wonder why we are pinned to this version?  It\u0027s a year and half old.\n\nIt looks like the current version is 1.3.0 and 1.0.0 has been out for over a year.  I won\u0027t hold up this patch since this is not your change, but I think we definitely need to start using a newer version of Vault as soon as possible.","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e84f30b1e56bb4a48dcd729cdfec48a208c4ddb","unresolved":false,"context_lines":[{"line_number":575,"context_line":"function install_vault {"},{"line_number":576,"context_line":"    # Install vault if needed"},{"line_number":577,"context_line":"    if [[ ! -x \"$(command -v vault)\" ]]; then"},{"line_number":578,"context_line":"        wget https://releases.hashicorp.com/vault/0.10.3/vault_0.10.3_linux_amd64.zip"},{"line_number":579,"context_line":"        unzip vault_0.10.3_linux_amd64.zip"},{"line_number":580,"context_line":"        sudo mv vault /usr/bin"},{"line_number":581,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_337d926d","line":578,"range":{"start_line":578,"start_character":50,"end_line":578,"end_character":85},"in_reply_to":"3fa7e38b_848c46d9","updated":"2019-12-14 07:52:32.000000000","message":"Done","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a7ff79bbdbcb4319ed64f16d116da8c862708588","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        echo \"Wah! Need to throw an error code here!\""},{"line_number":610,"context_line":"    fi"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    export VAULT_ADDR\u003d\"http://127.0.0.1:8200\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    # Enable kv version 1"},{"line_number":615,"context_line":"    vault secrets disable secret/"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_44b88e77","line":612,"range":{"start_line":612,"start_character":30,"end_line":612,"end_character":39},"updated":"2019-12-13 20:52:00.000000000","message":"Why do we need this change?","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e84f30b1e56bb4a48dcd729cdfec48a208c4ddb","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        echo \"Wah! Need to throw an error code here!\""},{"line_number":610,"context_line":"    fi"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    export VAULT_ADDR\u003d\"http://127.0.0.1:8200\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    # Enable kv version 1"},{"line_number":615,"context_line":"    vault secrets disable secret/"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_d3919e9d","line":612,"range":{"start_line":612,"start_character":30,"end_line":612,"end_character":39},"in_reply_to":"3fa7e38b_44b88e77","updated":"2019-12-14 07:52:32.000000000","message":"Because in my devstack environment, when starting vault in dev mode, only using 127.0.0.1 is working. Maybe I am missing something, but ${HOST_IP} is working for you?","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a7ff79bbdbcb4319ed64f16d116da8c862708588","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    root_token_id\u003d`cat ${BARBICAN_DIR}/vault_root_token_id`"},{"line_number":628,"context_line":"    iniset $BARBICAN_CONF secretstore enabled_secretstore_plugins vault_plugin"},{"line_number":629,"context_line":"    iniset $BARBICAN_CONF vault_plugin root_token_id $root_token_id"},{"line_number":630,"context_line":"    iniset $BARBICAN_CONF vault_plugin vault_url \"http://127.0.0.1:8200\""},{"line_number":631,"context_line":"    iniset $BARBICAN_CONF vault_plugin use_ssl \"false\""},{"line_number":632,"context_line":"}"},{"line_number":633,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3fa7e38b_64bd8a66","line":630,"range":{"start_line":630,"start_character":57,"end_line":630,"end_character":66},"updated":"2019-12-13 20:52:00.000000000","message":"Same question as above.","commit_id":"7f9a8661a4d95cf7773c4d1c1c4abfa0d72bbaf7"}]}