)]}'
{"barbican/plugin/crypto/p11_crypto.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e7da2da0ca44075fcdae2ca477ef8707be74f2d7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        \u0027not specified.\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027slot_id\u0027,"},{"line_number":48,"context_line":"               help\u003du._(\u0027(Optional) HSM Slot ID that contains the token \u0027"},{"line_number":49,"context_line":"                        \u0027device to be used.\u0027)),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027login\u0027,"},{"line_number":51,"context_line":"               help\u003du._(\u0027Password to login to PKCS11 session\u0027),"},{"line_number":52,"context_line":"               secret\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_516321dd","line":49,"updated":"2020-10-19 19:17:09.000000000","message":"So what are the ramifications of changing this default -- will we end up breaking folks?","commit_id":"17bdb280d33d5604e52982324593f9e7de725f2a"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a4cf9ab2b45a9acc9f156694b0d5912f3c8f9a4a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                        \u0027not specified.\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027slot_id\u0027,"},{"line_number":48,"context_line":"               help\u003du._(\u0027(Optional) HSM Slot ID that contains the token \u0027"},{"line_number":49,"context_line":"                        \u0027device to be used.\u0027)),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027login\u0027,"},{"line_number":51,"context_line":"               help\u003du._(\u0027Password to login to PKCS11 session\u0027),"},{"line_number":52,"context_line":"               secret\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_f1722de3","line":49,"in_reply_to":"5f681702_516321dd","updated":"2020-10-19 19:51:49.000000000","message":"Yes, there is the possibility of breaking deployments that depend on the current default value.  I\u0027ll update the patch as per the feedback you gave me offline.","commit_id":"17bdb280d33d5604e52982324593f9e7de725f2a"}],"barbican/plugin/crypto/pkcs11.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c60c475cd44ca8d05300afd785378c5996955d8f","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        return slot_id"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    def get_session(self):"},{"line_number":525,"context_line":"        session \u003d self._open_session(self.slot_id)"},{"line_number":526,"context_line":"        # Get session info to check user state"},{"line_number":527,"context_line":"        session_info \u003d self._get_session_info(session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_50915b99","line":524,"updated":"2020-10-14 22:34:03.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"89841c7e71b5fe86bb66bd77874e4ea7c1289be0"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e7da2da0ca44075fcdae2ca477ef8707be74f2d7","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            return token.slot_id"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # If we got this far, slot_id was the only param given, so we return it"},{"line_number":520,"context_line":"        return slot_id"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def get_session(self):"},{"line_number":523,"context_line":"        session \u003d self._open_session(self.slot_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_b10d5539","line":520,"updated":"2020-10-19 19:17:09.000000000","message":"Do we need to throw an error here if the slot_id is None? (and add a matching test)","commit_id":"17bdb280d33d5604e52982324593f9e7de725f2a"}],"barbican/tests/plugin/crypto/test_pkcs11.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"98bd0045ad50b95b6e6116dce6ea36e1853063ee","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _verify(self, *args, **kwargs):"},{"line_number":175,"context_line":"        return pkcs11.CKR_OK"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_get_slot_id_from_serial_number(self):"},{"line_number":178,"context_line":"        slot_id \u003d self.pkcs11._get_slot_id(\u0027111111\u0027, None, None)"},{"line_number":179,"context_line":"        self.assertEqual(1, slot_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_d913d7b7","line":176,"updated":"2020-10-19 20:57:49.000000000","message":"NIT: Are any of the tests below valid for token_id \u003d None, given that it defaults to 1?","commit_id":"87b406f69b7456b81d6b951207059a3595ccd9ce"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"a4d0d58de065c24bc1371bfb94f54d18df9abc2e","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _verify(self, *args, **kwargs):"},{"line_number":175,"context_line":"        return pkcs11.CKR_OK"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_get_slot_id_from_serial_number(self):"},{"line_number":178,"context_line":"        slot_id \u003d self.pkcs11._get_slot_id(\u0027111111\u0027, None, None)"},{"line_number":179,"context_line":"        self.assertEqual(1, slot_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f681702_1946ef7d","line":176,"in_reply_to":"5f681702_d913d7b7","updated":"2020-10-19 21:24:34.000000000","message":"Yes, good catch.  The slot_id will never be None now that we\u0027ve restored the default value.  I\u0027ve updated these to use the default value of 1.","commit_id":"87b406f69b7456b81d6b951207059a3595ccd9ce"}]}