)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"1a461dba397d37725b93b005b78c3f5e2bd8c472","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[doc] Fix hmac/mkek generation commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accidentally wrong lables were copy pasted into the doc. In the meanwhile"},{"line_number":10,"context_line":"labels in sample commands should be the same as used in config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ddbd086815917cd0c124a88b31333fd366a574c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0610b49b_efcb4dfd","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":62},"updated":"2021-01-12 16:58:44.000000000","message":"Which config are you referring to here?  We don\u0027t ship a default config file anymore.  Instead a config file can be generated using \n\n    tox -egenconfig\n\nAs documented here: https://opendev.org/openstack/barbican/src/branch/master/etc/barbican/README.barbican.conf.txt","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7bcf67cf0a2e00806e1293213750a2cc29308b6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[doc] Fix hmac/mkek generation commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accidentally wrong lables were copy pasted into the doc. In the meanwhile"},{"line_number":10,"context_line":"labels in sample commands should be the same as used in config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ddbd086815917cd0c124a88b31333fd366a574c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"93dcac87_5c75680c","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":62},"in_reply_to":"0610b49b_efcb4dfd","updated":"2021-01-12 18:14:05.000000000","message":"I\u0027m reffering to the config sample that is provided in this doc for specific hsm section","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"d41fdeb938cc7bb3e166ef0bbc9ab0489a13c8d9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[doc] Fix hmac/mkek generation commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accidentally wrong lables were copy pasted into the doc. In the meanwhile"},{"line_number":10,"context_line":"labels in sample commands should be the same as used in config."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ddbd086815917cd0c124a88b31333fd366a574c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"68d25990_5336c4b7","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":62},"in_reply_to":"93dcac87_5c75680c","updated":"2021-01-12 19:56:59.000000000","message":"Oh, I see where the confusion is stemming from.  I\u0027ll update your patch and we should be able to get this merged.","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"}],"doc/source/install/barbican-backend.rst":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"1a461dba397d37725b93b005b78c3f5e2bd8c472","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    .. code-block:: ini"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"       barbican-manage hsm gen_hmac --library-path /usr/lib/libCryptoki2_64.so \\"},{"line_number":164,"context_line":"       --passphrase XXX --slot-id 1 --label my_hmac_label"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    .. code-block:: ini"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"10d2f893_d3499d30","line":164,"range":{"start_line":164,"start_character":44,"end_line":164,"end_character":57},"updated":"2021-01-12 16:58:44.000000000","message":"Barbican configuration does not specify a default value for hmac_label:\n\nhttps://opendev.org/openstack/barbican/src/branch/master/barbican/plugin/crypto/p11_crypto.py#L54-L55\n\nWhere is this new value coming from?","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7bcf67cf0a2e00806e1293213750a2cc29308b6","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    .. code-block:: ini"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"       barbican-manage hsm gen_hmac --library-path /usr/lib/libCryptoki2_64.so \\"},{"line_number":164,"context_line":"       --passphrase XXX --slot-id 1 --label my_hmac_label"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    .. code-block:: ini"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0fc4caa0_dffd9b64","line":164,"range":{"start_line":164,"start_character":44,"end_line":164,"end_character":57},"in_reply_to":"10d2f893_d3499d30","updated":"2021-01-12 18:14:05.000000000","message":"It comes from the code snippet above `hmac_label \u003d \u0027my_hmac_label\u0027`","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"1a461dba397d37725b93b005b78c3f5e2bd8c472","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    .. code-block:: ini"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"       barbican-manage hsm gen_mkek --library-path /usr/lib/libCryptoki2_64.so \\"},{"line_number":169,"context_line":"       --passphrase XXX --slot-id 1 --label an_mkek"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"nCipher"},{"line_number":172,"context_line":"+++++++"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ac8b63b1_c4649e91","line":169,"range":{"start_line":169,"start_character":44,"end_line":169,"end_character":51},"updated":"2021-01-12 16:58:44.000000000","message":"mkek_label also does not specify a default value:\n\nhttps://opendev.org/openstack/barbican/src/branch/master/barbican/plugin/crypto/p11_crypto.py#L50-L51\n\nWhere is this new value coming from?","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f7bcf67cf0a2e00806e1293213750a2cc29308b6","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    .. code-block:: ini"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"       barbican-manage hsm gen_mkek --library-path /usr/lib/libCryptoki2_64.so \\"},{"line_number":169,"context_line":"       --passphrase XXX --slot-id 1 --label an_mkek"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"nCipher"},{"line_number":172,"context_line":"+++++++"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4efaab13_df194987","line":169,"range":{"start_line":169,"start_character":44,"end_line":169,"end_character":51},"in_reply_to":"ac8b63b1_c4649e91","updated":"2021-01-12 18:14:05.000000000","message":"same thing here","commit_id":"193c3f3a63680df0b3a7ee5eee337134f4f77e5b"}]}