)]}'
{"barbican/model/migration/alembic_migrations/versions/0f8c192a061f_add_secret_consumers.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63591cc316aba140154eb2c62135d21083ee1ff4","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    ctx \u003d op.get_context()"},{"line_number":34,"context_line":"    con \u003d op.get_bind()"},{"line_number":35,"context_line":"    table_exists \u003d sa.inspect.has_table(con.engine, \"secret_consumer_metadata\")"},{"line_number":36,"context_line":"    if not table_exists:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ca747aa_5798b791","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":26},"updated":"2021-06-14 15:56:37.000000000","message":"pep8 doesn\u0027t like this not being used","commit_id":"0f129df9a628c8dbad0249edd33ffc2614de9199"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d9d707e2c7a10eb7b5d008edfa6dfc7ac3801380","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    con \u003d op.get_bind()"},{"line_number":34,"context_line":"    table_exists \u003d sa.inspect(con.engine).has_table(\"secret_consumer_metadata\")"},{"line_number":35,"context_line":"    if not table_exists:"},{"line_number":36,"context_line":"        op.create_table("},{"line_number":37,"context_line":"            \"secret_consumer_metadata\","}],"source_content_type":"text/x-python","patch_set":4,"id":"08f177ce_29dc2d2c","line":34,"updated":"2021-06-18 07:47:58.000000000","message":"should also update minimum requirement for sqlalchemy https://review.opendev.org/c/openstack/barbican/+/796284/4/requirements.txt#30 if going this way.\n\nIn RDO with sqlalchemy-1.3.23, we hitting ERROR: \u0027Inspector\u0027 object has no attribute \u0027has_table\u0027 https://logserver.rdoproject.org/ci.centos.org/weirdo-generic-puppet-openstack-scenario003/19684/weirdo-project/puppet.txt.gz\n\n\nhttps://github.com/sqlalchemy/sqlalchemy/commit/00b5c10846e800304caa86549ab9da373b42fa5d is in \u003e\u003d 1.4.0","commit_id":"1ae4badb1a78a6ce8dfcbddfe478506b7af10624"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"c11212434e30d2256b126f71f1de36a439634763","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    con \u003d op.get_bind()"},{"line_number":34,"context_line":"    table_exists \u003d sa.inspect(con.engine).has_table(\"secret_consumer_metadata\")"},{"line_number":35,"context_line":"    if not table_exists:"},{"line_number":36,"context_line":"        op.create_table("},{"line_number":37,"context_line":"            \"secret_consumer_metadata\","}],"source_content_type":"text/x-python","patch_set":4,"id":"a0d91cfb_2ab626cb","line":34,"in_reply_to":"08f177ce_29dc2d2c","updated":"2021-06-18 11:00:00.000000000","message":"tried bumping sqlalchemy in RDO to 1.4.18[1], and older barbican(before this commit) fails[2] with ERROR: The argument passed to Dialect.has_table() should be a \u003cclass \u0027sqlalchemy.engine.base.Connection\u0027\u003e, got \u003cclass \u0027sqlalchemy.engine.base.Engine\u0027\u003e. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(\u003ctablename\u003e\u003e)`` for public API use.\nWould it be possible to fix in backward compatible way? such that it works for sqlalchemy-1.3.23 too, in our testing also seen gnocchi and watched had some issues with sqlalchemy-1.4.18 so those also needs to be fixed. For now will pin barbican to working commit in RDO, can be unpinned once barbican get\u0027s fix.\n\n[1] https://review.rdoproject.org/r/c/rdoinfo/+/34221\n[2] https://logserver.rdoproject.org/21/34221/3/check/validate-buildsys-tags-xena-testing-puppet-scenario003-centos8/ad1c115/logs/weirdo-project/puppet.txt.gz","commit_id":"1ae4badb1a78a6ce8dfcbddfe478506b7af10624"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c743d1a4dce86e6ae9185e0965cd8887cb46e901","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    con \u003d op.get_bind()"},{"line_number":34,"context_line":"    table_exists \u003d sa.inspect(con.engine).has_table(\"secret_consumer_metadata\")"},{"line_number":35,"context_line":"    if not table_exists:"},{"line_number":36,"context_line":"        op.create_table("},{"line_number":37,"context_line":"            \"secret_consumer_metadata\","}],"source_content_type":"text/x-python","patch_set":4,"id":"bc9ef7f8_38e2135b","line":34,"in_reply_to":"a0d91cfb_2ab626cb","updated":"2021-06-18 11:08:54.000000000","message":"This one is on me, I went with a \"keep current behavior\" approach and didn\u0027t check compatibility of the change with older versions.\n\nI believe to keep the backward compatibility necessary for RDO we should go with dmendiza\u0027s approach [1], which removes the check and relies on alembic\u0027s versioning checks.\n\n[1]: https://review.opendev.org/c/openstack/barbican/+/796059","commit_id":"1ae4badb1a78a6ce8dfcbddfe478506b7af10624"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e21f9ab2ee61445e2480eb47416fceec4044c7a4","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    con \u003d op.get_bind()"},{"line_number":34,"context_line":"    table_exists \u003d sa.inspect(con.engine).has_table(\"secret_consumer_metadata\")"},{"line_number":35,"context_line":"    if not table_exists:"},{"line_number":36,"context_line":"        op.create_table("},{"line_number":37,"context_line":"            \"secret_consumer_metadata\","}],"source_content_type":"text/x-python","patch_set":4,"id":"05573dbe_222f9e5a","line":34,"in_reply_to":"bc9ef7f8_38e2135b","updated":"2021-06-18 14:59:10.000000000","message":"Thanks gorka, on our side we have pinned barbican until it get\u0027s fixed, can revert once it fixes. https://bugs.launchpad.net/tripleo/+bug/1932527","commit_id":"1ae4badb1a78a6ce8dfcbddfe478506b7af10624"}]}