)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"00eedf5e9833a821692f79d17a00aa0976c97a71","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kyle Wuolle \u003ckyle.wuolle@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-24 11:05:39 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the names property on kmip objects to ensure that it\u0027s possible to store mulitple objects of the same type in a kmip backend server. The KMIP spec specifies that a name should be unique and the pyKmip library inserts a default name attribute value when a name parameter is not provided. The name attribute ends up being the same value for every object of the same type leading to errors when trying to store them."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaf5bc590e06e088b0a055ad46d0e1791af849859"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c5ed2342_aa7f6f3b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2021-07-14 21:41:41.000000000","message":"Please make this the summary line for the commit and make the rest the body.\n\nAlso please add footers:\n\nStory: 2009006\nTask: 42684\n\nSee https://docs.openstack.org/contributors/common/git.html#commit-messages for more details.","commit_id":"e4f69d911f6331fa74cec028858b312a0a758043"},{"author":{"_account_id":33669,"name":"Kyle Wuolle","email":"kyle.wuolle@gmail.com","username":"kylewuolle"},"change_message_id":"efb36b64045e015228ad0436548280efd7504607","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kyle Wuolle \u003ckyle.wuolle@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-24 11:05:39 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the names property on kmip objects to ensure that it\u0027s possible to store mulitple objects of the same type in a kmip backend server. The KMIP spec specifies that a name should be unique and the pyKmip library inserts a default name attribute value when a name parameter is not provided. The name attribute ends up being the same value for every object of the same type leading to errors when trying to store them."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaf5bc590e06e088b0a055ad46d0e1791af849859"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8cf3de43_1f03ffd8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"in_reply_to":"c5ed2342_aa7f6f3b","updated":"2021-07-15 18:27:22.000000000","message":"Done","commit_id":"e4f69d911f6331fa74cec028858b312a0a758043"}],"barbican/plugin/kmip_secret_store.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"00eedf5e9833a821692f79d17a00aa0976c97a71","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            kmip_object \u003d objects.SecretData(normalized_secret, data_type)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        if hasattr(kmip_object, \u0027names\u0027):"},{"line_number":506,"context_line":"            kmip_object.names \u003d []"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        return kmip_object"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"78cf5323_bc836b0c","line":506,"range":{"start_line":506,"start_character":12,"end_line":506,"end_character":1},"updated":"2021-07-14 21:41:41.000000000","message":"I wonder if this would cause issues with other parts of pykmip?  For some objects (e.g. SecretData above) it appears that there is no way to make an instance like this using the api.\n\nIt definitely seems like a bug in pykmip.  Have you already filed a bug on their tracker?","commit_id":"e4f69d911f6331fa74cec028858b312a0a758043"},{"author":{"_account_id":33669,"name":"Kyle Wuolle","email":"kyle.wuolle@gmail.com","username":"kylewuolle"},"change_message_id":"efb36b64045e015228ad0436548280efd7504607","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            kmip_object \u003d objects.SecretData(normalized_secret, data_type)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        if hasattr(kmip_object, \u0027names\u0027):"},{"line_number":506,"context_line":"            kmip_object.names \u003d []"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        return kmip_object"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ee6e6cbb_5c17276d","line":506,"range":{"start_line":506,"start_character":12,"end_line":506,"end_character":1},"in_reply_to":"78cf5323_bc836b0c","updated":"2021-07-15 18:27:22.000000000","message":"I think it\u0027s safe here because we don\u0027t really need the name attribute to be set at all in the kmip enabled backend server. I thought about approaching pykmip about this but I think that eliminating the default parameter value on their end could probably lead to regressions for other users of the library. I could imagine someone expecting that array to exist or something along those lines.","commit_id":"e4f69d911f6331fa74cec028858b312a0a758043"}]}