)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c1528844f6bbce081b828f2c968dfc67dd7b8af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e99e2f5e_c5f0c7d9","updated":"2022-02-21 18:30:08.000000000","message":"As discussed, we need a follow up documentation patch.","commit_id":"86d2ba0e9001354c68b88571ed793edfeb7e1306"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"ffe26ce25d98dba79e9c6d259e9b0d8632d77ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a27a3b11_8c45f138","updated":"2022-02-16 14:19:44.000000000","message":"I guess we need some documentation for the secret consumers API and a release note as a followup.","commit_id":"86d2ba0e9001354c68b88571ed793edfeb7e1306"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"c8b978b9c0bfa6d8de6bec42ebc7449e0ae656ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdd0e0b3_1db543ef","updated":"2022-02-24 20:57:55.000000000","message":"This is a good start, but we also need to implement the version discovery section of the Microversion spec: https://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html#version-discovery","commit_id":"86d2ba0e9001354c68b88571ed793edfeb7e1306"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"7ff07608df0540ae1f11cc49b33fdc030230ba05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eda21e75_962d65ec","in_reply_to":"fdd0e0b3_1db543ef","updated":"2022-02-24 21:40:56.000000000","message":"Hey, what do you see missing specifically?\n\nI just noticed that I followed an example from nova which uses \u0027version\u0027 instead of \u0027max_version\u0027 like in the spec you linked [1], so that probably needs to be fixed. We don\u0027t send the \u0027status\u0027, since we have only one API.\n\n\nI also tested the error responses and one issue I see is that the microversion-parse middleware doesn\u0027t adhere to the errors guidelines mentioned in the spec, although it returns the right http status code, example response body:\n\n{\"message\": \"The resource could not be generated that was acceptable to your browser\\n(content of type application/json. \u003cbr /\u003e\u003cbr /\u003e\\nInvalid microversion: Unacceptable version header: 1.2\", \"code\": \"406 Not Acceptable\", \"title\": \"Not Acceptable\"}\n\nI guess that would have to be fixed in microversion-parse.\n\n\n[1] https://docs.openstack.org/api-guide/compute/microversions.html","commit_id":"86d2ba0e9001354c68b88571ed793edfeb7e1306"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"d863c3a927486c5dad095890ae6261a80216a952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4282509a_c4fd024f","updated":"2022-03-04 20:56:14.000000000","message":"recheck - timeout\n","commit_id":"0532aa67a353f8e075ab721c90a47f9c7c8f6217"}],"barbican/api/controllers/secrets.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"c8b978b9c0bfa6d8de6bec42ebc7449e0ae656ef","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        def secret_fields(field):"},{"line_number":369,"context_line":"            resp \u003d putil.mime_types.augment_fields_with_content_types(field)"},{"line_number":370,"context_line":"            if no_consumers:"},{"line_number":371,"context_line":"                del resp[\u0027consumers\u0027]"},{"line_number":372,"context_line":"            return resp"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        LOG.debug(\u0027Start secrets on_get \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3b2a829c_73af69b3","line":371,"range":{"start_line":371,"start_character":16,"end_line":371,"end_character":37},"updated":"2022-02-24 20:57:55.000000000","message":"I think it would be better to do this in the model layer where the JSON representation of the entity is first created instead of having to edit the JSON representation in every controller that has differences.","commit_id":"86d2ba0e9001354c68b88571ed793edfeb7e1306"}]}