)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"5e83771f732264d24e05a6c6474f866e157e6d65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"144067b8_52a4576b","updated":"2022-04-27 10:39:06.000000000","message":"recheck","commit_id":"c14a10a1f72bb3381442a9ebcd3313ec30f3f5fb"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"368d6b61_4ee8e6da","updated":"2022-04-27 14:48:22.000000000","message":"respect!","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbfab85ac6bf8156bed043358e4b490f4cf32f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"03fa5c73_ea2b0ade","updated":"2026-05-17 05:09:16.000000000","message":"This was already completed by https://review.opendev.org/c/openstack/barbican/+/842455 .","commit_id":"b69f10002ad391d6eac5918bbedb4d28568afe0c"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aec4e6f2_ff5f14f5","updated":"2022-04-28 08:00:58.000000000","message":"re","commit_id":"b69f10002ad391d6eac5918bbedb4d28568afe0c"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"4c6b1df42bfa5fc053743329c142c5eb5b342655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6b416bac_ac6cfcda","updated":"2022-07-11 08:58:00.000000000","message":"recheck","commit_id":"b69f10002ad391d6eac5918bbedb4d28568afe0c"}],"barbican/plugin/castellan_secret_store.py":[{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            return ss.SecretDTO(secret_type, data, ss.KeySpec(), None)"},{"line_number":126,"context_line":"        except Exception as e:"},{"line_number":127,"context_line":"            LOG.exception(\"Error retrieving secret {}: {}\".format("},{"line_number":128,"context_line":"                secret_ref, str(e)))"},{"line_number":129,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def store_secret(self, secret_dto):"}],"source_content_type":"text/x-python","patch_set":9,"id":"a0913ff5_4740f09e","line":128,"range":{"start_line":128,"start_character":28,"end_line":128,"end_character":35},"updated":"2022-04-27 14:48:22.000000000","message":"remove str(). Objects can be directly formatted into strings in format","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            return ss.SecretDTO(secret_type, data, ss.KeySpec(), None)"},{"line_number":126,"context_line":"        except Exception as e:"},{"line_number":127,"context_line":"            LOG.exception(\"Error retrieving secret {}: {}\".format("},{"line_number":128,"context_line":"                secret_ref, str(e)))"},{"line_number":129,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def store_secret(self, secret_dto):"}],"source_content_type":"text/x-python","patch_set":9,"id":"8f8650d8_3a29c1ea","line":128,"range":{"start_line":128,"start_character":28,"end_line":128,"end_character":35},"in_reply_to":"a0913ff5_4740f09e","updated":"2022-04-28 08:00:58.000000000","message":"Done","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            return self._meta_dict(secret_id)"},{"line_number":142,"context_line":"        except Exception as e:"},{"line_number":143,"context_line":"            LOG.exception(\"Error storing secret: {}\".format("},{"line_number":144,"context_line":"                str(e)))"},{"line_number":145,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def delete_secret(self, secret_metadata):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9c7ab54b_9353ce8a","line":144,"range":{"start_line":144,"start_character":16,"end_line":144,"end_character":23},"updated":"2022-04-27 14:48:22.000000000","message":"ditto","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            return self._meta_dict(secret_id)"},{"line_number":142,"context_line":"        except Exception as e:"},{"line_number":143,"context_line":"            LOG.exception(\"Error storing secret: {}\".format("},{"line_number":144,"context_line":"                str(e)))"},{"line_number":145,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def delete_secret(self, secret_metadata):"}],"source_content_type":"text/x-python","patch_set":9,"id":"a4b1136d_b46f5632","line":144,"range":{"start_line":144,"start_character":16,"end_line":144,"end_character":23},"in_reply_to":"9c7ab54b_9353ce8a","updated":"2022-04-28 08:00:58.000000000","message":"Done","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":true,"context_lines":[{"line_number":155,"context_line":"                secret_ref))"},{"line_number":156,"context_line":"        except Exception as e:"},{"line_number":157,"context_line":"            LOG.exception(\"Error deleting secret: {}\".format("},{"line_number":158,"context_line":"                str(e)))"},{"line_number":159,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def generate_symmetric_key(self, key_spec):"}],"source_content_type":"text/x-python","patch_set":9,"id":"feb2fd3a_ee907a7e","line":158,"range":{"start_line":158,"start_character":16,"end_line":158,"end_character":23},"updated":"2022-04-27 14:48:22.000000000","message":"ditto","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                secret_ref))"},{"line_number":156,"context_line":"        except Exception as e:"},{"line_number":157,"context_line":"            LOG.exception(\"Error deleting secret: {}\".format("},{"line_number":158,"context_line":"                str(e)))"},{"line_number":159,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def generate_symmetric_key(self, key_spec):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae3a917_6f4985d2","line":158,"range":{"start_line":158,"start_character":16,"end_line":158,"end_character":23},"in_reply_to":"feb2fd3a_ee907a7e","updated":"2022-04-28 08:00:58.000000000","message":"Done","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            return self._meta_dict(secret_id)"},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            LOG.exception(\"Error generating symmetric key: {}\".format("},{"line_number":174,"context_line":"                str(e)))"},{"line_number":175,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def generate_asymmetric_key(self, key_spec):"}],"source_content_type":"text/x-python","patch_set":9,"id":"b78316a8_82d68219","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":22},"updated":"2022-04-27 14:48:22.000000000","message":"ditto","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            return self._meta_dict(secret_id)"},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            LOG.exception(\"Error generating symmetric key: {}\".format("},{"line_number":174,"context_line":"                str(e)))"},{"line_number":175,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def generate_asymmetric_key(self, key_spec):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f0816e2_7cc2d2ba","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":22},"in_reply_to":"b78316a8_82d68219","updated":"2022-04-28 08:00:58.000000000","message":"Done","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"540bb8dc099dc832c9c37b002d6c85080a123b32","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            )"},{"line_number":205,"context_line":"        except Exception as e:"},{"line_number":206,"context_line":"            LOG.exception(\"Error generating asymmetric key: {}\".format("},{"line_number":207,"context_line":"                str(e)))"},{"line_number":208,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"fdf41150_0b44b64a","line":207,"range":{"start_line":207,"start_character":16,"end_line":207,"end_character":23},"updated":"2022-04-27 14:48:22.000000000","message":"ditto","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"},{"author":{"_account_id":23266,"name":"lixuehai","email":"li.xuehai@99cloud.net","username":"lixuehai"},"change_message_id":"192e0199f732280f71e5d9d6a6bb1f815502c2b0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            )"},{"line_number":205,"context_line":"        except Exception as e:"},{"line_number":206,"context_line":"            LOG.exception(\"Error generating asymmetric key: {}\".format("},{"line_number":207,"context_line":"                str(e)))"},{"line_number":208,"context_line":"            raise ss.SecretGeneralException(e)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"8a6bed04_3bf577c7","line":207,"range":{"start_line":207,"start_character":16,"end_line":207,"end_character":23},"in_reply_to":"fdf41150_0b44b64a","updated":"2022-04-28 08:00:58.000000000","message":"Done","commit_id":"acfe9aa7d6eec39323c76723c6b836cc6080df11"}]}