)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"3880f13967d4c1afb67b18fb3da3a1431e09cdaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ad8fdb7_fedc8722","updated":"2022-05-06 16:21:20.000000000","message":"recheck - liberasurecode-devel error","commit_id":"bd37ac9b693d0e0dd39bf1d292eee1047a4cc39f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"fd5e528c77834813df71af68d26c42fe54089d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a02342aa_8a34ab62","updated":"2022-05-06 20:44:44.000000000","message":"recheck - liberasurecode-devel error","commit_id":"bd37ac9b693d0e0dd39bf1d292eee1047a4cc39f"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"cb323d5e616016e301b6e4839e89240ec7936757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"12fb1349_16adfed4","updated":"2022-05-06 23:02:18.000000000","message":"recheck - timeout","commit_id":"bd37ac9b693d0e0dd39bf1d292eee1047a4cc39f"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"b8cfe38e6995b840fc9305f768e669130319e3da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2fc93287_0f165bd2","updated":"2022-07-20 19:12:27.000000000","message":"Way cleaner","commit_id":"ff7fef62116bf5e128da1207752fb69a6193e606"}],"barbican/api/controllers/versions.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    \"\"\"Base class for the version-specific controllers\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_version_info_v0(cls, request):"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":94,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b81d1c37_47e00b97","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":40},"updated":"2022-05-11 21:12:56.000000000","message":"this argument is not used in the body of the function.","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    \"\"\"Base class for the version-specific controllers\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_version_info_v0(cls, request):"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":94,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"e0c521e2_7fdf3819","line":91,"range":{"start_line":91,"start_character":33,"end_line":91,"end_character":40},"in_reply_to":"b81d1c37_47e00b97","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @classmethod"},{"line_number":115,"context_line":"    def get_version_info(cls, request):"},{"line_number":116,"context_line":"        return {"},{"line_number":117,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":118,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb75fb75_55b051e7","line":115,"range":{"start_line":115,"start_character":30,"end_line":115,"end_character":37},"updated":"2022-05-11 21:12:56.000000000","message":"this argument is not used in the body of the function.","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @classmethod"},{"line_number":115,"context_line":"    def get_version_info(cls, request):"},{"line_number":116,"context_line":"        return {"},{"line_number":117,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":118,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"989703fe_a660c655","line":115,"range":{"start_line":115,"start_character":30,"end_line":115,"end_character":37},"in_reply_to":"bb75fb75_55b051e7","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":87,"context_line":"class BaseVersionController(object):"},{"line_number":88,"context_line":"    \"\"\"Base class for the version-specific controllers\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_version_info_v0(cls, request):"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":94,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"},{"line_number":95,"context_line":"            \u0027updated\u0027: cls.last_updated,"},{"line_number":96,"context_line":"            \u0027links\u0027: ["},{"line_number":97,"context_line":"                {"},{"line_number":98,"context_line":"                    \u0027rel\u0027: \u0027self\u0027,"},{"line_number":99,"context_line":"                    \u0027href\u0027: _get_versioned_url(cls.version_string),"},{"line_number":100,"context_line":"                }, {"},{"line_number":101,"context_line":"                    \u0027rel\u0027: \u0027describedby\u0027,"},{"line_number":102,"context_line":"                    \u0027type\u0027: \u0027text/html\u0027,"},{"line_number":103,"context_line":"                    \u0027href\u0027: \u0027https://docs.openstack.org/\u0027"},{"line_number":104,"context_line":"                }"},{"line_number":105,"context_line":"            ],"},{"line_number":106,"context_line":"            \u0027media-types\u0027: ["},{"line_number":107,"context_line":"                {"},{"line_number":108,"context_line":"                    \u0027base\u0027: MIME_TYPE_JSON,"},{"line_number":109,"context_line":"                    \u0027type\u0027: MEDIA_TYPE_JSON % cls.version_string"},{"line_number":110,"context_line":"                }"},{"line_number":111,"context_line":"            ]"},{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @classmethod"},{"line_number":115,"context_line":"    def get_version_info(cls, request):"},{"line_number":116,"context_line":"        return {"},{"line_number":117,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":118,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"},{"line_number":119,"context_line":"            \u0027updated\u0027: cls.last_updated,"},{"line_number":120,"context_line":"            \u0027links\u0027: ["},{"line_number":121,"context_line":"                {"},{"line_number":122,"context_line":"                    \u0027rel\u0027: \u0027self\u0027,"},{"line_number":123,"context_line":"                    \u0027href\u0027: _get_versioned_url(cls.version_string),"},{"line_number":124,"context_line":"                }, {"},{"line_number":125,"context_line":"                    \u0027rel\u0027: \u0027describedby\u0027,"},{"line_number":126,"context_line":"                    \u0027type\u0027: \u0027text/html\u0027,"},{"line_number":127,"context_line":"                    \u0027href\u0027: \u0027https://docs.openstack.org/\u0027"},{"line_number":128,"context_line":"                }"},{"line_number":129,"context_line":"            ],"},{"line_number":130,"context_line":"            \u0027max_version\u0027: cls.version,"},{"line_number":131,"context_line":"            \u0027min_version\u0027: cls.min_version,"},{"line_number":132,"context_line":"            \u0027media-types\u0027: ["},{"line_number":133,"context_line":"                {"},{"line_number":134,"context_line":"                    \u0027base\u0027: MIME_TYPE_JSON,"},{"line_number":135,"context_line":"                    \u0027type\u0027: MEDIA_TYPE_JSON % cls.version_string"},{"line_number":136,"context_line":"                }"},{"line_number":137,"context_line":"            ]"},{"line_number":138,"context_line":"        }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class V1Controller(BaseVersionController):"}],"source_content_type":"text/x-python","patch_set":5,"id":"799eb519_3509fa72","line":138,"range":{"start_line":90,"start_character":0,"end_line":138,"end_character":9},"updated":"2022-05-11 21:12:56.000000000","message":"I think this would be better as a single method that takes a version parameter.  That way we don\u0027t have to repeat the entire body in both functions. Instead we can just add the max and min if the version is \u003e 1.0.","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"class BaseVersionController(object):"},{"line_number":88,"context_line":"    \"\"\"Base class for the version-specific controllers\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @classmethod"},{"line_number":91,"context_line":"    def get_version_info_v0(cls, request):"},{"line_number":92,"context_line":"        return {"},{"line_number":93,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":94,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"},{"line_number":95,"context_line":"            \u0027updated\u0027: cls.last_updated,"},{"line_number":96,"context_line":"            \u0027links\u0027: ["},{"line_number":97,"context_line":"                {"},{"line_number":98,"context_line":"                    \u0027rel\u0027: \u0027self\u0027,"},{"line_number":99,"context_line":"                    \u0027href\u0027: _get_versioned_url(cls.version_string),"},{"line_number":100,"context_line":"                }, {"},{"line_number":101,"context_line":"                    \u0027rel\u0027: \u0027describedby\u0027,"},{"line_number":102,"context_line":"                    \u0027type\u0027: \u0027text/html\u0027,"},{"line_number":103,"context_line":"                    \u0027href\u0027: \u0027https://docs.openstack.org/\u0027"},{"line_number":104,"context_line":"                }"},{"line_number":105,"context_line":"            ],"},{"line_number":106,"context_line":"            \u0027media-types\u0027: ["},{"line_number":107,"context_line":"                {"},{"line_number":108,"context_line":"                    \u0027base\u0027: MIME_TYPE_JSON,"},{"line_number":109,"context_line":"                    \u0027type\u0027: MEDIA_TYPE_JSON % cls.version_string"},{"line_number":110,"context_line":"                }"},{"line_number":111,"context_line":"            ]"},{"line_number":112,"context_line":"        }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @classmethod"},{"line_number":115,"context_line":"    def get_version_info(cls, request):"},{"line_number":116,"context_line":"        return {"},{"line_number":117,"context_line":"            \u0027id\u0027: cls.version_id,"},{"line_number":118,"context_line":"            \u0027status\u0027: \u0027stable\u0027,"},{"line_number":119,"context_line":"            \u0027updated\u0027: cls.last_updated,"},{"line_number":120,"context_line":"            \u0027links\u0027: ["},{"line_number":121,"context_line":"                {"},{"line_number":122,"context_line":"                    \u0027rel\u0027: \u0027self\u0027,"},{"line_number":123,"context_line":"                    \u0027href\u0027: _get_versioned_url(cls.version_string),"},{"line_number":124,"context_line":"                }, {"},{"line_number":125,"context_line":"                    \u0027rel\u0027: \u0027describedby\u0027,"},{"line_number":126,"context_line":"                    \u0027type\u0027: \u0027text/html\u0027,"},{"line_number":127,"context_line":"                    \u0027href\u0027: \u0027https://docs.openstack.org/\u0027"},{"line_number":128,"context_line":"                }"},{"line_number":129,"context_line":"            ],"},{"line_number":130,"context_line":"            \u0027max_version\u0027: cls.version,"},{"line_number":131,"context_line":"            \u0027min_version\u0027: cls.min_version,"},{"line_number":132,"context_line":"            \u0027media-types\u0027: ["},{"line_number":133,"context_line":"                {"},{"line_number":134,"context_line":"                    \u0027base\u0027: MIME_TYPE_JSON,"},{"line_number":135,"context_line":"                    \u0027type\u0027: MEDIA_TYPE_JSON % cls.version_string"},{"line_number":136,"context_line":"                }"},{"line_number":137,"context_line":"            ]"},{"line_number":138,"context_line":"        }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class V1Controller(BaseVersionController):"}],"source_content_type":"text/x-python","patch_set":5,"id":"595b54f4_639054e4","line":138,"range":{"start_line":90,"start_character":0,"end_line":138,"end_character":9},"in_reply_to":"799eb519_3509fa72","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    @controllers.handle_exceptions(u._(\u0027Version retrieval\u0027))"},{"line_number":171,"context_line":"    def on_get(self):"},{"line_number":172,"context_line":"        pecan.core.override_template(\u0027json\u0027)"},{"line_number":173,"context_line":"        if is_supported(pecan.request, max_version\u003d\u00271.0\u0027):"},{"line_number":174,"context_line":"            return {\u0027version\u0027: self.get_version_info_v0(pecan.request)}"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            return {\u0027version\u0027: self.get_version_info(pecan.request)}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"AVAILABLE_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"31b00d7a_03f8ccae","line":176,"range":{"start_line":173,"start_character":8,"end_line":176,"end_character":68},"updated":"2022-05-11 21:12:56.000000000","message":"This could be a single return if we refactor the two methods into one:\n\n    return {\u0027version\u0027: self.get_version_info(\n        pecan.request.environ.get(\u0027key-manager.microversion\u0027, MIN_API_VERSION)\n    )}","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    @controllers.handle_exceptions(u._(\u0027Version retrieval\u0027))"},{"line_number":171,"context_line":"    def on_get(self):"},{"line_number":172,"context_line":"        pecan.core.override_template(\u0027json\u0027)"},{"line_number":173,"context_line":"        if is_supported(pecan.request, max_version\u003d\u00271.0\u0027):"},{"line_number":174,"context_line":"            return {\u0027version\u0027: self.get_version_info_v0(pecan.request)}"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            return {\u0027version\u0027: self.get_version_info(pecan.request)}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"AVAILABLE_VERSIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"14fa7147_dc398ea0","line":176,"range":{"start_line":173,"start_character":8,"end_line":176,"end_character":68},"in_reply_to":"31b00d7a_03f8ccae","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"}],"barbican/tests/api/controllers/test_versions.py":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        resp \u003d self.app.get(\u0027/\u0027, headers\u003dheaders)"},{"line_number":39,"context_line":"        self.assertEqual(302, resp.status_int)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_should_return_version_json_v0(self):"},{"line_number":42,"context_line":"        # NOTE: this is for clients that do not have the microversion set"},{"line_number":43,"context_line":"        # which should default to the old-pre-microversion behavior"},{"line_number":44,"context_line":"        resp \u003d self.app.get(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"cffb591c_56824e34","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":42},"updated":"2022-05-11 21:12:56.000000000","message":"Nit:  It might be clearer here to use v1_0","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        resp \u003d self.app.get(\u0027/\u0027, headers\u003dheaders)"},{"line_number":39,"context_line":"        self.assertEqual(302, resp.status_int)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_should_return_version_json_v0(self):"},{"line_number":42,"context_line":"        # NOTE: this is for clients that do not have the microversion set"},{"line_number":43,"context_line":"        # which should default to the old-pre-microversion behavior"},{"line_number":44,"context_line":"        resp \u003d self.app.get(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"59d7bf71_b5de6f71","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":42},"in_reply_to":"cffb591c_56824e34","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(1, len(v1_info[\u0027media-types\u0027]))"},{"line_number":56,"context_line":"        self.assertEqual(\u0027application/json\u0027, v1_info[\u0027media-types\u0027][0][\u0027base\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_should_return_version_json_v1(self):"},{"line_number":59,"context_line":"        utils.set_version(self.app, \u00271.1\u0027)"},{"line_number":60,"context_line":"        resp \u003d self.app.get(\u0027/\u0027)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"57705ac3_3eeee73c","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":42},"updated":"2022-05-11 21:12:56.000000000","message":"Nit: same, I think it would be better to use v1_1","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(1, len(v1_info[\u0027media-types\u0027]))"},{"line_number":56,"context_line":"        self.assertEqual(\u0027application/json\u0027, v1_info[\u0027media-types\u0027][0][\u0027base\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_should_return_version_json_v1(self):"},{"line_number":59,"context_line":"        utils.set_version(self.app, \u00271.1\u0027)"},{"line_number":60,"context_line":"        resp \u003d self.app.get(\u0027/\u0027)"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"884cf7bc_8320d4b9","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":42},"in_reply_to":"57705ac3_3eeee73c","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"b10fbd081820b34a71dacaf1c7a0a2589999c0ae","unresolved":true,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        v1_info \u003d resp.json[\u0027version\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # NOTE(jaosorior): I used assertIn instead of assertEqual because we"},{"line_number":240,"context_line":"        # might start using decimal numbers in the future. So when that happens"},{"line_number":241,"context_line":"        # this test will still be valid."},{"line_number":242,"context_line":"        self.assertIn(\u0027v1\u0027, v1_info[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"22ca6801_4f386c9f","line":239,"range":{"start_line":239,"start_character":15,"end_line":239,"end_character":24},"updated":"2022-05-11 21:12:56.000000000","message":"that\u0027s not you. 😜  I\u0027m also not sure this note is still needed?","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"6aae72ae61273f28dd0576e1e8452b6b00e1c5d3","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        v1_info \u003d resp.json[\u0027version\u0027]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # NOTE(jaosorior): I used assertIn instead of assertEqual because we"},{"line_number":240,"context_line":"        # might start using decimal numbers in the future. So when that happens"},{"line_number":241,"context_line":"        # this test will still be valid."},{"line_number":242,"context_line":"        self.assertIn(\u0027v1\u0027, v1_info[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"66f35d3e_0b00c820","line":239,"range":{"start_line":239,"start_character":15,"end_line":239,"end_character":24},"in_reply_to":"22ca6801_4f386c9f","updated":"2022-07-20 19:02:47.000000000","message":"Done","commit_id":"6940fe193f0ff9bcd7a8b58569a0a20e64307a06"}]}