)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"637b4367af9be2532d0e2b4dc443ab196cffd044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41dc988c_7c909759","updated":"2023-05-30 12:12:48.000000000","message":"recheck","commit_id":"efe00a7524243c58a04d3f27fc0e3f614f2bca46"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"8efb08bad6abce0a3ab86878e9eee16728610728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edb06bed_436480d4","updated":"2023-05-25 15:27:33.000000000","message":"recheck","commit_id":"efe00a7524243c58a04d3f27fc0e3f614f2bca46"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"19e3cf3e7aa2dac25f9869c36f4dc428d66e8a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0492121b_51d4827c","updated":"2023-06-06 10:52:04.000000000","message":"recheck","commit_id":"33282332c0d867539f12445607a07dcbf196bec2"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"a703c24b0b216a5dcc15dd1c7eb6bae894630ad6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7facac2_7c63037d","updated":"2023-06-06 15:03:49.000000000","message":"recheck","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"1987635d75b96916841923dbec37d2729e5ab9d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bd9a331f_1e4ed980","updated":"2023-06-07 17:39:45.000000000","message":"recheck","commit_id":"57d7ff378a497af361c7597f2958f6cd4c0ce25b"}],"barbican/common/policies/secrets.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c3f5152fb25c9fa25e80bdfd55247e23754577a3","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        name\u003d\u0027secret:get\u0027,"},{"line_number":84,"context_line":"        check_str\u003d("},{"line_number":85,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":86,"context_line":"            \"(role:admin or \""},{"line_number":87,"context_line":"            \"(rule:secret_project_admin or \""},{"line_number":88,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":89,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private) or \""},{"line_number":90,"context_line":"            \"rule:secret_acl_read))\"),"},{"line_number":91,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":92,"context_line":"        description\u003d\u0027Retrieves a secrets metadata.\u0027,"},{"line_number":93,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":6,"id":"bf08f577_2a270c95","line":90,"range":{"start_line":86,"start_character":6,"end_line":90,"end_character":38},"updated":"2023-06-06 15:18:35.000000000","message":"This seems unnecessarily confusing .. instead of:\n\n        check_str\u003d(\n            \"True:%(enforce_new_defaults)s and \"\n            \"(role:admin or \"\n            \"(rule:secret_project_admin or \"\n            \"(rule:secret_project_member and rule:secret_owner) or \"\n            \"(rule:secret_project_member and rule:secret_is_not_private) or \"\n            \"rule:secret_acl_read))\"),\n\n\nhow about:\n\n        check_str\u003d(\n            \"True:%(enforce_new_defaults)s and \"\n            \"(role:admin or \"\n            \"rule:secret_project_admin or \"\n            \"(rule:secret_project_member and rule:secret_owner) or \"\n            \"(rule:secret_project_member and rule:secret_is_not_private) or \"\n            \"rule:secret_acl_read)\"),","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"3e0eeb3c64b99c7a6c4bd2a859a21fcedd768baf","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        name\u003d\u0027secret:get\u0027,"},{"line_number":84,"context_line":"        check_str\u003d("},{"line_number":85,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":86,"context_line":"            \"(role:admin or \""},{"line_number":87,"context_line":"            \"(rule:secret_project_admin or \""},{"line_number":88,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":89,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private) or \""},{"line_number":90,"context_line":"            \"rule:secret_acl_read))\"),"},{"line_number":91,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":92,"context_line":"        description\u003d\u0027Retrieves a secrets metadata.\u0027,"},{"line_number":93,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":6,"id":"534cc896_e59ddb58","line":90,"range":{"start_line":86,"start_character":6,"end_line":90,"end_character":38},"in_reply_to":"5bae1c49_df38b0e5","updated":"2023-06-07 11:22:25.000000000","message":"Done","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"b2f24ee3e5a6b02038617b7aba88e7c2317f721e","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        name\u003d\u0027secret:get\u0027,"},{"line_number":84,"context_line":"        check_str\u003d("},{"line_number":85,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":86,"context_line":"            \"(role:admin or \""},{"line_number":87,"context_line":"            \"(rule:secret_project_admin or \""},{"line_number":88,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":89,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private) or \""},{"line_number":90,"context_line":"            \"rule:secret_acl_read))\"),"},{"line_number":91,"context_line":"        scope_types\u003d[\u0027project\u0027],"},{"line_number":92,"context_line":"        description\u003d\u0027Retrieves a secrets metadata.\u0027,"},{"line_number":93,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":6,"id":"5bae1c49_df38b0e5","line":90,"range":{"start_line":86,"start_character":6,"end_line":90,"end_character":38},"in_reply_to":"bf08f577_2a270c95","updated":"2023-06-06 16:00:02.000000000","message":"Supposing the logic will work likewise, I don\u0027t see a problem of removing the brackets.","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"c3f5152fb25c9fa25e80bdfd55247e23754577a3","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        name\u003d\u0027secret:delete\u0027,"},{"line_number":120,"context_line":"        check_str\u003d("},{"line_number":121,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":122,"context_line":"            \"(role:admin or \""},{"line_number":123,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":124,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private))\"),"},{"line_number":125,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"2b326f3e_47adfa51","line":122,"range":{"start_line":122,"start_character":5,"end_line":122,"end_character":29},"updated":"2023-06-06 15:18:35.000000000","message":"I\u0027m confused -- in the above change for secret_get , you add role:admin and also rule:secret_project_admin, but here you replace?\n\nSo which is it?","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"b2f24ee3e5a6b02038617b7aba88e7c2317f721e","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        name\u003d\u0027secret:delete\u0027,"},{"line_number":120,"context_line":"        check_str\u003d("},{"line_number":121,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":122,"context_line":"            \"(role:admin or \""},{"line_number":123,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":124,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private))\"),"},{"line_number":125,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"364fab9d_95702fc3","line":122,"range":{"start_line":122,"start_character":5,"end_line":122,"end_character":29},"in_reply_to":"2b326f3e_47adfa51","updated":"2023-06-06 16:00:02.000000000","message":"This was done by mistake and will be fixed on the next patchset.","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"3e0eeb3c64b99c7a6c4bd2a859a21fcedd768baf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        name\u003d\u0027secret:delete\u0027,"},{"line_number":120,"context_line":"        check_str\u003d("},{"line_number":121,"context_line":"            \"True:%(enforce_new_defaults)s and \""},{"line_number":122,"context_line":"            \"(role:admin or \""},{"line_number":123,"context_line":"            \"(rule:secret_project_member and rule:secret_owner) or \""},{"line_number":124,"context_line":"            \"(rule:secret_project_member and rule:secret_is_not_private))\"),"},{"line_number":125,"context_line":"        scope_types\u003d[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"03d49036_1227250c","line":122,"range":{"start_line":122,"start_character":5,"end_line":122,"end_character":29},"in_reply_to":"364fab9d_95702fc3","updated":"2023-06-07 11:22:25.000000000","message":"Done","commit_id":"3a3f3c83e8edede6882ec53023b1192f7a050e27"}]}