)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9727cd36e11af8b22a68e8d8fde4945185ad8a4a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-07 13:39:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add pyproject.toml and wsgi module paths"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This copies a fix from the Watcher project to support pip 23.1:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6eeafdff_51cd104c","line":7,"updated":"2025-05-07 22:07:53.000000000","message":"yes so this does two things\n\nthe pyproject.toml file turns back on pbr when building the package.\n\nThat means that for release packages i.e. not editable mode the wsgi_script should still be created as they were in the past and the other autogenerate content like the authors file and version number metadata, will be available in whiles built via python -m build wheel ectra\n\nThis is basically just the first part of https://packaging.python.org/en/latest/guides/modernize-setup-py-project/\n\n\nThe second thing it does is complete https://github.com/openstack/governance/blob/master/goals/proposed/migrate-from-wsgi-scripts-to-module-paths.rst for barbican.\n\nEventually we want to remove the depency on pbr to provide the wsgi script\n\nso instead of runing `/usr/bin/barbican-wsgi-api` via appace you can update it to \n\n`/usr/lib/python3/dist-packages/barbican/wsgi/api.py`\n\nwhich does not depend on the pbr extension at all.\n\nTo make the greade job pass assuming there are no other preexisitng issues with the job you can either backport this patch (it a fully backward compatable change so this is what i recommend) or you can modify the greade plugin to handel reconfiguring uwsgi to handel the changes over upgrade.\n\nin theroy thats doable but its more work and has little added value so i would jsut backprot this to epoxy.\n\nwe dont need this on oder release as epoxy is the only release we need to supprot based on the SLURP cadance.","commit_id":"d98891faee8c6adf85f85ae006ccb903999cb7c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4cb8495934ca8590361dd4104e1fe2c8d2b1efdc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-07 13:39:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add pyproject.toml and wsgi module paths"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This copies a fix from the Watcher project to support pip 23.1:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d50df65b_38c4264c","line":7,"in_reply_to":"6eeafdff_51cd104c","updated":"2025-05-07 23:25:11.000000000","message":"Thanks for explaining the details, it answers some things I had not understood before.\n\nI proposed a backport here but I note it\u0027s failing `openstack-tox-cover` and I don\u0027t understand how it didn\u0027t fail on master but it does fail on stable/2025.1:\n\nhttps://review.opendev.org/c/openstack/barbican/+/949096","commit_id":"d98891faee8c6adf85f85ae006ccb903999cb7c8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"50144c080d593640a88dd506c38ad43cdef12da1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe395c34_c352fa6d","updated":"2025-05-07 01:55:10.000000000","message":"Not sure if I\u0027ve missed something with regard to the `barbican-grenade` job failure ...","commit_id":"be06031e259d13dea5ec1178f24f1f91d9842ec3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bedebb87d7a0d3f97d10566d4a3c6d45fe4e471a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b03b6af6_539bc1f3","in_reply_to":"fe395c34_c352fa6d","updated":"2025-05-07 01:58:49.000000000","message":"```\n2025-05-07 01:24:01.694319 | controller | May 07 01:23:44 np0040669012 devstack@barbican-svc.service[90409]: failed to open python file /opt/stack/data/venv/bin/barbican-wsgi-api\n2025-05-07 01:24:01.694361 | controller | May 07 01:23:44 np0040669012 devstack@barbican-svc.service[90409]: unable to load app 0 (mountpoint\u003d\u0027\u0027) (callable not found or import error)\n```\nCould it mean that it\u0027s the old side of the grenade upgrade that\u0027s failing? I had thought it should work being that there was no issue with the prior version of barbican. But maybe it\u0027s using new pip for the old side too or something?","commit_id":"be06031e259d13dea5ec1178f24f1f91d9842ec3"}],"barbican/wsgi/api.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"fd8a4b5af25c16eeb46daa8513bc507787125aa9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"WSGI application entry-point for Watcher API.\"\"\""},{"line_number":14,"context_line":"import threading"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from barbican.api import app"}],"source_content_type":"text/x-python","patch_set":3,"id":"2f095d6b_d9095da6","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":48},"updated":"2025-05-07 20:36:25.000000000","message":"nit ..","commit_id":"be06031e259d13dea5ec1178f24f1f91d9842ec3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6a5228a6b2bffbe64ed602007194a018e871e960","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"WSGI application entry-point for Watcher API.\"\"\""},{"line_number":14,"context_line":"import threading"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from barbican.api import app"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1b976f8_4e46f73c","line":13,"range":{"start_line":13,"start_character":36,"end_line":13,"end_character":48},"in_reply_to":"2f095d6b_d9095da6","updated":"2025-05-07 20:40:04.000000000","message":"Oops, sorry about that. Fixed.","commit_id":"be06031e259d13dea5ec1178f24f1f91d9842ec3"}],"setup.cfg":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a307a34fe66454d7b8d4f5a40a45f171e87953df","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.10"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.12"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"95e112ec_6405f747","side":"PARENT","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":41},"updated":"2025-05-07 06:31:53.000000000","message":"This is not hard -1 but I wonder if we should also bump python_requires ?\n\nNote that we might need to avoid the bump until we completely replace c9s, to keep test coverage of FIPs.","commit_id":"9f1f1c66a841ab8150e8c1c1bdb529f190086c2f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9727cd36e11af8b22a68e8d8fde4945185ad8a4a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.10"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.12"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"b0faae1c_e1c3692f","side":"PARENT","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":41},"in_reply_to":"1f8e57ca_399ed732","updated":"2025-05-07 22:07:53.000000000","message":"so this actully does noting it just for humans when searchign for packages\ni didnt bump it because i wanted to hold of droping 3.9 supprot for a little longer\n\nso i was going to update the clasiffers when we updated `python_requires \u003d \u003e\u003d3.9` to \n`python_requires \u003d \u003e\u003d3.10`\n\nwe have a third-party job that uses our new operator-based installer to deploy watcher that repores on every change to watcher. we are still in the prcoess of moving that to centos 10 and py 3.12\n\nthat does not install the latest packages form pypi using upper-cosntarits to build\nits effectly using pinned veriosn of oslo ectra form rdo master which is more or less expoy deps currently.\n\nhttps://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/41868156c2fe40cf93becafc848b88a0\n\nSo we will bump the min version to 3.10 in the packaging before m3 i just wanted to give people a couple more weeks to get that new job working.\n\nso no nothing to do with fips.\nits because we dont have centos 10 master contaienr build working yet and we will have that hopefully before the end of may. the buidls are actully working but we are waitign for the quay.io registry ot be created and some other infra work to start usign it for third-party ci.\n\n\nfips is probably more relevant to Barbican it does not really impact watcher provided you can run it on a fips ensbled host.","commit_id":"9f1f1c66a841ab8150e8c1c1bdb529f190086c2f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"62c2cb037483d1c8cc890ff42f5c46eed2503d44","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.10"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.12"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1f8e57ca_399ed732","side":"PARENT","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":41},"in_reply_to":"95e112ec_6405f747","updated":"2025-05-07 17:24:19.000000000","message":"I wondered the same thing and noticed @smooney@redhat.com did not bump it in their patch and left a comment \"bump to \u003e\u003d 3.10 before m3\":\n\nhttps://review.opendev.org/c/openstack/watcher/+/948438/8/setup.cfg#9\n\nSean, is the above about python_requires because of FIPS and do you know what is the criteria for being able to bump it later before M3?","commit_id":"9f1f1c66a841ab8150e8c1c1bdb529f190086c2f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4cb8495934ca8590361dd4104e1fe2c8d2b1efdc","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.10"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.11"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.12"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1ac67b92_dbcac6c9","side":"PARENT","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":41},"in_reply_to":"b0faae1c_e1c3692f","updated":"2025-05-07 23:25:11.000000000","message":"Thanks for explaining that!","commit_id":"9f1f1c66a841ab8150e8c1c1bdb529f190086c2f"}]}