)]}'
{"id":"openstack%2Fbarbican~950628","triplet_id":"openstack%2Fbarbican~master~Ida6a831baff127212fed14958e464847edb5e1b8","project":"openstack/barbican","branch":"master","attention_set":{},"removed_from_attention_set":{"7973":{"account":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"last_update":"2025-05-22 20:29:53.000000000","reason":"\u003cGERRIT_ACCOUNT_7973\u003e replied on the change","reason_account":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"}},"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2025-09-19 14:10:40.000000000","reason":"\u003cGERRIT_ACCOUNT_14250\u003e replied on the change","reason_account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},"27900":{"account":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"last_update":"2025-09-19 14:53:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ida6a831baff127212fed14958e464847edb5e1b8","subject":"Fix href construction when base url ends with slash","status":"MERGED","created":"2025-05-22 08:29:18.000000000","updated":"2025-09-19 14:54:40.000000000","submitted":"2025-09-19 14:53:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"950628","meta_rev_id":"522d9c722bfd64508e69a1e8286cbf9623f562b4","_number":950628,"virtual_id_number":950628,"owner":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-09-19 14:53:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"all":[{"value":2,"date":"2025-05-22 20:29:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":2,"date":"2025-09-19 14:10:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"all":[{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2025-09-19 14:10:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-22 09:30:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-05-22 15:01:16.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"state":"REVIEWER"},{"updated":"2025-05-22 15:01:16.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"}],"messages":[{"id":"e2f0ccd7730fdb6bf9a2ad8a1649f982765bd619","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2025-05-22 08:29:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96a01fe4f3fb4e832fb6817898eb7b9f8907ab60","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2025-05-22 08:30:07.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"8647e0b5a4c61f71f212387f84cf28edd29e4e60","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-05-22 09:30:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d96b2cc9fee04e7d9ee157b75a4927fe\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b227838fa730447b9d6801b7f3f6c839 : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6dd79cd3bea64d0b912aaad0b21e02cf : SUCCESS in 3m 35s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e14545a836b2424099b253ac98dbff60 : SUCCESS in 4m 17s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/0eb58fcfbc3c45a7ae3ef9591b828e59 : SUCCESS in 5m 02s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/3ff9142022494e57a23f5c3c22268577 : SUCCESS in 4m 16s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b467697c9cb14355922a6c9ff0a706e9 : SUCCESS in 7m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9f1bbc8fd81c4e619ec18fafa99edfe9 : SUCCESS in 3m 33s\n- barbican-tox-functional https://zuul.opendev.org/t/openstack/build/c1460aa44b244011bdde3164ea667a47 : SUCCESS in 29m 52s\n- barbican-vault-tox-functional https://zuul.opendev.org/t/openstack/build/75f68e427e274b2fb87569b04be588b8 : SUCCESS in 31m 26s (non-voting)\n- barbican-grenade https://zuul.opendev.org/t/openstack/build/9ea74f871e26407a8fc7d679115eb7ee : FAILURE in 38m 20s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/00ad2a428ed04dd699bc3c05251108d6 : SUCCESS in 23m 42s\n- barbican-tempest-plugin-simple-crypto-jammy https://zuul.opendev.org/t/openstack/build/8a943901e24142179b9155ac4206bce0 : SUCCESS in 23m 11s\n- barbican-tempest-plugin-simple-crypto-secure-rbac https://zuul.opendev.org/t/openstack/build/dc10f9adfbb84494b322cfd8fe9bb40f : SUCCESS in 35m 47s\n- barbican-tempest-plugin-simple-crypto-ipv6-only https://zuul.opendev.org/t/openstack/build/2b465c321ee64af2a72133794deb77ac : SUCCESS in 26m 47s\n- barbican-tox-functional-fips https://zuul.opendev.org/t/openstack/build/4be35738e0ba4f54a943a9f9553d4126 : POST_FAILURE in 13m 47s (non-voting)\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/8cccb4ed46c04a35b0a00b2d8c2cbded : SUCCESS in 58m 20s\n- octavia-v2-dsvm-tls-barbican-secure-rbac https://zuul.opendev.org/t/openstack/build/94a35d78374b467d91a1d87ceca89c23 : SUCCESS in 48m 51s","accounts_in_message":[],"_revision_number":2},{"id":"4ead40cc497d343c1053a8cb96f116cbd6ebaf6d","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2025-05-22 20:29:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"19ca135757364ba56df6c3ece343dae6698d82a4","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2025-09-19 14:10:40.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9ce1e3ef94b2fdd890c954beae59d509ecc44c69","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-19 14:11:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"aae25628fbc90a429be2045ef06232627a7de637","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-19 14:53:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/045a1d6f144e465081c2e51d984c437a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2f0c72ce9c1e40458701168d1f9d4bfe : SUCCESS in 5m 59s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/ca4997f444d545a296d26603d2199592 : SUCCESS in 6m 42s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/caa9c3427fc244dcbe1bb176d3a7c2a2 : SUCCESS in 7m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2abc212a65df437f8df78926d67b923e : SUCCESS in 7m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ce0c56c53e1143d097277f1a80bfee08 : SUCCESS in 4m 26s\n- barbican-tox-functional https://zuul.opendev.org/t/openstack/build/f7a83c08d41c46168972bf96baaf7a76 : SUCCESS in 36m 07s","accounts_in_message":[],"_revision_number":2},{"id":"e52fcbf47c9e585afa97d2adc45d969bc6c1d0d7","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-19 14:53:42.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"522d9c722bfd64508e69a1e8286cbf9623f562b4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-19 14:54:40.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c868b84555224cfba3ffb19e178bcefa\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/02f5b85b7b7a4d60897f9df2f2be1e4d : SUCCESS in 42s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b21f047efedf43d5b88c3ca78e69b51f : SUCCESS in 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"264128d44d4ec46658f00d49f3a5a5ef22cca99c","revisions":{"9006c8a4f33bf9bf700cb51c72717e8f651f1714":{"kind":"REWORK","_number":1,"created":"2025-05-22 08:29:18.000000000","uploader":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"ref":"refs/changes/28/950628/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/barbican","ref":"refs/changes/28/950628/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/barbican refs/changes/28/950628/1"}}},"commit":{"parents":[{"commit":"55c758eb7c119d043a3b1365f4864308e60dd978","subject":"Merge \"Remove unused versionbuild script\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/55c758eb7c119d043a3b1365f4864308e60dd978"}]}],"author":{"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","date":"2025-05-22 08:00:32.000000000","tz":120},"committer":{"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","date":"2025-05-22 08:28:20.000000000","tz":120},"subject":"Fix href construction when base url ends with slash","message":"Fix href construction when base url ends with slash\n\nUnder certain deployment conditions the `pecan.request.application_url`\nmay end with the slash (perhaps when wsgi SCIPT_NAME is set to \"/\"). And\nso the url may look like `http://API.DOMAIN//v1/secrets/HASH`. In any\nway it is reasonable to ensure base does not end with \"/\" before we use\nit for concatenation.\n\nChange-Id: Ida6a831baff127212fed14958e464847edb5e1b8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/9006c8a4f33bf9bf700cb51c72717e8f651f1714"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/9006c8a4f33bf9bf700cb51c72717e8f651f1714"}]},"branch":"refs/heads/master"},"264128d44d4ec46658f00d49f3a5a5ef22cca99c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-05-22 08:30:07.000000000","uploader":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"ref":"refs/changes/28/950628/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/barbican","ref":"refs/changes/28/950628/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/barbican refs/changes/28/950628/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/barbican refs/changes/28/950628/2"}}},"commit":{"parents":[{"commit":"55c758eb7c119d043a3b1365f4864308e60dd978","subject":"Merge \"Remove unused versionbuild script\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/55c758eb7c119d043a3b1365f4864308e60dd978"}]}],"author":{"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","date":"2025-05-22 08:00:32.000000000","tz":120},"committer":{"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","date":"2025-05-22 08:29:47.000000000","tz":120},"subject":"Fix href construction when base url ends with slash","message":"Fix href construction when base url ends with slash\n\nUnder certain deployment conditions the `pecan.request.application_url`\nmay end with the slash (perhaps when wsgi SCRIPT_NAME is set to \"/\").\nAnd so the url may look like `http://API.DOMAIN//v1/secrets/HASH`. In\nany way it is reasonable to ensure base does not end with \"/\" before we\nuse it for concatenation.\n\nChange-Id: Ida6a831baff127212fed14958e464847edb5e1b8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/264128d44d4ec46658f00d49f3a5a5ef22cca99c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/barbican/commit/264128d44d4ec46658f00d49f3a5a5ef22cca99c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
