)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2f74fde93d288f1a2fb736802abdb4e44e745eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0ffd288_16dec2bb","updated":"2025-08-13 11:14:19.000000000","message":"for some reason VAULT_PLUGIN_BACKEND does not get passed to the job correctly to openbao is not installed, need to find out why\n\n```\n2025-08-13 09:06:19.710739 | controller | ++ /opt/stack/barbican/devstack/plugin.sh:source:22 :   echo_summary \u0027Installing Vault backend\u0027\n2025-08-13 09:06:19.714245 | controller | ++ ./stack.sh:echo_summary:468              :   [[ -t 3 ]]\n2025-08-13 09:06:19.717570 | controller | ++ ./stack.sh:echo_summary:474              :   echo -e Installing Vault backend\n2025-08-13 09:06:19.721490 | controller | ++ /opt/stack/barbican/devstack/plugin.sh:source:23 :   install_vault_backend\n2025-08-13 09:06:19.725028 | controller | ++ /opt/stack/barbican/devstack/lib/barbican:install_vault_backend:588 :   [[ \u0027\u0027 \u003d\u003d \\o\\p\\e\\n\\b\\a\\o ]]\n```","commit_id":"ff24ef1d1c447bb9b4512c192832d1320bf322ff"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"7a8eec65a83a92f5d966d528d26993927bb59255","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16c92703_78a32bba","updated":"2026-03-27 11:16:29.000000000","message":"Thanks for this patch, the approach looks good and CI is green.\n\nOne thing I noticed: there are mixed tabs and spaces in the new code in devstack/lib/barbican. The existing code uses 4-space indentation, but several new lines use tabs (e.g., the if/else block in the cleanup function, the echo lines in _install_hashicorp_vault, and the VAULT_COMMAND\u003d assignments in install_vault_backend). The same happens in tox.ini. Would be good to fix for consistency.\n\nMinor nit: the logic to determine VAULT_COMMAND based on VAULT_PLUGIN_BACKEND is duplicated in both the cleanup section and install_vault_backend. Could be consolidated into a small helper function or set once at a higher scope.","commit_id":"29ae908c0f9cd646ad76acacf3f26394da240abf"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"64e9025ceb1d4d6c395cffc9f7a7042ae6fabfc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e29ce09_0785b047","in_reply_to":"16c92703_78a32bba","updated":"2026-03-30 12:24:20.000000000","message":"Thanks! I\u0027ve cleaned it up further and converted all tabs to 4-space indentation. Let me know what you think.","commit_id":"29ae908c0f9cd646ad76acacf3f26394da240abf"}]}