)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"ded4f1e3ffbc0464eac2e2279aa695ff9f82c171","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66a9c11b_43eeee8f","updated":"2026-01-26 12:02:11.000000000","message":"Thanks!","commit_id":"921242c19d56eec210645b608fbb5f4c3ffc34d4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7a71d933a1fbd202ca5fe0183a9a81ec85746c5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7debce80_def6ee23","updated":"2026-01-30 09:51:00.000000000","message":"Thanks for the review @xek@redhat.com – I\u0027ve updated the microversion history documentation that was missed.","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"595d3e13ae0ffa1759ed4d5470cb2ecbd009b81f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b2a28880_ab056674","updated":"2026-03-27 11:47:24.000000000","message":"Thanks for this patch, the microversion approach is the right way to introduce this behaviour change. The tests cover the key scenarios well.\n\nI\u0027ve added one minor inline comment about the force parameter check.\n\nAlso, it would be good to have a Tempest test for the new microversion behaviour (reject delete with consumers, allow with ?force) in a follow-up patch to validate the end-to-end flow.","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6552a483d085cc398dc54a21a52bddfbf79b8ac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"03ca9d66_b609533a","in_reply_to":"b2a28880_ab056674","updated":"2026-03-30 13:26:00.000000000","message":"Done, I can look into adding Tempest tests as a follow-up.","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0be11ef6aa29de9f01a7276faf9fc250489dbb3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5d922f27_c1dc218f","updated":"2026-03-30 13:25:00.000000000","message":"Thanks! I\u0027ve updated the patch according to your feedback, let me know what you think. I updated the microversion history documentation to instead say the Hibiscus release as Gazpacho is released in 1-2 days this will not realistically be merged before that.","commit_id":"9f28ddb9248cbdeed74d85caf42f331bcd35787f"}],"api-guide/source/secrets.rst":[{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"595d3e13ae0ffa1759ed4d5470cb2ecbd009b81f","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Starting with microversion 1.2 deleting a secret that has secret consumers"},{"line_number":144,"context_line":"registered will result in 400 Bad Request and the secret consumers must be"},{"line_number":145,"context_line":"deleted before deleting the secret. This can be overriden by passing the"},{"line_number":146,"context_line":"``force`` query parameter in the URL."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a2b1ab93_a6f6a6d5","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":57},"updated":"2026-03-27 11:47:24.000000000","message":"Typo:  overridden","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0be11ef6aa29de9f01a7276faf9fc250489dbb3c","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Starting with microversion 1.2 deleting a secret that has secret consumers"},{"line_number":144,"context_line":"registered will result in 400 Bad Request and the secret consumers must be"},{"line_number":145,"context_line":"deleted before deleting the secret. This can be overriden by passing the"},{"line_number":146,"context_line":"``force`` query parameter in the URL."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a68c5cc3_df3541d1","line":145,"range":{"start_line":145,"start_character":48,"end_line":145,"end_character":57},"in_reply_to":"a2b1ab93_a6f6a6d5","updated":"2026-03-30 13:25:00.000000000","message":"Done","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"}],"barbican/api/controllers/secrets.py":[{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"595d3e13ae0ffa1759ed4d5470cb2ecbd009b81f","unresolved":true,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        no_delete_if_consumers \u003d versions.is_supported("},{"line_number":264,"context_line":"            pecan.request, min_version\u003d\u00271.2\u0027)"},{"line_number":265,"context_line":"        force \u003d (\u0027force\u0027 in kwargs)"},{"line_number":266,"context_line":"        if (no_delete_if_consumers and (len(secret_consumers[0]) \u003e 0 and"},{"line_number":267,"context_line":"                                        not force)):"},{"line_number":268,"context_line":"            raise exception.SecretHasConsumers()"}],"source_content_type":"text/x-python","patch_set":7,"id":"6bc5bbef_61941e61","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":35},"updated":"2026-03-27 11:47:24.000000000","message":"Nit: This checks for the presence of the force key, not its value. A request like ?force\u003d0 or ?force\u003dfalse would still be treated as force\u003dTrue, which could be surprising. Consider validating the actual value, or at least document that any value (including empty) counts as force.","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0be11ef6aa29de9f01a7276faf9fc250489dbb3c","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        no_delete_if_consumers \u003d versions.is_supported("},{"line_number":264,"context_line":"            pecan.request, min_version\u003d\u00271.2\u0027)"},{"line_number":265,"context_line":"        force \u003d (\u0027force\u0027 in kwargs)"},{"line_number":266,"context_line":"        if (no_delete_if_consumers and (len(secret_consumers[0]) \u003e 0 and"},{"line_number":267,"context_line":"                                        not force)):"},{"line_number":268,"context_line":"            raise exception.SecretHasConsumers()"}],"source_content_type":"text/x-python","patch_set":7,"id":"f2756a13_8b376b40","line":265,"range":{"start_line":265,"start_character":8,"end_line":265,"end_character":35},"in_reply_to":"6bc5bbef_61941e61","updated":"2026-03-30 13:25:00.000000000","message":"This is fixed, we\u0027re now checking the value of the `force` query parameter.","commit_id":"63e92d9ddbe3aedddf421e283ec3d98dc0981726"}]}