)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"255b596cb0645fd735b45d93934f90d31dbf1e07","unresolved":false,"context_lines":[{"line_number":21,"context_line":"that is exposing the implementation details of the regex-search."},{"line_number":22,"context_line":"Documentation is updated to make this clear, and test-cases modified."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This also includes a man page for bashate.1 which also describes these"},{"line_number":25,"context_line":"usage details, and links this from the readme."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Id04a84ce48546f071a26caf2a5274c4ea1904490"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_71b7f986","line":24,"updated":"2014-10-22 09:10:06.000000000","message":"I think this is not related to the current commit and should be done in separate commit.","commit_id":"8917d65e1b57581fb9edc45002ff7490c37b992e"}],"bashate/bashate.py":[{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"255b596cb0645fd735b45d93934f90d31dbf1e07","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def should_ignore(self, error):"},{"line_number":111,"context_line":"        if not self.ignore:"},{"line_number":112,"context_line":"            return False"},{"line_number":113,"context_line":"        return re.search(\u0027^(\u0027 + \u0027|\u0027.join(self.ignore) + \u0027)\u0027, error)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def print_error(self, error, line,"},{"line_number":116,"context_line":"                    filename\u003dNone, filelineno\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_71e8d9b4","line":113,"updated":"2014-10-22 09:10:06.000000000","message":"I don\u0027t like the idea of compiling regexp for each check. Why not to do so once during registering ignores?","commit_id":"8917d65e1b57581fb9edc45002ff7490c37b992e"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"255b596cb0645fd735b45d93934f90d31dbf1e07","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        cmdline_ignores \u003d self.ignore"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        for fname in files:"},{"line_number":147,"context_line":"            # reset to global ignores.  Individual files can append to"},{"line_number":148,"context_line":"            # this with in-line statements to ignore specific things"},{"line_number":149,"context_line":"            # just for that file"},{"line_number":150,"context_line":"            self.ignore \u003d cmdline_ignores"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_d19ee553","line":147,"updated":"2014-10-22 09:10:06.000000000","message":"Two whitespaces instead of single after period.","commit_id":"8917d65e1b57581fb9edc45002ff7490c37b992e"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"255b596cb0645fd735b45d93934f90d31dbf1e07","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                # ignore line is \"# bashate: ignore\u003dE010,E011,E012\""},{"line_number":154,"context_line":"                if line.startswith(\"# bashate: ignore\"):"},{"line_number":155,"context_line":"                    self.ignore.extend([x.strip() \\"},{"line_number":156,"context_line":"                                        for x in line.split(\u0027\u003d\u0027)[1].split(\u0027,\u0027)])"},{"line_number":157,"context_line":"                    continue"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"                if fileinput.isfirstline():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_71de1941","line":156,"updated":"2014-10-22 09:10:06.000000000","message":"How would case when rules are missed be handled?\n\nE.g.:\n\n    # bashate: ignore\u003d\n\nI think you might need to check what you are adding to self.ignore list.","commit_id":"8917d65e1b57581fb9edc45002ff7490c37b992e"}],"bashate/tests/test_bashate.py":[{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"255b596cb0645fd735b45d93934f90d31dbf1e07","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        self.assert_error_found(\u0027E041\u0027, 4)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_sample_inline_ignore(self):"},{"line_number":115,"context_line":"        test_files \u003d [\u0027bashate/tests/samples/inline_ignore.sh\u0027]"},{"line_number":116,"context_line":"        self.run.check_files(test_files, False)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_31c81122","line":114,"updated":"2014-10-22 09:10:06.000000000","message":"I think this case should check that errors for particular check are skipped. By asserting that 0 errors found - full case is not covered. It might happen that ignore mechanism breaks everything and no errors are searched at all. I think you need to include several errors and ignore only one.","commit_id":"8917d65e1b57581fb9edc45002ff7490c37b992e"}]}