)]}'
{"playbooks/roles/bifrost-create-dib-image/defaults/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5572289d67698b928e3702fa11ba72931812c4ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"deploy_image: \"{{http_boot_folder}}/{{deploy_image_filename}}\""},{"line_number":5,"context_line":"dib_os_element: \"ubuntu\""},{"line_number":6,"context_line":"dib_env_vars:"},{"line_number":7,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":8,"context_line":"  ELEMENTS_PATH: \"/opt/stack/diskimage-builder/elements\""},{"line_number":9,"context_line":"  http_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":10,"context_line":"  https_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a50d1a3_9cedcc8d","line":7,"updated":"2015-07-20 19:16:30.000000000","message":"I believe the move to simple-init caused this line to drop.","commit_id":"dbf7388f50dd6c6567885b404e7441f442070a21"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8dbc593a1458395c4273db6dbc9988ba2745d7ba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":8,"context_line":"  ELEMENTS_PATH: \"/opt/stack/diskimage-builder/elements\""},{"line_number":9,"context_line":"  http_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":10,"context_line":"  https_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":11,"context_line":"# extra_dib_elements is a space separated list of elements."},{"line_number":12,"context_line":"extra_dib_elements: \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a50d1a3_6fab648a","line":10,"updated":"2015-07-20 19:23:17.000000000","message":"prob should use https_proxy for this one.","commit_id":"dbf7388f50dd6c6567885b404e7441f442070a21"}],"playbooks/roles/ironic-install/defaults/main.yml":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"cf5bc915e0e005aaccf7cddf4fecdc57af40c378","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":13,"context_line":"  ELEMENTS_PATH: \"/opt/stack/diskimage-builder/elements\""},{"line_number":14,"context_line":"  http_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":15,"context_line":"  https_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":16,"context_line":"# extra_dib_elements is a space separated list of elements."},{"line_number":17,"context_line":"extra_dib_elements: \"\""},{"line_number":18,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_b073bd4d","line":15,"updated":"2015-07-08 06:54:46.000000000","message":"nits:\n\nI have concern here, if the proxy is not required, we can access internet directly, so if these proxy settings are still needed?\n\nSo should we add these http_proxy/https_proxy env vars for DIB when-and-only the parnent process has these http_proxy/https_proxy vars, else we will have empty value for these vars, although we can directly access internet with these empty proxy env vars?","commit_id":"ed0927dce8931b529584f3150a399776d25d7e7a"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4d86183cc89f1a8b1ca08e9bc8dab49a6c7b6862","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":13,"context_line":"  ELEMENTS_PATH: \"/opt/stack/diskimage-builder/elements\""},{"line_number":14,"context_line":"  http_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":15,"context_line":"  https_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":16,"context_line":"# extra_dib_elements is a space separated list of elements."},{"line_number":17,"context_line":"extra_dib_elements: \"\""},{"line_number":18,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_ab535216","line":15,"in_reply_to":"ba3cc151_702c5502","updated":"2015-07-08 07:10:17.000000000","message":"It is fine with me, thanks for your response.","commit_id":"ed0927dce8931b529584f3150a399776d25d7e7a"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"49100d5d60da638c406d8b0504071a3c0a6a9438","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":13,"context_line":"  ELEMENTS_PATH: \"/opt/stack/diskimage-builder/elements\""},{"line_number":14,"context_line":"  http_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":15,"context_line":"  https_proxy: \"{{ lookup(\u0027env\u0027,\u0027http_proxy\u0027) }}\""},{"line_number":16,"context_line":"# extra_dib_elements is a space separated list of elements."},{"line_number":17,"context_line":"extra_dib_elements: \"\""},{"line_number":18,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_702c5502","line":15,"in_reply_to":"ba3cc151_b073bd4d","updated":"2015-07-08 06:59:47.000000000","message":"Yes it works with both behind the proxy and outside proxy environment. it is lookup plugin from ansible gets http_proxy/https_proxy values from shell env. If no proxy is set in shell it will take empty values and it works with internet directly. This code is already in place at roles level but for DIB to work with proxy this change was required.","commit_id":"ed0927dce8931b529584f3150a399776d25d7e7a"}]}