)]}'
{"bifrost/tests/functional/test_inventory_functional.py":[{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"6263dbb4930f8756080e53f8fcb094f2ad2fd370","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from bifrost.tests import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestBifrostInventoryFunctional(base.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        self.maxDiff \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_deadf284","line":24,"updated":"2015-11-11 20:21:29.000000000","message":"Hi Julia, great work on this. I have only one nit: are these test cases actually unit tests? Because, to me, you are aiming to test \"utils.bifrost_csv_conversion\" method, the scenarios seems pretty related to the method itself and from a close perspective of use about the expected behaviour of the method. I do think that may be better to move these tests to tests/unit/ .\n\nMaybe I\u0027m missing something here, I\u0027m newbie at bifrost so I\u0027m sorry if I misunderstood your intentions.","commit_id":"6323a1c51022ed7e84d955138fe3169042f5818c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7c948e0d75da457f53e7b561407d353ae518e0ac","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from bifrost.tests import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class TestBifrostInventoryFunctional(base.TestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        self.maxDiff \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a20b2723","line":24,"in_reply_to":"da85f559_deadf284","updated":"2015-11-12 00:33:25.000000000","message":"I was originally thinking unit tests, and think it could go either way, however I was thinking that this level of testing lended itself more towards a functional test of the method, largely as it is doing data parsing and none of the back-end methods are actually mocked.  I\u0027m happy to move it to unit tests though, if that is what the popular desire is. :)","commit_id":"6323a1c51022ed7e84d955138fe3169042f5818c"}]}