)]}'
{"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"158f7a84407accd11e06a325045e0a195febf64b","unresolved":false,"context_lines":[{"line_number":445,"context_line":"dhcp-boot\u003dtag:gpxe,/ipxe.pxe"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"dhcp-match\u003dset:ipxe,175 # iPXE sends a 175 option."},{"line_number":448,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":449,"context_line":"dhcp-boot\u003dtag:!ipxe,/undionly.kpxe"},{"line_number":450,"context_line":"dhcp-boot\u003dtag:efi,/ipxe.efi"},{"line_number":451,"context_line":"{% if testing %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a5ae5dd_dd526113","line":448,"updated":"2016-02-03 18:39:06.000000000","message":"I\u0027m not sure I follow the logic here.\n\n- if the client is *not* running iPXE, tell it to boot undionly.kpxe over TFTP.\n- if the client is running iPXE in EFI mode, tell it to boot /ipxe.efi over TFTP.\n- if the client is running iPXE in BIOS mode, tell it to fetch boot.ipxe from the appropriate HTTP server and boot that.\n\nIs that the intended logic? Is that what this code actually does, or am I reading it wrong?","commit_id":"dfbdb52e59ab2c94e685bfc4c427e1a050973252"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b573e595d5b3a95ec53384a600680889ec77aff4","unresolved":false,"context_lines":[{"line_number":445,"context_line":"dhcp-boot\u003dtag:gpxe,/ipxe.pxe"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"dhcp-match\u003dset:ipxe,175 # iPXE sends a 175 option."},{"line_number":448,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":449,"context_line":"dhcp-boot\u003dtag:!ipxe,/undionly.kpxe"},{"line_number":450,"context_line":"dhcp-boot\u003dtag:efi,/ipxe.efi"},{"line_number":451,"context_line":"{% if testing %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a5ae5dd_3d2615cf","line":448,"in_reply_to":"5a5ae5dd_9da4e957","updated":"2016-02-03 19:02:02.000000000","message":"Also, do we only want to tag a client as EFI if it\u0027s using EFI bytecode? RFC 4578 lists three other architectures with \"EFI\" in the name.","commit_id":"dfbdb52e59ab2c94e685bfc4c427e1a050973252"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"e085c072cb6e27a06d66030631a25f6314ce2f39","unresolved":false,"context_lines":[{"line_number":445,"context_line":"dhcp-boot\u003dtag:gpxe,/ipxe.pxe"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"dhcp-match\u003dset:ipxe,175 # iPXE sends a 175 option."},{"line_number":448,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":449,"context_line":"dhcp-boot\u003dtag:!ipxe,/undionly.kpxe"},{"line_number":450,"context_line":"dhcp-boot\u003dtag:efi,/ipxe.efi"},{"line_number":451,"context_line":"{% if testing %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a5ae5dd_9da4e957","line":448,"in_reply_to":"5a5ae5dd_dd526113","updated":"2016-02-03 18:56:15.000000000","message":"Reading http://ipxe.org/howto/chainloading, it looks like what I\u0027ve described above isn\u0027t the intended logic - you want to send ipxe.efi iff the client is running standard PXE in EFI mode. I think you can achieve this as follows:\n\n    dhcp-match\u003dset:ipxe,175\n    dhcp-match\u003dset:efi,option:client-arch,7\n    dhcp-boot\u003dtag:!ipxe,tag:!efi,/undionly.kpxe\n    dhcp-boot\u003dtag:!ipxe,tag:efi,/ipxe.efi\n    # code to boot clients who are using iPXE here\n\nWill the code in lines 451 onwards handle clients running iPXE in EFI mode as-is?","commit_id":"dfbdb52e59ab2c94e685bfc4c427e1a050973252"}]}