)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"339b73e7d6e315a5b2c8dac88990489f3c0ef562","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename of the nginx_port variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nginx_port variable is insufficently generic enough in the event"},{"line_number":10,"context_line":"a user really wanted to run Apache, or some other web server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As such, this commit renames the setting to file_url_port to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_ea28ec87","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":40},"updated":"2016-01-26 02:18:45.000000000","message":"nit: s/insufficently/insufficiently","commit_id":"f2747c0c81bd1efbf71db313bb7c2e4668f262ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d37d8e69903c8ae872ab8345040378763bed4dd5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename of the nginx_port variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nginx_port variable is insufficently generic enough in the event"},{"line_number":10,"context_line":"a user really wanted to run Apache, or some other web server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As such, this commit renames the setting to file_url_port to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_f844abb7","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":40},"in_reply_to":"9a68dd71_ea28ec87","updated":"2016-01-29 17:27:49.000000000","message":"Done","commit_id":"f2747c0c81bd1efbf71db313bb7c2e4668f262ba"}],"playbooks/roles/bifrost-deploy-nodes-dynamic/defaults/main.yml":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f6f9a80e623108abeb285200742c2ea29d7bdb8a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"ironic_url: \"http://localhost:6385/\""},{"line_number":4,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":5,"context_line":"# be used instead."},{"line_number":6,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":7,"context_line":"network_interface: \"virbr0\""},{"line_number":8,"context_line":"ans_network_interface: \"{{ network_interface | replace(\u0027-\u0027, \u0027_\u0027) }}\""},{"line_number":9,"context_line":"http_boot_folder: \"/httpboot\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_be67fb4b","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":29},"updated":"2016-01-29 18:25:07.000000000","message":"might be better to also allow file_url_port to be passed. Maybe something like:\nnginx_port: \" {{ nginx_port | default (\u00278080\u0027) }}\"\nfile_url_port: \" {{ file_url_port | default(nginx_port) }} \"","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a6893ac4162ddbc33eb643364ec69c8cdc7e64ec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"ironic_url: \"http://localhost:6385/\""},{"line_number":4,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":5,"context_line":"# be used instead."},{"line_number":6,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":7,"context_line":"network_interface: \"virbr0\""},{"line_number":8,"context_line":"ans_network_interface: \"{{ network_interface | replace(\u0027-\u0027, \u0027_\u0027) }}\""},{"line_number":9,"context_line":"http_boot_folder: \"/httpboot\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_396805b9","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":29},"in_reply_to":"7a5de9d1_7e3e63db","updated":"2016-01-29 18:34:34.000000000","message":"Good point. changing my vote. Thank you.","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f012c0bc1f2e2fc4ce71f8a728a32fe57de860dd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"ironic_url: \"http://localhost:6385/\""},{"line_number":4,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":5,"context_line":"# be used instead."},{"line_number":6,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":7,"context_line":"network_interface: \"virbr0\""},{"line_number":8,"context_line":"ans_network_interface: \"{{ network_interface | replace(\u0027-\u0027, \u0027_\u0027) }}\""},{"line_number":9,"context_line":"http_boot_folder: \"/httpboot\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_7e3e63db","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":29},"in_reply_to":"7a5de9d1_be67fb4b","updated":"2016-01-29 18:29:31.000000000","message":"So this is just the default if not defined elsewhere, so I think what I have is correct.  Defining nginx_port means that we can warn the user since it will always be around in our variable list.","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"9c4bf3397414d438c0d8ebd625071831711303df","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# which causes the nodes to be wiped after deletion."},{"line_number":4,"context_line":"cleaning: false"},{"line_number":5,"context_line":"http_boot_folder: /httpboot"},{"line_number":6,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":7,"context_line":"# be used instead."},{"line_number":8,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":9,"context_line":"ironicclient_source_install: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a68dd71_109ee606","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":14},"updated":"2016-01-25 17:10:30.000000000","message":"Can we add a deprecation warning in the relevant playbooks if nginx_port is set? We can probably drop it after a while.","commit_id":"f2747c0c81bd1efbf71db313bb7c2e4668f262ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d37d8e69903c8ae872ab8345040378763bed4dd5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# which causes the nodes to be wiped after deletion."},{"line_number":4,"context_line":"cleaning: false"},{"line_number":5,"context_line":"http_boot_folder: /httpboot"},{"line_number":6,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":7,"context_line":"# be used instead."},{"line_number":8,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":9,"context_line":"ironicclient_source_install: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_b865d3b5","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":14},"in_reply_to":"9a68dd71_109ee606","updated":"2016-01-29 17:27:49.000000000","message":"Good idea.","commit_id":"f2747c0c81bd1efbf71db313bb7c2e4668f262ba"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f6f9a80e623108abeb285200742c2ea29d7bdb8a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"http_boot_folder: /httpboot"},{"line_number":6,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":7,"context_line":"# be used instead."},{"line_number":8,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":9,"context_line":"ironicclient_source_install: false"},{"line_number":10,"context_line":"shade_source_install: true"},{"line_number":11,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_3edb0bee","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":51},"updated":"2016-01-29 18:25:07.000000000","message":"see previous comment","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"}],"playbooks/roles/bifrost-ironic-install/tasks/main.yml":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"206b3497a45467cd939fe20346887728242c47f4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  debug:"},{"line_number":37,"context_line":"    msg: \u003e"},{"line_number":38,"context_line":"      WARNING - nginx_port is a deprecated variable and support will be"},{"line_number":39,"context_line":"      removed during the N cycle."},{"line_number":40,"context_line":"  when: nginx_port is defined"},{"line_number":41,"context_line":"- name: \"Update Package Cache\""},{"line_number":42,"context_line":"  apt: update_cache\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a5ae5dd_dc4c5a44","line":39,"range":{"start_line":39,"start_character":25,"end_line":39,"end_character":26},"updated":"2016-02-04 22:51:55.000000000","message":"s/N/Newton/\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-January/084432.html","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"}],"playbooks/roles/ironic-enroll-dynamic/defaults/main.yml":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"f6f9a80e623108abeb285200742c2ea29d7bdb8a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ironic_url: \"http://localhost:6385/\""},{"line_number":3,"context_line":"# Deprecated: nginx_port is no longer used and file_url_port should"},{"line_number":4,"context_line":"# be used instead."},{"line_number":5,"context_line":"file_url_port: \"{{ nginx_port | default(\u00278080\u0027) }}\""},{"line_number":6,"context_line":"# Default network interface that bifrost will be attached to."},{"line_number":7,"context_line":"network_interface: \"virbr0\""},{"line_number":8,"context_line":"ans_network_interface: \"{{ network_interface | replace(\u0027-\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a5de9d1_bef5bb57","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":51},"updated":"2016-01-29 18:25:07.000000000","message":"ditto","commit_id":"fa4bd9fb9781dfb195cdcd109f3634d92f085ec9"}]}