)]}'
{"playbooks/roles/bifrost-to-ironic/README.md":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f39cef9fdc0f43e4e9295403837a075a801334da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The purpose of this role is to move bifrost nodes, post-inspection,"},{"line_number":2,"context_line":"to another Ironic."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This way, we can use bifrost to inspect, burn-in, update firmware, etc"},{"line_number":5,"context_line":"in the less restrictive Bifrost pool, and then transition them to the"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"9a061dce_bc464ebd","line":2,"updated":"2016-04-04 16:41:45.000000000","message":"I think it would be good to detail context, that that this is intended to operate with ipmi based nodes.  That there is a default assumed password in defaults.yml?","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"135a4f2e3fedf57e6c36954a5c5ae9ad8629c6ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The purpose of this role is to move bifrost nodes, post-inspection,"},{"line_number":2,"context_line":"to another Ironic."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This way, we can use bifrost to inspect, burn-in, update firmware, etc"},{"line_number":5,"context_line":"in the less restrictive Bifrost pool, and then transition them to the"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"9a061dce_68822b54","line":2,"in_reply_to":"9a061dce_bc464ebd","updated":"2016-04-04 19:39:16.000000000","message":"I agree here. I\u0027d like to see a little more content overall, along the lines of what\u0027s in the other role readmes.","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"}],"playbooks/roles/bifrost-to-ironic/defaults/main.yml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"135a4f2e3fedf57e6c36954a5c5ae9ad8629c6ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bifrost_transfer_group: compute-ironic"},{"line_number":2,"context_line":"bifrost_ironic_url: http://localhost:6385/"},{"line_number":3,"context_line":"other_ironic_auth_type: \"__this_can_be_almost_anything__\""},{"line_number":4,"context_line":"transfer_names: []"},{"line_number":5,"context_line":"ipmi_password: ADMIN"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a061dce_88b05ff6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":18},"updated":"2016-04-04 19:39:16.000000000","message":"This is just \"ironic_url\" in the other roles, would be nice to have it be consistent.","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f39cef9fdc0f43e4e9295403837a075a801334da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bifrost_transfer_group: compute-ironic"},{"line_number":2,"context_line":"bifrost_ironic_url: http://localhost:6385/"},{"line_number":3,"context_line":"other_ironic_auth_type: \"__this_can_be_almost_anything__\""},{"line_number":4,"context_line":"transfer_names: []"},{"line_number":5,"context_line":"ipmi_password: ADMIN"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a061dce_5ce8d27c","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":56},"updated":"2016-04-04 16:41:45.000000000","message":"Joking: Anything eh? :)","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0cd37c23a594318daba4735932d3bcdf1572f2df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bifrost_transfer_group: compute-ironic"},{"line_number":2,"context_line":"bifrost_ironic_url: http://localhost:6385/"},{"line_number":3,"context_line":"other_ironic_auth_type: \"__this_can_be_almost_anything__\""},{"line_number":4,"context_line":"transfer_names: []"},{"line_number":5,"context_line":"ipmi_password: ADMIN"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a061dce_8ee1549d","line":2,"range":{"start_line":2,"start_character":20,"end_line":2,"end_character":42},"updated":"2016-04-05 16:18:45.000000000","message":"\"{{ ironic_url | default(\u0027http://localhost:6385/\u0027)}\"","commit_id":"2bb3b9d74a9d153bb8e7fe7a816c2ba2060f8cdd"}],"playbooks/roles/bifrost-to-ironic/tasks/main.yml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"135a4f2e3fedf57e6c36954a5c5ae9ad8629c6ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: select nodes to transfer"},{"line_number":2,"context_line":"  include: transfer.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in transfer_names"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a061dce_08d9ef21","line":1,"updated":"2016-04-04 19:39:16.000000000","message":"Appropriate license headers should be included here.","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"}],"playbooks/roles/bifrost-to-ironic/tasks/transfer.yml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"135a4f2e3fedf57e6c36954a5c5ae9ad8629c6ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Set to maintenance mode"},{"line_number":2,"context_line":"  os_ironic_node:"},{"line_number":3,"context_line":"    deploy\u003dfalse"},{"line_number":4,"context_line":"    maintenance\u003dtrue"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a061dce_c8f53784","line":1,"updated":"2016-04-04 19:39:16.000000000","message":"More license headers here.","commit_id":"5a6dc5e673bd39051a6930cfb4d775becb9515d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0cd37c23a594318daba4735932d3bcdf1572f2df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    provision_state\u003dmanage"},{"line_number":34,"context_line":"    state\u003dpresent"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Delete from bifrost"},{"line_number":37,"context_line":"  os_ironic:"},{"line_number":38,"context_line":"    name\u003d{{ inventory_hostname }}"},{"line_number":39,"context_line":"    state\u003dabsent"},{"line_number":40,"context_line":"  when: delete_transferred_nodes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a061dce_2e13e867","line":39,"range":{"start_line":36,"start_character":7,"end_line":39,"end_character":16},"updated":"2016-04-05 16:18:45.000000000","message":"Does the current state matter?  Technically you need to go to maintenance mode to force a delete if the node is in a state that is not deletable.","commit_id":"2bb3b9d74a9d153bb8e7fe7a816c2ba2060f8cdd"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5e20e64fd72233e0df1f3c08818877ffdf53a0aa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- name: Delete from bifrost"},{"line_number":37,"context_line":"  os_ironic:"},{"line_number":38,"context_line":"    name\u003d{{ inventory_hostname }}"},{"line_number":39,"context_line":"    state\u003dabsent"},{"line_number":40,"context_line":"  when: delete_transferred_nodes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a18252c_82ae1b96","line":39,"updated":"2016-04-14 08:37:45.000000000","message":"Indeed, I\u0027m actually leaning now toward just leaving them in maintenance mode. If admins want to clear them out later, that\u0027s fine.","commit_id":"2bb3b9d74a9d153bb8e7fe7a816c2ba2060f8cdd"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4a4484785aeab299e487af02d2f4728d89f6daf8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- name: Delete from bifrost"},{"line_number":37,"context_line":"  os_ironic:"},{"line_number":38,"context_line":"    name\u003d{{ inventory_hostname }}"},{"line_number":39,"context_line":"    state\u003dabsent"},{"line_number":40,"context_line":"  when: delete_transferred_nodes"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_4f60b2cf","line":39,"in_reply_to":"5a18252c_82ae1b96","updated":"2016-12-05 18:52:05.000000000","message":"I\u0027m afraid that leaving nodes in the \"old\" ironic still poses some considerable risk as now we have two \"entities\" managing the nodes, and they are not in sync. As Ironic API is \"multi-user\", and miscommunications do happen with humans :) another human user (not the one that has transferred the node and put them to maintenance in the \"old\" ironic) still has possibility to unset the maintenance, change boot device etc.\n\nMay be the following example is too unrealistic but still imagine the following situation:\n\n- standalone ironic is HA/multi-conductor\n- you have an active netboot-ed node in the \"old\" ironic\n- you transfer it to the \"new\" one, leaving it in the \"old\" as well\n- the new ironic redeploys it with whatever it wants, e.g completely different image and localboot\n- one of \"old\" ironic-conductors - the one that was managing this node - dies\n- another \"old\" ironic-conductor takes it over and updates the DHCP opts and next boot device according to what it knows (netboot)\n- the user inside the node reboots it and oops - it pxe-boots to a completely different image! :)\n\nSo I\u0027d vote to still remove the nodes from the \"old\" ironic, or at least make them unmanageable (e.g. clear the IPMI password, clear instance_info etc).\n\nAt the very least, all the possible perils must be carefully documented.","commit_id":"2bb3b9d74a9d153bb8e7fe7a816c2ba2060f8cdd"}]}