)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"75b334e9039492c59ab09e88e5a9521eb67f9ff7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert ironic.conf to template generated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously the sample config was editted, but this incurred a"},{"line_number":10,"context_line":"maintenance burden, and was also extremely hard to read. Since the"},{"line_number":11,"context_line":"entire sample config is already commented out, this should have no"},{"line_number":12,"context_line":"impact on how much maintenance is required to keep up with new required"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_90f86a7e","line":9,"updated":"2016-04-22 17:27:13.000000000","message":"Typo: \"edited\"","commit_id":"bb53d4c037fc391f8604c2cccef6d4f28c6d16ae"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"c60278fc0e1e995842c9db82edd7b358f19269d0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    default_password: \"ChangeThisPa55w0rd\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# TODO(TheJulia): Thinking outloud, I we ought to head in the"},{"line_number":202,"context_line":"# direction of identifying the address of the conductor host"},{"line_number":203,"context_line":"# in a more uniform fashion. What that is exactly, is TBD."},{"line_number":204,"context_line":"my_ip_address: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fa6399be_d49c3fc2","line":201,"updated":"2016-10-14 10:33:51.000000000","message":"\"I we\"? :)","commit_id":"27d1d66592bdf7090082f53cc9db1252618307fa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb0a759cc50e7ecaf2ed49d7d907257112c88a03","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    default_password: \"ChangeThisPa55w0rd\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# TODO(TheJulia): Thinking outloud, I we ought to head in the"},{"line_number":202,"context_line":"# direction of identifying the address of the conductor host"},{"line_number":203,"context_line":"# in a more uniform fashion. What that is exactly, is TBD."},{"line_number":204,"context_line":"my_ip_address: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fa6399be_ca61f63a","line":201,"in_reply_to":"fa6399be_d49c3fc2","updated":"2016-10-14 11:38:02.000000000","message":"Heh, thanks!","commit_id":"27d1d66592bdf7090082f53cc9db1252618307fa"}],"playbooks/roles/bifrost-ironic-install/tasks/ironic_config.yml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"eba7a3ffb4193fd9f730ab13da8d1583340d0a28","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    enabled_drivers: \"{{ enabled_drivers }},{{ pxe_drivers }}\""},{"line_number":19,"context_line":"  when: enable_pxe_drivers | bool \u003d\u003d true"},{"line_number":20,"context_line":"- name: \"Create ironic config\""},{"line_number":21,"context_line":"  template:"},{"line_number":22,"context_line":"    src\u003d\"ironic.conf.j2\""},{"line_number":23,"context_line":"    dest\u003d/etc/ironic/ironic.conf"},{"line_number":24,"context_line":"    owner\u003dironic"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1a95cdbc_ad74d635","line":21,"updated":"2016-10-07 22:18:09.000000000","message":"how about making a backup of previous version with\n\n  backup: yes\n\njust in case something goes wrong?","commit_id":"f6500453077d630bb6e379ee94ff1be90ac9cff4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7143e1104cc644724486283829c41edc81c59e8a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    enabled_drivers: \"{{ enabled_drivers }},{{ pxe_drivers }}\""},{"line_number":19,"context_line":"  when: enable_pxe_drivers | bool \u003d\u003d true"},{"line_number":20,"context_line":"- name: \"Create ironic config\""},{"line_number":21,"context_line":"  template:"},{"line_number":22,"context_line":"    src\u003d\"ironic.conf.j2\""},{"line_number":23,"context_line":"    dest\u003d/etc/ironic/ironic.conf"},{"line_number":24,"context_line":"    owner\u003dironic"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa6399be_74ca2f51","line":21,"in_reply_to":"1a95cdbc_ad74d635","updated":"2016-10-11 12:02:25.000000000","message":"Ahh, seems like we might want to do that for all of our template changes.  I\u0027ll look into this.  Thank you!","commit_id":"f6500453077d630bb6e379ee94ff1be90ac9cff4"}],"playbooks/roles/bifrost-ironic-install/templates/ironic.conf.j2":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d0e0877bfeeedc6e01e5576ab89dbb38581b40e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"{% if testing | bool %}"},{"line_number":3,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":4,"context_line":"debug \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a122d0e_eb295a9c","line":1,"updated":"2016-04-20 20:53:04.000000000","message":"I would love to get a header added to this, to essentially indicate that this is template generated, that ANY changes will be squashed if installation is re-run, and where to find the example configuration for ironic so a user can understand what their configuration options are.","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6e559673f90129936be78a4c50bfd83cc21243d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"{% if testing | bool %}"},{"line_number":3,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":4,"context_line":"debug \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a122d0e_4a09032c","line":1,"in_reply_to":"1a122d0e_eb295a9c","updated":"2016-04-22 16:41:40.000000000","message":"ACK, I\u0027ll add # {{ ansible_managed }}, which explains the first part. The second I hope we can agree is made unnecessary by the fact that it\u0027s Ironic, and the sample configs are well documented in Ironic\u0027s documentation.","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d0e0877bfeeedc6e01e5576ab89dbb38581b40e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"rabbit_password \u003d {{ ironic_db_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"auth_strategy \u003d noauth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[pxe]"},{"line_number":16,"context_line":"pxe_append_params \u003d systemd.journald.forward_to_console\u003dyes {{ extra_kernel_options | default(\u0027\u0027) }}"},{"line_number":17,"context_line":"pxe_config_template \u003d $pybasedir/drivers/modules/ipxe_config.template"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a122d0e_6f38b5d3","line":14,"updated":"2016-04-20 20:53:04.000000000","message":"The [deploy] section is missing.","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6e559673f90129936be78a4c50bfd83cc21243d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"rabbit_password \u003d {{ ironic_db_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"auth_strategy \u003d noauth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[pxe]"},{"line_number":16,"context_line":"pxe_append_params \u003d systemd.journald.forward_to_console\u003dyes {{ extra_kernel_options | default(\u0027\u0027) }}"},{"line_number":17,"context_line":"pxe_config_template \u003d $pybasedir/drivers/modules/ipxe_config.template"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a122d0e_6af31fa0","line":14,"in_reply_to":"1a122d0e_6f38b5d3","updated":"2016-04-22 16:41:40.000000000","message":"I missed this because the lineinfile\u0027s were really hard to follow. Perhaps another reason this approach will be more sustainable. ;)","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"c3e440a9ec72d951a5c62a84cabea94d24b2e045","unresolved":false,"context_lines":[{"line_number":27,"context_line":"api_url \u003d http://{{ my_ip_address }}:6385/"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[console]"},{"line_number":30,"context_line":"clean_nodes \u003d {{ cleaning | lower }}"},{"line_number":31,"context_line":"automated_clean \u003d {{ cleaning | lower }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a18252c_b69ec604","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":11},"updated":"2016-04-15 00:09:33.000000000","message":"Cleaning options should be under [conductor].","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d0e0877bfeeedc6e01e5576ab89dbb38581b40e6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"api_url \u003d http://{{ my_ip_address }}:6385/"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[console]"},{"line_number":30,"context_line":"clean_nodes \u003d {{ cleaning | lower }}"},{"line_number":31,"context_line":"automated_clean \u003d {{ cleaning | lower }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a122d0e_0b2f76a1","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":11},"in_reply_to":"5a18252c_b69ec604","updated":"2016-04-20 20:53:04.000000000","message":"++, we don\u0027t want to try and run with cleaning while testing, at least when testing with VMs that don\u0027t grok secure erase.\n\nI think the [console] option above can just be removed since we don\u0027t use it anyway.","commit_id":"8cb3435bc575e42e802ba2fd14996406be9227e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4a89d7bf29863cb91eb0f75382cb78092d7d8b52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"{% if testing | bool %}"},{"line_number":4,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":5,"context_line":"debug \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5a9d85d2_8d7cabec","line":2,"updated":"2016-06-21 11:27:34.000000000","message":"nit: We ought to pint the user to where they can find out details about the configuration file.","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8beea90ecdfc8e2f7b844b4e3f7b784946b21f45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"{% if testing | bool %}"},{"line_number":4,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":5,"context_line":"debug \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3a98d1f4_ecf07ecb","line":2,"in_reply_to":"5a9d85d2_8d7cabec","updated":"2016-11-22 14:29:49.000000000","message":"Done","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"ea61f727cdf4a9ad8b42ec7b36ff793511e622db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"{% if testing | bool %}"},{"line_number":4,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":5,"context_line":"debug \u003d true"},{"line_number":6,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7aa08908_286929bf","line":3,"updated":"2016-06-06 23:30:15.000000000","message":"Should be \"bool \u003d\u003d true\"","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8beea90ecdfc8e2f7b844b4e3f7b784946b21f45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"{% if testing | bool %}"},{"line_number":4,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":5,"context_line":"debug \u003d true"},{"line_number":6,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3a98d1f4_4cc09250","line":3,"in_reply_to":"7aa08908_286929bf","updated":"2016-11-22 14:29:49.000000000","message":"Done","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"ea61f727cdf4a9ad8b42ec7b36ff793511e622db","unresolved":false,"context_lines":[{"line_number":37,"context_line":"[dhcp]"},{"line_number":38,"context_line":"dhcp_provider \u003d none"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if testing | bool %}"},{"line_number":41,"context_line":"[ssh]"},{"line_number":42,"context_line":"libvirt_uri \u003d qemu:///system"},{"line_number":43,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7aa08908_c8a865de","line":40,"updated":"2016-06-06 23:30:15.000000000","message":"Should be bool \u003d\u003d true.","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8beea90ecdfc8e2f7b844b4e3f7b784946b21f45","unresolved":false,"context_lines":[{"line_number":37,"context_line":"[dhcp]"},{"line_number":38,"context_line":"dhcp_provider \u003d none"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if testing | bool %}"},{"line_number":41,"context_line":"[ssh]"},{"line_number":42,"context_line":"libvirt_uri \u003d qemu:///system"},{"line_number":43,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3a98d1f4_8cb61af7","line":40,"in_reply_to":"7aa08908_c8a865de","updated":"2016-11-22 14:29:49.000000000","message":"Done","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"ea61f727cdf4a9ad8b42ec7b36ff793511e622db","unresolved":false,"context_lines":[{"line_number":42,"context_line":"libvirt_uri \u003d qemu:///system"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% if enable_cors | bool %}"},{"line_number":46,"context_line":"[cors]"},{"line_number":47,"context_line":"allowed_origin \u003d {{ cors_allowed_origin | default(\u0027allowed_origin\u003dhttp://localhost:8000\u0027) }}"},{"line_number":48,"context_line":"allow_credentials \u003d {{ enable_cors_credential_support | default(\u0027true\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7aa08908_28b00943","line":45,"updated":"2016-06-06 23:30:15.000000000","message":"Should be bool \u003d\u003d true","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8beea90ecdfc8e2f7b844b4e3f7b784946b21f45","unresolved":false,"context_lines":[{"line_number":42,"context_line":"libvirt_uri \u003d qemu:///system"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% if enable_cors | bool %}"},{"line_number":46,"context_line":"[cors]"},{"line_number":47,"context_line":"allowed_origin \u003d {{ cors_allowed_origin | default(\u0027allowed_origin\u003dhttp://localhost:8000\u0027) }}"},{"line_number":48,"context_line":"allow_credentials \u003d {{ enable_cors_credential_support | default(\u0027true\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3a98d1f4_6caaae86","line":45,"in_reply_to":"7aa08908_28b00943","updated":"2016-11-22 14:29:49.000000000","message":"Done","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"ea61f727cdf4a9ad8b42ec7b36ff793511e622db","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[ilo]"},{"line_number":52,"context_line":"use_web_server_for_images \u003d true"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if enable_inspector | bool %}"},{"line_number":55,"context_line":"[inspector]"},{"line_number":56,"context_line":"enabled \u003d true"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7aa08908_8885bd5a","line":54,"updated":"2016-06-06 23:30:15.000000000","message":"Should be bool \u003d\u003d true","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8beea90ecdfc8e2f7b844b4e3f7b784946b21f45","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[ilo]"},{"line_number":52,"context_line":"use_web_server_for_images \u003d true"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if enable_inspector | bool %}"},{"line_number":55,"context_line":"[inspector]"},{"line_number":56,"context_line":"enabled \u003d true"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3a98d1f4_2c92664c","line":54,"in_reply_to":"7aa08908_8885bd5a","updated":"2016-11-22 14:29:49.000000000","message":"Done","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4a89d7bf29863cb91eb0f75382cb78092d7d8b52","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if enable_inspector | bool %}"},{"line_number":55,"context_line":"[inspector]"},{"line_number":56,"context_line":"enabled \u003d true"},{"line_number":57,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7aa08908_0757dace","line":56,"updated":"2016-06-21 11:27:34.000000000","message":"Just pointing out that alternatively, the bool could just be parsed out on the line it\u0027s self","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"eba7a3ffb4193fd9f730ab13da8d1583340d0a28","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# configuration besides a flat network where bifrost orchustrates the"},{"line_number":10,"context_line":"# control instead of ironic, noop is the only available network driver."},{"line_number":11,"context_line":"enabled_network_interfaces \u003d noop"},{"line_number":12,"context_line":"{% if testing | bool \u003d\u003d true %}"},{"line_number":13,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":14,"context_line":"debug \u003d true"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1a95cdbc_4db352e9","line":12,"updated":"2016-10-07 22:18:09.000000000","message":"what is the incoming format of \"testing\", \"cleaning\" etc vars?\n\nIf it is anything in \"yes\", \"no\", \"true\", \"false\" etc, Ansible should have already converted those to proper booleans, thus |bool\u003d\u003dTrue is not needed, just {% if testing %}","commit_id":"f6500453077d630bb6e379ee94ff1be90ac9cff4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7143e1104cc644724486283829c41edc81c59e8a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# configuration besides a flat network where bifrost orchustrates the"},{"line_number":10,"context_line":"# control instead of ironic, noop is the only available network driver."},{"line_number":11,"context_line":"enabled_network_interfaces \u003d noop"},{"line_number":12,"context_line":"{% if testing | bool \u003d\u003d true %}"},{"line_number":13,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":14,"context_line":"debug \u003d true"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"fa6399be_74a30f9f","line":12,"in_reply_to":"1a95cdbc_4db352e9","updated":"2016-10-11 12:02:25.000000000","message":"In theory yes, however we\u0027ve found that a number of our users will sometimes pass variables along the command line, which ansible always seems to treat as strings.  As such, we adopted the format of being a little bit more verbose, to always cast the input so we don\u0027t end up with odd unexpected behavior.","commit_id":"f6500453077d630bb6e379ee94ff1be90ac9cff4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"0dfe9a29c57a49d4655347e05335af5c53d7a3e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# configuration besides a flat network where bifrost orchustrates the"},{"line_number":10,"context_line":"# control instead of ironic, noop is the only available network driver."},{"line_number":11,"context_line":"enabled_network_interfaces \u003d noop"},{"line_number":12,"context_line":"{% if testing | bool \u003d\u003d true %}"},{"line_number":13,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":14,"context_line":"debug \u003d true"},{"line_number":15,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"fa6399be_ecae1a84","line":12,"in_reply_to":"fa6399be_74a30f9f","updated":"2016-10-13 07:25:50.000000000","message":"thanks for explanation","commit_id":"f6500453077d630bb6e379ee94ff1be90ac9cff4"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1a509ce729b44e6fc891da4e56f44cf955cd9c93","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# control instead of ironic, noop is the only available network driver."},{"line_number":11,"context_line":"enabled_network_interfaces \u003d noop"},{"line_number":12,"context_line":"{% if testing | bool \u003d\u003d true %}"},{"line_number":13,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":14,"context_line":"debug \u003d true"},{"line_number":15,"context_line":"{% else %}"},{"line_number":16,"context_line":"enabled_drivers \u003d {{ enabled_drivers }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7a77a97e_fceba1ae","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":35},"updated":"2016-11-14 19:03:34.000000000","message":"are these needed with the advent of the Virtual BMC?","commit_id":"27e9bb7fd67ce2cf1b44af4e9e38a99969205d7d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f52ad35f24e603904d24c9f340b425d28ff28d33","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# control instead of ironic, noop is the only available network driver."},{"line_number":11,"context_line":"enabled_network_interfaces \u003d noop"},{"line_number":12,"context_line":"{% if testing | bool \u003d\u003d true %}"},{"line_number":13,"context_line":"enabled_drivers \u003d agent_ssh,pxe_ssh"},{"line_number":14,"context_line":"debug \u003d true"},{"line_number":15,"context_line":"{% else %}"},{"line_number":16,"context_line":"enabled_drivers \u003d {{ enabled_drivers }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7a77a97e_c7187387","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":35},"in_reply_to":"7a77a97e_fceba1ae","updated":"2016-11-16 12:38:30.000000000","message":"Bifrost does not yet support virtualbmc.","commit_id":"27e9bb7fd67ce2cf1b44af4e9e38a99969205d7d"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1a509ce729b44e6fc891da4e56f44cf955cd9c93","unresolved":false,"context_lines":[{"line_number":41,"context_line":"automated_clean \u003d {{ cleaning | lower }}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[database]"},{"line_number":44,"context_line":"connection \u003d mysql+pymysql://ironic:{{ ironic_db_password }}@localhost/ironic?charset\u003dutf8"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[dhcp]"},{"line_number":47,"context_line":"dhcp_provider \u003d none"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7a77a97e_5cf2d59b","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":70},"updated":"2016-11-14 19:03:34.000000000","message":"In my use case I have a existing mysql server that I need to use. I it would be good to not have to edit the template to use.","commit_id":"27e9bb7fd67ce2cf1b44af4e9e38a99969205d7d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f52ad35f24e603904d24c9f340b425d28ff28d33","unresolved":false,"context_lines":[{"line_number":41,"context_line":"automated_clean \u003d {{ cleaning | lower }}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[database]"},{"line_number":44,"context_line":"connection \u003d mysql+pymysql://ironic:{{ ironic_db_password }}@localhost/ironic?charset\u003dutf8"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[dhcp]"},{"line_number":47,"context_line":"dhcp_provider \u003d none"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7a77a97e_6236ade8","line":44,"range":{"start_line":44,"start_character":61,"end_line":44,"end_character":70},"in_reply_to":"7a77a97e_5cf2d59b","updated":"2016-11-16 12:38:30.000000000","message":"I think we\u0027re at the point where we could quickly iterate towards that after the fact, since this change is holding up other changes which begin to introduce the concept, it is a little cart before the horse. :(","commit_id":"27e9bb7fd67ce2cf1b44af4e9e38a99969205d7d"}],"releasenotes/notes/releasenotes/notes/templated_ironic_conf-bd052f2b2897d37a.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d11487d6b88c3c76124eedd4fa9a0efd672aeb73","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - Ironic.conf is templated and only sets required"},{"line_number":8,"context_line":"    options now, as opposed to editting the Sample"},{"line_number":9,"context_line":"    configuration of Ironic."},{"line_number":10,"context_line":"other:"},{"line_number":11,"context_line":"  - In the past, the sample config in Ironic may have"},{"line_number":12,"context_line":"    set some boilerplate that Bifrost took advantage"},{"line_number":13,"context_line":"    of. But now that config is entirely made up of"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_4383c104","line":10,"updated":"2016-06-06 19:37:07.000000000","message":"It is likely worth noting in an upgrade section that any manual changes will now be squashed, and that they will have to be made again, where as previously bifrost would only change what could be identified in the configuration as needing to change.","commit_id":"142fcb251d9f05b166b6e0a1d2f909bb7f7f337c"}]}