)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      WARNING - nginx_port is a deprecated variable and support will be"},{"line_number":20,"context_line":"      removed during the Newton cycle."},{"line_number":21,"context_line":"  when: nginx_port is defined"},{"line_number":22,"context_line":"- name: \"Start database service\""},{"line_number":23,"context_line":"  service: name\u003d{{ mysql_service_name }} state\u003dstarted"},{"line_number":24,"context_line":"- name: \"Start rabbitmq-server\""},{"line_number":25,"context_line":"  service: name\u003drabbitmq-server state\u003dstarted"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_3dcb2d55","line":22,"updated":"2016-06-06 23:11:04.000000000","message":"Might be worth commenting here that we\u0027re going to start rabbitmq and mysql but no other services here.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  template: src\u003ddnsmasq.conf.j2 dest\u003d/etc/dnsmasq.conf"},{"line_number":220,"context_line":"  when: \"{{include_dhcp_server|bool}}\""},{"line_number":221,"context_line":"# NOTE(Shrews) When testing, we want to use our custom dnsmasq.conf file,"},{"line_number":222,"context_line":"# not the one supplied by libvirt. And the libvirt started dnsmasq processes"},{"line_number":223,"context_line":"# are not controlled by upstart, so we need to manually kill those."},{"line_number":224,"context_line":"- name: \"Look for libvirt dnsmasq config\""},{"line_number":225,"context_line":"  stat: path\u003d/etc/dnsmasq.d/libvirt-bin"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_1d9f5151","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":76},"updated":"2016-06-06 23:11:04.000000000","message":"Second sentence of this comment isn\u0027t applicable here - it needs to go where the killall ended up in start.yml","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"a4a002b8737453271076f4e27faa0c8ecbcbf3e3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    state: present"},{"line_number":80,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":81,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":82,"context_line":"- name: \"Install Ironic using pip\""},{"line_number":83,"context_line":"  include: pip_install.yml"},{"line_number":84,"context_line":"    package\u003dironic"},{"line_number":85,"context_line":"    state\u003dlatest"},{"line_number":86,"context_line":"    sourcedir\u003d{{ ironic_git_folder }}"},{"line_number":87,"context_line":"    source_install\u003dtrue"},{"line_number":88,"context_line":"  when: skip_install is not defined"},{"line_number":89,"context_line":"- name: \"Create an ironic service group\""},{"line_number":90,"context_line":"  group:"},{"line_number":91,"context_line":"    name: \"ironic\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7aa08908_4a7c6220","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":35},"updated":"2016-06-10 18:03:44.000000000","message":"Looks like this snuck in during your rebase :( We can remove it here as it\u0027s already done in the install phase.","commit_id":"a8d6550177d8ae198f3b8b70819e326e64d549bf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d46b998f19a28ffbe26f253e83ef542c73ae2cb9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    state: present"},{"line_number":80,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":81,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":82,"context_line":"- name: \"Install Ironic using pip\""},{"line_number":83,"context_line":"  include: pip_install.yml"},{"line_number":84,"context_line":"    package\u003dironic"},{"line_number":85,"context_line":"    state\u003dlatest"},{"line_number":86,"context_line":"    sourcedir\u003d{{ ironic_git_folder }}"},{"line_number":87,"context_line":"    source_install\u003dtrue"},{"line_number":88,"context_line":"  when: skip_install is not defined"},{"line_number":89,"context_line":"- name: \"Create an ironic service group\""},{"line_number":90,"context_line":"  group:"},{"line_number":91,"context_line":"    name: \"ironic\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7aa08908_ec4435b8","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":35},"in_reply_to":"7aa08908_4a7c6220","updated":"2016-06-11 13:10:22.000000000","message":"yep good catch\nill remove that and resubmit.","commit_id":"a8d6550177d8ae198f3b8b70819e326e64d549bf"}],"playbooks/roles/bifrost-ironic-install/tasks/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_2647944c","line":1,"updated":"2016-06-03 15:04:07.000000000","message":"Nit: Blank line","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57630be2dfb24b7acc567545d3be882f26e7fc7c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_e313100c","line":1,"in_reply_to":"9abb7d3a_2647944c","updated":"2016-06-04 10:00:12.000000000","message":"yep ill remove when i rebase","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - \"../defaults/required_defaults_{{ ansible_distribution }}_{{ansible_distribution_release }}.yml\""},{"line_number":34,"context_line":"    - \"../defaults/required_defaults_{{ ansible_distribution }}_{{ ansible_distribution_version }}.yml\""},{"line_number":35,"context_line":"    - \"../defaults/dummy-defaults.yml\""},{"line_number":36,"context_line":"- name: \"install ironic deps\""},{"line_number":37,"context_line":"  include: install.yml"},{"line_number":38,"context_line":"  when: skip_package_install is not defined"},{"line_number":39,"context_line":"- name: \"bootstrap ironic\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_3df96d81","line":36,"updated":"2016-06-06 23:11:04.000000000","message":"Please ensure that the capitalization of your new task names is consistent with the existing tasks.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  when: skip_package_install is not defined"},{"line_number":39,"context_line":"- name: \"bootstrap ironic\""},{"line_number":40,"context_line":"  include: bootstrap.yml"},{"line_number":41,"context_line":"  when: skip_bootstrap is not defined"},{"line_number":42,"context_line":"- name: \"start ironic serivces\""},{"line_number":43,"context_line":"  include: start.yml"},{"line_number":44,"context_line":"  when: skip_start is not defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_86e9201d","line":41,"updated":"2016-06-03 15:04:07.000000000","message":"I would prefer to go with pre-defined boolean values for this, that way we don\u0027t have to change it later.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57630be2dfb24b7acc567545d3be882f26e7fc7c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  when: skip_package_install is not defined"},{"line_number":39,"context_line":"- name: \"bootstrap ironic\""},{"line_number":40,"context_line":"  include: bootstrap.yml"},{"line_number":41,"context_line":"  when: skip_bootstrap is not defined"},{"line_number":42,"context_line":"- name: \"start ironic serivces\""},{"line_number":43,"context_line":"  include: start.yml"},{"line_number":44,"context_line":"  when: skip_start is not defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_c32b7432","line":41,"in_reply_to":"9abb7d3a_86e9201d","updated":"2016-06-04 10:00:12.000000000","message":"hi yes that was what i oringinally had actully but\ni notice that skip_install used an is not defined.\n\nill change to doing a boolean check everywhere i used an is not defined and default the value to false to have the same behaviour.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- name: \"bootstrap ironic\""},{"line_number":40,"context_line":"  include: bootstrap.yml"},{"line_number":41,"context_line":"  when: skip_bootstrap is not defined"},{"line_number":42,"context_line":"- name: \"start ironic serivces\""},{"line_number":43,"context_line":"  include: start.yml"},{"line_number":44,"context_line":"  when: skip_start is not defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_5dd719ed","line":42,"updated":"2016-06-06 23:11:04.000000000","message":"Typo here - should be \"services\"","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  when: skip_bootstrap is not defined"},{"line_number":42,"context_line":"- name: \"start ironic serivces\""},{"line_number":43,"context_line":"  include: start.yml"},{"line_number":44,"context_line":"  when: skip_start is not defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_66d35c60","line":44,"updated":"2016-06-03 15:04:07.000000000","message":"Same as above, would prefer to use boolean values for this.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"}],"playbooks/roles/bifrost-ironic-install/tasks/start.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  service: name\u003drabbitmq-server state\u003dstarted"},{"line_number":23,"context_line":"- name: \"start ironic-inspector\""},{"line_number":24,"context_line":"  include: inspector_start.yml"},{"line_number":25,"context_line":"  when: enable_inspector | bool"},{"line_number":26,"context_line":"- name: \"Start ironic-conductor\""},{"line_number":27,"context_line":"  service: name\u003dironic-conductor state\u003dstarted"},{"line_number":28,"context_line":"- name: \"Start ironic-api\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_261674f1","line":25,"updated":"2016-06-03 15:04:07.000000000","message":"Nit: We likely ought to to make that \"| bool \u003d\u003d true\"","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  service: name\u003dironic-api state\u003drestarted"},{"line_number":34,"context_line":"- name: \"Stop existing libvirt dnsmasq processes\""},{"line_number":35,"context_line":"  command: killall -w dnsmasq"},{"line_number":36,"context_line":"  when: \"{{testing|bool and include_dhcp_server|bool}}\""},{"line_number":37,"context_line":"- name: \"Ensure services are running with current config\""},{"line_number":38,"context_line":"  service: name\u003d{{ item }} state\u003drestarted"},{"line_number":39,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_06e890e1","line":36,"updated":"2016-06-03 15:04:07.000000000","message":"Nit: Similar to above.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6863fe1167b62e6501798e49318e1c9fe2c0adcb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  service: name\u003d{{ item }} state\u003drestarted"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dnsmasq"},{"line_number":46,"context_line":"  when: \"{{include_dhcp_server|bool}}\""},{"line_number":47,"context_line":"- name: \"Send services a reload signal\""},{"line_number":48,"context_line":"  service: name\u003d{{ item }} state\u003dreloaded"},{"line_number":49,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_c6ab2888","line":46,"updated":"2016-06-03 15:04:07.000000000","message":"Yeah, really thinking we need to follow-up patch and change these.","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"57630be2dfb24b7acc567545d3be882f26e7fc7c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  service: name\u003d{{ item }} state\u003drestarted"},{"line_number":44,"context_line":"  with_items:"},{"line_number":45,"context_line":"    - dnsmasq"},{"line_number":46,"context_line":"  when: \"{{include_dhcp_server|bool}}\""},{"line_number":47,"context_line":"- name: \"Send services a reload signal\""},{"line_number":48,"context_line":"  service: name\u003d{{ item }} state\u003dreloaded"},{"line_number":49,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_03b45cf0","line":46,"in_reply_to":"9abb7d3a_c6ab2888","updated":"2016-06-04 10:00:12.000000000","message":"sure i would be happy to have make a follow up patch.\n\ni was trying not to change any of the code i was splitting out\nbut if there are other low hanging fruit fixes i would be happy to do them as an addtional patch on top.\n\nshow the patch only fix this in these files or would you like me to go through all the roles and change all instances of \"| bool\" too  \"| bool \u003d\u003d true\"","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"}],"releasenotes/notes/decompose-ironic-install-role-75b9a431bba88bad.yaml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  The ironic install role has been split into 3 pahses."},{"line_number":4,"context_line":"  (install)   installs all ironic packages and dependencies"},{"line_number":5,"context_line":"  (bootstrap) the bootstrap pahse generates configs"},{"line_number":6,"context_line":"              and initalies the ironic db."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_9d2ea1f8","line":3,"updated":"2016-06-06 23:11:04.000000000","message":"s/pahses/phases/","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  The ironic install role has been split into 3 pahses."},{"line_number":4,"context_line":"  (install)   installs all ironic packages and dependencies"},{"line_number":5,"context_line":"  (bootstrap) the bootstrap pahse generates configs"},{"line_number":6,"context_line":"              and initalies the ironic db."},{"line_number":7,"context_line":"  (start)     starts all ironic services and dependencies."},{"line_number":8,"context_line":"  Each pahse is run by default and can be skiped by defining"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_5d4559b1","line":5,"updated":"2016-06-06 23:11:04.000000000","message":"s/pahse/phase/","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  The ironic install role has been split into 3 pahses."},{"line_number":4,"context_line":"  (install)   installs all ironic packages and dependencies"},{"line_number":5,"context_line":"  (bootstrap) the bootstrap pahse generates configs"},{"line_number":6,"context_line":"              and initalies the ironic db."},{"line_number":7,"context_line":"  (start)     starts all ironic services and dependencies."},{"line_number":8,"context_line":"  Each pahse is run by default and can be skiped by defining"},{"line_number":9,"context_line":"  skip_package_install,skip_bootstrap and skip_start respectivly."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_3d404da5","line":6,"updated":"2016-06-06 23:11:04.000000000","message":"s/initalies/initializes/","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  (bootstrap) the bootstrap pahse generates configs"},{"line_number":6,"context_line":"              and initalies the ironic db."},{"line_number":7,"context_line":"  (start)     starts all ironic services and dependencies."},{"line_number":8,"context_line":"  Each pahse is run by default and can be skiped by defining"},{"line_number":9,"context_line":"  skip_package_install,skip_bootstrap and skip_start respectivly."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_fd0c0596","line":8,"updated":"2016-06-06 23:11:04.000000000","message":"s/pahse/phase/ s/skiped/skipped/","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f7490825b91096115cdb5ed9b528adeac1286cd8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"              and initalies the ironic db."},{"line_number":7,"context_line":"  (start)     starts all ironic services and dependencies."},{"line_number":8,"context_line":"  Each pahse is run by default and can be skiped by defining"},{"line_number":9,"context_line":"  skip_package_install,skip_bootstrap and skip_start respectivly."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_1d22b101","line":9,"updated":"2016-06-06 23:11:04.000000000","message":"s/respectivly/respectively/","commit_id":"2d258d0bc6838783a3dcb7741c4fa02b5f8af1d5"}]}