)]}'
{"playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5ca877c8728ddae5aeca69ade21a7b4ac42a8456","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# TODO: Consider converting to ansible virt module."},{"line_number":16,"context_line":"---"},{"line_number":17,"context_line":"# NOTE(cinerama) openSUSE Tumbleweed \u0026 Leaf have different distribution"},{"line_number":18,"context_line":"# IDs which are not currently accounted for in Ansible, so adjust facts"},{"line_number":19,"context_line":"# so we can have shared defaults for the whole SuSE family."},{"line_number":20,"context_line":"# This change can be removed when the pull request at"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_f57f9e14","line":17,"updated":"2016-09-16 08:38:55.000000000","message":"s/Leaf/Leap/ :)","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"16cbf3938f7d360301187bc2b8ae3f30621e3539","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# TODO: Consider converting to ansible virt module."},{"line_number":16,"context_line":"---"},{"line_number":17,"context_line":"# NOTE(cinerama) openSUSE Tumbleweed \u0026 Leaf have different distribution"},{"line_number":18,"context_line":"# IDs which are not currently accounted for in Ansible, so adjust facts"},{"line_number":19,"context_line":"# so we can have shared defaults for the whole SuSE family."},{"line_number":20,"context_line":"# This change can be removed when the pull request at"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_de25af5c","line":17,"in_reply_to":"7a8ec9b2_f57f9e14","updated":"2016-09-20 16:33:23.000000000","message":"Done","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5ca877c8728ddae5aeca69ade21a7b4ac42a8456","unresolved":false,"context_lines":[{"line_number":22,"context_line":"- name: Ensure openSUSE Tumbleweed has the correct family"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":25,"context_line":"  when: ansible_os_family | search(\"openSUSE Tumbleweed\")"},{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_15b32aea","line":25,"updated":"2016-09-16 08:38:55.000000000","message":"Leap has different behaviors in Ansible as well. For example, in\n\n # ansible --version\nansible 1.9.3\n  configured module search path \u003d None\n\nThe reported ansible_os_family for Leap is\n\nansible localhost -m setup -a \"filter\u003dansible_os_family\"\nlocalhost | success \u003e\u003e {\n    \"ansible_facts\": {\n        \"ansible_os_family\": \"openSUSE Leap\"\n    }, \n    \"changed\": false\n}\n\nSo how about you change that to match all \"openSUSE\" strings?\n\nfor example\n\nwhen: ansible_os_family | search(\"openSUSE\")","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"16cbf3938f7d360301187bc2b8ae3f30621e3539","unresolved":false,"context_lines":[{"line_number":22,"context_line":"- name: Ensure openSUSE Tumbleweed has the correct family"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":25,"context_line":"  when: ansible_os_family | search(\"openSUSE Tumbleweed\")"},{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_fe28ab35","line":25,"in_reply_to":"7a8ec9b2_15b32aea","updated":"2016-09-20 16:33:23.000000000","message":"Done","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5ca877c8728ddae5aeca69ade21a7b4ac42a8456","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":25,"context_line":"  when: ansible_os_family | search(\"openSUSE Tumbleweed\")"},{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":29,"context_line":"  when: ansible_os_family | search(\"SUSE LINUX\")"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_95bf3aa9","line":26,"updated":"2016-09-16 08:38:55.000000000","message":"s/Leaf/Leap/","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"16cbf3938f7d360301187bc2b8ae3f30621e3539","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":25,"context_line":"  when: ansible_os_family | search(\"openSUSE Tumbleweed\")"},{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":29,"context_line":"  when: ansible_os_family | search(\"SUSE LINUX\")"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_ca4fad68","line":26,"in_reply_to":"7a8ec9b2_95bf3aa9","updated":"2016-09-20 16:33:23.000000000","message":"Done","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5ca877c8728ddae5aeca69ade21a7b4ac42a8456","unresolved":false,"context_lines":[{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":29,"context_line":"  when: ansible_os_family | search(\"SUSE LINUX\")"},{"line_number":30,"context_line":"- name: \"Update apt cache if Ubuntu/Debian\""},{"line_number":31,"context_line":"  apt:"},{"line_number":32,"context_line":"    update_cache: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_951bbac9","line":29,"updated":"2016-09-16 08:38:55.000000000","message":"As said above, not all ansible versions report \"SUSE LINUX\" for Leap. Perhaps we can combine the whole thing like this:\n\nwhen: (ansible_os_family | search(\"openSUSE\")) or\n      (ansible_os_family | search(\"SUSE\"))\n\nwhat do you think?","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"16cbf3938f7d360301187bc2b8ae3f30621e3539","unresolved":false,"context_lines":[{"line_number":26,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":27,"context_line":"  set_fact:"},{"line_number":28,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":29,"context_line":"  when: ansible_os_family | search(\"SUSE LINUX\")"},{"line_number":30,"context_line":"- name: \"Update apt cache if Ubuntu/Debian\""},{"line_number":31,"context_line":"  apt:"},{"line_number":32,"context_line":"    update_cache: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_3e1bf31d","line":29,"in_reply_to":"7a8ec9b2_951bbac9","updated":"2016-09-20 16:33:23.000000000","message":"Done","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"}],"playbooks/roles/bifrost-ironic-install/tasks/main.yml":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5ca877c8728ddae5aeca69ade21a7b4ac42a8456","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Ensure openSUSE Leaf has the correct family"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    ansible_os_family: \"Suse\""},{"line_number":28,"context_line":"  when: ansible_os_family | search(\"SUSE LINUX\")"},{"line_number":29,"context_line":"# NOTE(cinerama) dummy-defaults.yml is an empty defaults file. We use it"},{"line_number":30,"context_line":"# here to ensure that with_first_found won\u0027t fail should we not have"},{"line_number":31,"context_line":"# defaults for a particular distribution, version, etc."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_3556665c","line":28,"updated":"2016-09-16 08:38:55.000000000","message":"Similar concerns with what I said for playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml","commit_id":"8a8f1d7cf3dd3a07e2d03926b8dc4e2848d2c3ea"}]}