)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d4e96f547c37a2ec79f76ad1c9b5927889a42167","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding staging driver support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding Staging drivers install."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I80e0303a7f5cfe7ae955763090d93d32ccb8c66e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a6eadb0_2ae91e1b","line":10,"updated":"2016-12-13 11:41:02.000000000","message":"Wondered if we have a bug for this.","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"226157c1da0596055befda70b0842ff4bd3b61b5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding staging driver support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding Staging drivers install."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I80e0303a7f5cfe7ae955763090d93d32ccb8c66e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a6eadb0_57c7d111","line":10,"in_reply_to":"1a6eadb0_2ae91e1b","updated":"2016-12-13 17:10:54.000000000","message":"I do not believe there is one.","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"}],"README.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f1a223acbe8eb03164f57b1636234942a39847d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"to enable or disable cleaning as desired, however it is highly encouraged to"},{"line_number":193,"context_line":"utilize cleaning in any production environment."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"If you would like to install the ironic staging drivers, simply pass"},{"line_number":196,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e staging_drivers_include\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_7df73959","line":195,"updated":"2016-12-08 23:16:47.000000000","message":"Only someone involved with the project is really going to know what the staging drivers are.  a little more context would likely be a good idea.","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ff2fe89e526ffbd7dd4b578648d4c48421e65379","unresolved":false,"context_lines":[{"line_number":192,"context_line":"to enable or disable cleaning as desired, however it is highly encouraged to"},{"line_number":193,"context_line":"utilize cleaning in any production environment."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"If you would like to install the ironic staging drivers, simply pass"},{"line_number":196,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e staging_drivers_include\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a6eadb0_881d03c0","line":195,"in_reply_to":"3a71b18c_7df73959","updated":"2016-12-12 17:36:21.000000000","message":"Done","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f1a223acbe8eb03164f57b1636234942a39847d","unresolved":false,"context_lines":[{"line_number":196,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e staging_drivers_include\u003dtrue"},{"line_number":199,"context_line":" "},{"line_number":200,"context_line":"Manual CLI use"},{"line_number":201,"context_line":"--------------"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_7de01997","line":199,"updated":"2016-12-08 23:16:47.000000000","message":"nit: whitespace! :)","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ff2fe89e526ffbd7dd4b578648d4c48421e65379","unresolved":false,"context_lines":[{"line_number":196,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"  ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e staging_drivers_include\u003dtrue"},{"line_number":199,"context_line":" "},{"line_number":200,"context_line":"Manual CLI use"},{"line_number":201,"context_line":"--------------"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a6eadb0_a878fff9","line":199,"in_reply_to":"3a71b18c_7de01997","updated":"2016-12-12 17:36:21.000000000","message":"Done","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54b173981e0c243962093040fa9103dccc6e4b05","unresolved":false,"context_lines":[{"line_number":193,"context_line":"utilize cleaning in any production environment."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The ironic community maintains a repository additional of drivers outside ironic."},{"line_number":196,"context_line":"These drivers and information about them can be found `here \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_."},{"line_number":197,"context_line":"If you would like to install the ironic staging drivers, simply pass"},{"line_number":198,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a6eadb0_302b7132","line":196,"range":{"start_line":196,"start_character":69,"end_line":196,"end_character":79},"updated":"2016-12-12 19:20:56.000000000","message":"nit: should be git.openstack.org :)","commit_id":"0ae9a3304be44735e772f8786cf63f70db8a5ba2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d4e96f547c37a2ec79f76ad1c9b5927889a42167","unresolved":false,"context_lines":[{"line_number":193,"context_line":"utilize cleaning in any production environment."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The ironic community maintains a repository additional of drivers outside ironic."},{"line_number":196,"context_line":"These drivers and information about them can be found `here \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_."},{"line_number":197,"context_line":"If you would like to install the ironic staging drivers, simply pass"},{"line_number":198,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a6eadb0_0a32a2f1","line":196,"updated":"2016-12-13 11:41:02.000000000","message":"We should avoid links to github, and should use openstack.org instead http://git.openstack.org/cgit/openstack/ironic-staging-drivers/","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"226157c1da0596055befda70b0842ff4bd3b61b5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"utilize cleaning in any production environment."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"The ironic community maintains a repository additional of drivers outside ironic."},{"line_number":196,"context_line":"These drivers and information about them can be found `here \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_."},{"line_number":197,"context_line":"If you would like to install the ironic staging drivers, simply pass"},{"line_number":198,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a6eadb0_b7f825e7","line":196,"in_reply_to":"1a6eadb0_0a32a2f1","updated":"2016-12-13 17:10:54.000000000","message":"Done","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d4e96f547c37a2ec79f76ad1c9b5927889a42167","unresolved":false,"context_lines":[{"line_number":77,"context_line":"staging_drivers_git_folder: /opt/stack/ironic-staging-drivers"},{"line_number":78,"context_line":"ironicinspector_git_folder: /opt/stack/ironic-inspector"},{"line_number":79,"context_line":"ironicinspectorclient_git_folder: /opt/stack/python-ironic-inspector-client"},{"line_number":80,"context_line":"staging_drivers_git_url: https://github.com/openstack/ironic-staging-drivers"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Comma-separated list, in the format of a string, of drivers that are enabled"},{"line_number":83,"context_line":"# by default. This is intended to be a list of agent based drivers."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_8a7312b1","line":80,"updated":"2016-12-13 11:41:02.000000000","message":"ditto about git.openstack.org","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"226157c1da0596055befda70b0842ff4bd3b61b5","unresolved":false,"context_lines":[{"line_number":77,"context_line":"staging_drivers_git_folder: /opt/stack/ironic-staging-drivers"},{"line_number":78,"context_line":"ironicinspector_git_folder: /opt/stack/ironic-inspector"},{"line_number":79,"context_line":"ironicinspectorclient_git_folder: /opt/stack/python-ironic-inspector-client"},{"line_number":80,"context_line":"staging_drivers_git_url: https://github.com/openstack/ironic-staging-drivers"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Comma-separated list, in the format of a string, of drivers that are enabled"},{"line_number":83,"context_line":"# by default. This is intended to be a list of agent based drivers."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_572c314a","line":80,"in_reply_to":"1a6eadb0_8a7312b1","updated":"2016-12-13 17:10:54.000000000","message":"Done","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"}],"playbooks/roles/bifrost-ironic-install/tasks/staging_install.yml":[{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"fd1d20df5f0996d77d5695e5ee7cddc17d2b47ad","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    package\u003dironic-staging-drivers"},{"line_number":19,"context_line":"    state\u003dlatest"},{"line_number":20,"context_line":"    sourcedir\u003d{{ staging_drivers_git_folder }}"},{"line_number":21,"context_line":"    source_install\u003d{{ staging_drivers_source_install }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a71b18c_6f0cbc94","line":21,"updated":"2016-12-09 17:18:31.000000000","message":"some drivers has python-requirements.txt, i think them should be installed too.","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"533a09b7c045797c9d76e19706498735dacd1ef0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    package\u003dironic-staging-drivers"},{"line_number":19,"context_line":"    state\u003dlatest"},{"line_number":20,"context_line":"    sourcedir\u003d{{ staging_drivers_git_folder }}"},{"line_number":21,"context_line":"    source_install\u003d{{ staging_drivers_source_install }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a6eadb0_72aa511b","line":21,"in_reply_to":"1a6eadb0_5c51ec61","updated":"2016-12-12 18:20:40.000000000","message":"Followup: I did find the python-requirements in some drivers folders, I also found other-requirements.txt in at least one. I will talk to Lucas and see if we can standardize the naming and then we can put up a follow up patch that can install if the file is found.","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ff2fe89e526ffbd7dd4b578648d4c48421e65379","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    package\u003dironic-staging-drivers"},{"line_number":19,"context_line":"    state\u003dlatest"},{"line_number":20,"context_line":"    sourcedir\u003d{{ staging_drivers_git_folder }}"},{"line_number":21,"context_line":"    source_install\u003d{{ staging_drivers_source_install }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a6eadb0_5c51ec61","line":21,"in_reply_to":"3a71b18c_33e302db","updated":"2016-12-12 17:36:21.000000000","message":"I have looked at the *requirements.txt files and do see a python-requirments file. What I do see is requirement.txt, test-requirments.txt, and extra-requirments.txt none of which appear to have driver requirementsin them. I am happy to change the code, but would like to discuss how to do this. And address it with a followup patch.","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9afa0f0efaa57d35e6f40ae2b5aa855ae00f7277","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    package\u003dironic-staging-drivers"},{"line_number":19,"context_line":"    state\u003dlatest"},{"line_number":20,"context_line":"    sourcedir\u003d{{ staging_drivers_git_folder }}"},{"line_number":21,"context_line":"    source_install\u003d{{ staging_drivers_source_install }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a71b18c_33e302db","line":21,"in_reply_to":"3a71b18c_6f0cbc94","updated":"2016-12-09 23:45:25.000000000","message":"Agree, and this is something I was pondering initially as well.  That would require it to be aware of what each driver is and/or to enumerate into each folder, find and install the requirements from each driver.  Sadly pip doesn\u0027t just do it for us. :(","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"}],"releasenotes/notes/support-staging-drivers-1c398a56dde9b240.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f1a223acbe8eb03164f57b1636234942a39847d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Ironic-Staging-Drivers can now be installed. To install"},{"line_number":4,"context_line":"    the staging drivers set `staging_drivers_include` to"},{"line_number":5,"context_line":"    true. The default value is false."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a71b18c_3d84e1af","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":26},"updated":"2016-12-08 23:16:47.000000000","message":"Same as the readme.  What are these staging drivers?  Where do they come from?  Etc.\n\nAlso, perhaps start with \"The\", and leave the repo name all lower case?","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ff2fe89e526ffbd7dd4b578648d4c48421e65379","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Ironic-Staging-Drivers can now be installed. To install"},{"line_number":4,"context_line":"    the staging drivers set `staging_drivers_include` to"},{"line_number":5,"context_line":"    true. The default value is false."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a6eadb0_df516e10","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":26},"in_reply_to":"3a71b18c_3d84e1af","updated":"2016-12-12 17:36:21.000000000","message":"Done","commit_id":"e192240855c237a37ab7ff86c124a95cf47bf117"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54b173981e0c243962093040fa9103dccc6e4b05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Ironic-Staging-Drivers can now be installed. These are "},{"line_number":4,"context_line":"    drivers that are not included in the ironic repo, and"},{"line_number":5,"context_line":"    provide additional hardware support for ironic. More"},{"line_number":6,"context_line":"    information about the drivers can be found at"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a6eadb0_5020ed49","line":3,"updated":"2016-12-12 19:20:56.000000000","message":"bah!  whitespace!","commit_id":"0ae9a3304be44735e772f8786cf63f70db8a5ba2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54b173981e0c243962093040fa9103dccc6e4b05","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    provide additional hardware support for ironic. More"},{"line_number":6,"context_line":"    information about the drivers can be found at"},{"line_number":7,"context_line":"    `Ironic-Staging-Drivers \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_"},{"line_number":8,"context_line":"    To install the staging drivers set `staging_drivers_include`"},{"line_number":9,"context_line":"    to true. The default value is false."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a6eadb0_901a8516","line":8,"range":{"start_line":8,"start_character":39,"end_line":8,"end_character":40},"updated":"2016-12-12 19:20:56.000000000","message":"Style wise, I think ``, but *shrug*","commit_id":"0ae9a3304be44735e772f8786cf63f70db8a5ba2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d4e96f547c37a2ec79f76ad1c9b5927889a42167","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers that are not included in the ironic repo, and"},{"line_number":5,"context_line":"    provide additional hardware support for ironic. More"},{"line_number":6,"context_line":"    information about the drivers can be found at"},{"line_number":7,"context_line":"    `Ironic-Staging-Drivers \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_"},{"line_number":8,"context_line":"    To install the staging drivers set `staging_drivers_include`"},{"line_number":9,"context_line":"    to true. The default value is false."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_6a7cf672","line":7,"updated":"2016-12-13 11:41:02.000000000","message":"ditto about link to github.","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"226157c1da0596055befda70b0842ff4bd3b61b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers that are not included in the ironic repo, and"},{"line_number":5,"context_line":"    provide additional hardware support for ironic. More"},{"line_number":6,"context_line":"    information about the drivers can be found at"},{"line_number":7,"context_line":"    `Ironic-Staging-Drivers \u003chttps://github.com/openstack/ironic-staging-drivers\u003e`_"},{"line_number":8,"context_line":"    To install the staging drivers set `staging_drivers_include`"},{"line_number":9,"context_line":"    to true. The default value is false."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_d7ca014f","line":7,"in_reply_to":"1a6eadb0_6a7cf672","updated":"2016-12-13 17:10:54.000000000","message":"Done","commit_id":"7ee58f71f23d58fb910d767d639d244ad24af574"}]}