)]}'
{"playbooks/roles/bifrost-prep-for-install/defaults/main.yml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"ac855f20459ac329ff0eec6f2350814e163d004c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ironicinspectorclient_git_url: https://github.com/openstack/python-ironic-inspector-client"},{"line_number":11,"context_line":"reqs_git_url: https://git.openstack.org/openstack/requirements"},{"line_number":12,"context_line":"staging_drivers_git_url: https://git.openstack.org/openstack/ironic-staging-drivers"},{"line_number":13,"context_line":"keystone_git_url: https://git.openstack.org/openstack/keystone"},{"line_number":14,"context_line":"# *_git_folder can be overridden by local clones for offline installs"},{"line_number":15,"context_line":"ironicclient_git_folder: \"{{ git_root}}/python-ironicclient\""},{"line_number":16,"context_line":"ironic_git_folder: \"{{ git_root}}/ironic\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a3c09a3_fa3a87cc","line":13,"range":{"start_line":13,"start_character":18,"end_line":13,"end_character":23},"updated":"2017-01-13 20:15:16.000000000","message":"while not exactly for this patch, a general comment would be\n\nwhy are we cloning everything over https by default? native git:// protocol is faster and is enabled on git.openstack.org.\n\njust an idea for another patch","commit_id":"a493cc923ef6b3ad2d1e5a0b800d73529637be39"}],"playbooks/test-bifrost-dhcp.yaml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f5dc231feb2302cafb924b47578406531a6946d4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":42,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":43,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":44,"context_line":"         keystone_git_url: https://git.openstack.org/openstack/keystone"},{"line_number":45,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":46,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"},{"line_number":47,"context_line":"      # folder cloned, while the gate job does not.  Likely need to work out a semi-hybrid"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_3c39e7f2","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":71},"updated":"2016-12-15 15:54:48.000000000","message":"This looks wrong because the other repositories are set up to come from the workspace. Is there a reason why this is set as it is here?","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0abc685f3f9b784ff1d2f78eb2276c47e78878e8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":42,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":43,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":44,"context_line":"         keystone_git_url: https://git.openstack.org/openstack/keystone"},{"line_number":45,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":46,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"},{"line_number":47,"context_line":"      # folder cloned, while the gate job does not.  Likely need to work out a semi-hybrid"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da4df55a_8cca364e","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":71},"in_reply_to":"1a6eadb0_3c39e7f2","updated":"2016-12-22 15:09:24.000000000","message":"We have to change the workspace for it to be in the workspace, if that makes sense.  We might be able to get from /opt/git/openstack/, however that is from when the image is built by zuul which could be out of date.","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"}],"playbooks/test-bifrost-dynamic.yaml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f5dc231feb2302cafb924b47578406531a6946d4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":24,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":25,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":26,"context_line":"         keystone_git_url: https://git.openstack.org/openstack/keystone"},{"line_number":27,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":28,"context_line":"         staging_drivers_git_url: \"/opt/git/openstack/ironic-staging-drivers\""},{"line_number":29,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_3f6c79cf","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":71},"updated":"2016-12-15 15:54:48.000000000","message":"Same comment as per test-bifrost-dhcp playbook. BTW, these playbooks have been superseded in favour of test-bifrost.yaml which incorporates all their functionality and is what is currently used for CI.","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0abc685f3f9b784ff1d2f78eb2276c47e78878e8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":24,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":25,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":26,"context_line":"         keystone_git_url: https://git.openstack.org/openstack/keystone"},{"line_number":27,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":28,"context_line":"         staging_drivers_git_url: \"/opt/git/openstack/ironic-staging-drivers\""},{"line_number":29,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da4df55a_8cd156fe","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":71},"in_reply_to":"1a6eadb0_3f6c79cf","updated":"2016-12-22 15:09:24.000000000","message":"Same reply + we likely ought to split out a giant debug at the beginning or just kill it.  I do believe you mentioned it in a release note.","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"}],"playbooks/test-bifrost.yaml":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f5dc231feb2302cafb924b47578406531a6946d4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":36,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":37,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":38,"context_line":"         keystone_git_url: \"/opt/git/openstack/keystone\""},{"line_number":39,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":40,"context_line":"         staging_drivers_git_url: \"/opt/git/openstack/ironic-staging-drivers\""},{"line_number":41,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_7f98b1c0","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":56},"updated":"2016-12-15 15:54:48.000000000","message":"Same comment as for the other playbooks.","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0abc685f3f9b784ff1d2f78eb2276c47e78878e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"         dib_git_url: \"/opt/git/openstack/diskimage-builder\""},{"line_number":36,"context_line":"         ironicinspector_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/ironic-inspector\""},{"line_number":37,"context_line":"         ironicinspectorclient_git_url: \"{{ lookup(\u0027env\u0027, \u0027WORKSPACE\u0027) }}/openstack/python-ironic-inspector-client\""},{"line_number":38,"context_line":"         keystone_git_url: \"/opt/git/openstack/keystone\""},{"line_number":39,"context_line":"         reqs_git_url: \"/opt/git/openstack/requirements\""},{"line_number":40,"context_line":"         staging_drivers_git_url: \"/opt/git/openstack/ironic-staging-drivers\""},{"line_number":41,"context_line":"      # TODO(TheJulia) Fix the above paths to be consistent, because the NV job gets the dib"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da4df55a_ecd82220","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":56},"in_reply_to":"1a6eadb0_7f98b1c0","updated":"2016-12-22 15:09:24.000000000","message":"Same reply :)","commit_id":"ef92b7c36c894d09d871762a9b6baefa415c31e3"}]}
