)]}'
{"playbooks/roles/bifrost-ironic-install/README.md":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5a4f7db9a3fefebd3026e8891b3844e14970277d","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Please see defaults/main.yml file for the structure named \"ironic\"."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Simillarlly, if hardware introspection support is installed, the"},{"line_number":251,"context_line":"nearly identical data structure for it can be found in the same file"},{"line_number":252,"context_line":"named \"ironic_inspector\"."},{"line_number":253,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"ba2be162_ba7a5def","line":250,"range":{"start_line":250,"start_character":0,"end_line":250,"end_character":11},"updated":"2017-03-03 08:47:08.000000000","message":"similarly","commit_id":"d40ad14a8a7bccce6ef9585885314d3f2843a1e2"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5a4f7db9a3fefebd3026e8891b3844e14970277d","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Simillarlly, if hardware introspection support is installed, the"},{"line_number":251,"context_line":"nearly identical data structure for it can be found in the same file"},{"line_number":252,"context_line":"named \"ironic_inspector\"."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Notes"},{"line_number":255,"context_line":"-----"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"ba2be162_baefbd85","line":252,"range":{"start_line":252,"start_character":23,"end_line":252,"end_character":25},"updated":"2017-03-03 08:47:08.000000000","message":"i think you could be more explicit here, and mention you can set {ironic,ironic_conductor,keystone}.{database,user,password,host} vars","commit_id":"d40ad14a8a7bccce6ef9585885314d3f2843a1e2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dfe82e0e92120fd15f03434a652ab00e1df037b5","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Simillarlly, if hardware introspection support is installed, the"},{"line_number":251,"context_line":"nearly identical data structure for it can be found in the same file"},{"line_number":252,"context_line":"named \"ironic_inspector\"."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Notes"},{"line_number":255,"context_line":"-----"}],"source_content_type":"text/x-gfm","patch_set":4,"id":"ba2be162_7b27f5c9","line":252,"range":{"start_line":252,"start_character":23,"end_line":252,"end_character":25},"in_reply_to":"ba2be162_baefbd85","updated":"2017-03-03 16:42:59.000000000","message":"I would kind of love to, but if you define one, they all have to be defined at one time.","commit_id":"d40ad14a8a7bccce6ef9585885314d3f2843a1e2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d34c11dbbd1400b259a40c98732d759bbaf5ba5a","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"### Changing Database Configuration"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Bifrost utilizes a nested data stucture for the configuration of database"},{"line_number":245,"context_line":"and keystone related configuration which is not detailed at a level of"},{"line_number":246,"context_line":"fine detail as individual items cannot be overriden via set_fact."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Please see defaults/main.yml file for the structure named \"ironic\"."},{"line_number":249,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"ba2be162_fc5d517a","line":246,"range":{"start_line":244,"start_character":0,"end_line":246,"end_character":65},"updated":"2017-03-06 17:32:42.000000000","message":"This is a tuff to comprehend as worded. \nmaybe: s/related configuration//","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a023bfc265939d9b38396604aa3bf7824bc23e47","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"### Changing Database Configuration"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Bifrost utilizes a nested data stucture for the configuration of database"},{"line_number":245,"context_line":"and keystone related configuration which is not detailed at a level of"},{"line_number":246,"context_line":"fine detail as individual items cannot be overriden via set_fact."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Please see defaults/main.yml file for the structure named \"ironic\"."},{"line_number":249,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"ffe62b97_486e41c9","line":246,"range":{"start_line":244,"start_character":0,"end_line":246,"end_character":65},"in_reply_to":"ba2be162_f7eacaab","updated":"2017-03-29 23:41:36.000000000","message":"Will do!","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"c450052a8e152e2995ef6dd4669c70969351bf0e","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"### Changing Database Configuration"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"Bifrost utilizes a nested data stucture for the configuration of database"},{"line_number":245,"context_line":"and keystone related configuration which is not detailed at a level of"},{"line_number":246,"context_line":"fine detail as individual items cannot be overriden via set_fact."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Please see defaults/main.yml file for the structure named \"ironic\"."},{"line_number":249,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":5,"id":"ba2be162_f7eacaab","line":246,"range":{"start_line":244,"start_character":0,"end_line":246,"end_character":65},"in_reply_to":"ba2be162_fc5d517a","updated":"2017-03-06 17:53:27.000000000","message":"I agree that this has some redundant phrasing that makes it confusing. I think the key takeaways here are: there is a nested data structure for the database and keystone configuration and that individual items within this structure cannot be overridden via set_fact (and presumably -e as well?). So perhaps we could simplify this to something along those lines.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1f5472c5cec5b32735cb60e698996a03946a8199","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  - Values cannot be overrriden via set_fact."},{"line_number":248,"context_line":"  - Values cannot be overrriden via the command line with ``-e``."},{"line_number":249,"context_line":"  - The entire data structure must be defined it is modified."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Please see defaults/main.yml file for the structure named ``ironic``."},{"line_number":252,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":7,"id":"bff0334d_9423cd05","line":249,"range":{"start_line":249,"start_character":46,"end_line":249,"end_character":48},"updated":"2017-04-07 16:00:38.000000000","message":"should this be `if`?","commit_id":"c932949c02d84010ba75c7f70583828f401bdc85"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"35b40cb93820b0e67ef0e619725adacc830290f7","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Please note, if the hostname is set to something besides``localhost``,"},{"line_number":254,"context_line":"then the playbook will not attempt to create databases, database users,"},{"line_number":255,"context_line":"and grant privilges."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Similarly, if hardware introspection support is installed, the"},{"line_number":258,"context_line":"nearly identical data structure for inspector can be found in the"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"bff0334d_2c6ecec8","line":255,"range":{"start_line":255,"start_character":16,"end_line":255,"end_character":17},"updated":"2017-04-10 13:27:45.000000000","message":"privileges","commit_id":"c932949c02d84010ba75c7f70583828f401bdc85"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5a4f7db9a3fefebd3026e8891b3844e14970277d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    username: \"inspector\""},{"line_number":233,"context_line":"    password: \"{{ ironic_db_password }}\""},{"line_number":234,"context_line":"    host: \"localhost\""},{"line_number":235,"context_line":"    # DEPRECAED(TheJulia): Inheratance of ironic_db_password params"},{"line_number":236,"context_line":"    # should be removed in Queens."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_3a6f4d2c","line":235,"range":{"start_line":235,"start_character":6,"end_line":235,"end_character":15},"updated":"2017-03-03 08:47:08.000000000","message":"deprecated, inheritance","commit_id":"d40ad14a8a7bccce6ef9585885314d3f2843a1e2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"c450052a8e152e2995ef6dd4669c70969351bf0e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    name: \"ironic\""},{"line_number":217,"context_line":"    username: \"ironic\""},{"line_number":218,"context_line":"    password: \"{{ ironic_db_password }}\""},{"line_number":219,"context_line":"    host: \"localhost\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"ironic_inspector:"},{"line_number":222,"context_line":"  service_catalog:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_176cbe35","line":219,"updated":"2017-03-06 17:53:27.000000000","message":"We could allow the user to specify a port for the database here.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a023bfc265939d9b38396604aa3bf7824bc23e47","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    name: \"ironic\""},{"line_number":217,"context_line":"    username: \"ironic\""},{"line_number":218,"context_line":"    password: \"{{ ironic_db_password }}\""},{"line_number":219,"context_line":"    host: \"localhost\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"ironic_inspector:"},{"line_number":222,"context_line":"  service_catalog:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_3d3c61df","line":219,"in_reply_to":"ba2be162_176cbe35","updated":"2017-03-29 23:41:36.000000000","message":"That is a really good point.  Although I think we would have to assert a default, when an user could define it directly.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"}],"playbooks/roles/bifrost-ironic-install/tasks/inspector_bootstrap.yml":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d34c11dbbd1400b259a40c98732d759bbaf5ba5a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    name: \"{{ ironic_inspector.database.name }}\""},{"line_number":21,"context_line":"    state: present"},{"line_number":22,"context_line":"    encoding: utf8"},{"line_number":23,"context_line":"  when: ironic_inspector.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: \"MySQL - Create user for inspector\""},{"line_number":26,"context_line":"  mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_3c5a8951","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":53},"updated":"2017-03-06 17:32:42.000000000","message":"not 100% sure we need to limit to only localhost, but am willing to go along with it if others are okay with it.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a023bfc265939d9b38396604aa3bf7824bc23e47","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    name: \"{{ ironic_inspector.database.name }}\""},{"line_number":21,"context_line":"    state: present"},{"line_number":22,"context_line":"    encoding: utf8"},{"line_number":23,"context_line":"  when: ironic_inspector.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: \"MySQL - Create user for inspector\""},{"line_number":26,"context_line":"  mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_a815cd3e","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":53},"in_reply_to":"ba2be162_3c5a8951","updated":"2017-03-29 23:41:36.000000000","message":"I think it is the best route.  Whenever I\u0027ve set a remote database, I\u0027ve always had to prepare the user/password, database, and rights in advance.  We do it as a favor to users when on localhost, which kind of makes sense, but not in a larger context. \u003c/rambling\u003e","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"c450052a8e152e2995ef6dd4669c70969351bf0e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    password: \"{{ ironic_inspector.database.password }}\""},{"line_number":31,"context_line":"    priv: \"{{ ironic_inspector.database.name }}.*:ALL\""},{"line_number":32,"context_line":"    state: present"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: \"Inspector - Ensure /etc/ironic-inspector/ exists\""},{"line_number":35,"context_line":"  file:"},{"line_number":36,"context_line":"    dest\u003d/etc/ironic-inspector"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_020d5e37","line":33,"updated":"2017-03-06 17:53:27.000000000","message":"no \"when\" here - do we always want to do this?","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a023bfc265939d9b38396604aa3bf7824bc23e47","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    password: \"{{ ironic_inspector.database.password }}\""},{"line_number":31,"context_line":"    priv: \"{{ ironic_inspector.database.name }}.*:ALL\""},{"line_number":32,"context_line":"    state: present"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: \"Inspector - Ensure /etc/ironic-inspector/ exists\""},{"line_number":35,"context_line":"  file:"},{"line_number":36,"context_line":"    dest\u003d/etc/ironic-inspector"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_4820819b","line":33,"in_reply_to":"ba2be162_020d5e37","updated":"2017-03-29 23:41:36.000000000","message":"Great catch!","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"}],"playbooks/roles/bifrost-keystone-install/tasks/bootstrap.yml":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d34c11dbbd1400b259a40c98732d759bbaf5ba5a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":79,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":80,"context_line":"  register: test_created_keystone_db"},{"line_number":81,"context_line":"  when: keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: \"MySQL - Creating user for keystone\""},{"line_number":84,"context_line":"  mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_17391ed9","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":45},"updated":"2017-03-06 17:32:42.000000000","message":"again not sure we need to limit to just local host.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"c450052a8e152e2995ef6dd4669c70969351bf0e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":79,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":80,"context_line":"  register: test_created_keystone_db"},{"line_number":81,"context_line":"  when: keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: \"MySQL - Creating user for keystone\""},{"line_number":84,"context_line":"  mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_e26ccad2","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":45},"in_reply_to":"ba2be162_17391ed9","updated":"2017-03-06 17:53:27.000000000","message":"We could check whether this exists already remotely with a shell command I guess.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a023bfc265939d9b38396604aa3bf7824bc23e47","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":79,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":80,"context_line":"  register: test_created_keystone_db"},{"line_number":81,"context_line":"  when: keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: \"MySQL - Creating user for keystone\""},{"line_number":84,"context_line":"  mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_e83d15bb","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":45},"in_reply_to":"ba2be162_e26ccad2","updated":"2017-03-29 23:41:36.000000000","message":"I dunno.  I kind of feel like it is just not the right thing to be asserting changes on remote hosts that we were not asked to make, and we shouldn\u0027t be firing similar commands off across multiple hosts unless we\u0027re doing things like host entries for sql access..... I really don\u0027t know.","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d34c11dbbd1400b259a40c98732d759bbaf5ba5a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    state: present"},{"line_number":89,"context_line":"    login_user: \"{{ mysql_username | default(None) }}\""},{"line_number":90,"context_line":"    login_password: \"{{ mysql_password | default(None) }}\""},{"line_number":91,"context_line":"  when: keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: \"Create an keystone service group\""},{"line_number":94,"context_line":"  group:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_573396f6","line":91,"range":{"start_line":91,"start_character":2,"end_line":91,"end_character":45},"updated":"2017-03-06 17:32:42.000000000","message":"ditto","commit_id":"cbd4ff59231ed5238d59434880b94ffa307003b0"}],"releasenotes/notes/mysql-database-separation-d6bf9a4f22cd8bbb.yaml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"5a4f7db9a3fefebd3026e8891b3844e14970277d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Bifrost now supports the definition of a specific database server,"},{"line_number":5,"context_line":"    username, password, and database name for ironic and ironic-inspector."},{"line_number":6,"context_line":"  - |  "},{"line_number":7,"context_line":"    If the host for the database is not set to ``localhost``, then actions"},{"line_number":8,"context_line":"    such as database and user creation are skipped. This functionality"},{"line_number":9,"context_line":"    is present in both the bootstrapping for ironic, ironic-inspector, and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba2be162_bac89d23","line":6,"updated":"2017-03-03 08:47:08.000000000","message":"extra whitespace","commit_id":"d40ad14a8a7bccce6ef9585885314d3f2843a1e2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"1f5472c5cec5b32735cb60e698996a03946a8199","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    If the host for the database is not set to ``localhost``, then actions"},{"line_number":8,"context_line":"    such as database and user creation are skipped. This functionality"},{"line_number":9,"context_line":"    is present in both the bootstrapping for ironic, ironic-inspector, and"},{"line_number":10,"context_line":"    keystone, and applies to initial explicit database schema creation steps"},{"line_number":11,"context_line":"    where applicable."},{"line_number":12,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bff0334d_2f882e6f","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":22},"updated":"2017-04-07 16:00:38.000000000","message":"there are three items so maybe s/both//","commit_id":"c932949c02d84010ba75c7f70583828f401bdc85"}]}