)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9ba516c2c9c136151ecb034dafcf98bb5074177","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  template: src\u003dnginx.conf.j2 dest\u003d/etc/nginx/nginx.conf"},{"line_number":225,"context_line":"- name: \"Ensure inspector object storage directory exists\""},{"line_number":226,"context_line":"  file:"},{"line_number":227,"context_line":"    path: \"{{ http_boot_folder }}/ironic-inspector\""},{"line_number":228,"context_line":"    state: directory"},{"line_number":229,"context_line":"    owner: \"{{ nginx_user }}\""},{"line_number":230,"context_line":"    group: \"{{ nginx_user }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5ff73747_85ac6aed","line":227,"range":{"start_line":227,"start_character":11,"end_line":227,"end_character":33},"updated":"2017-04-28 12:30:19.000000000","message":"Should we be storing this under the /httpboot/ folder?","commit_id":"d7ddb3d17ad36e6d945c04a55ec6f8f3b7868964"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8acd73cf9922ff375bcd9934c16992992bff173f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"      command: semanage fcontext -a -t httpd_sys_rw_content_t \"{{ http_boot_folder }}/ironic-inspector(/.*)?\""},{"line_number":343,"context_line":"      when:"},{"line_number":344,"context_line":"        - enable_inspector | bool"},{"line_number":345,"context_line":"        - inspector_store_data_in_nginx | bool"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    - name: \"Restore SELinux context on the http_boot directory\""},{"line_number":348,"context_line":"      command: restorecon -r {{ http_boot_folder }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9dbf25_75a0c8a6","line":345,"updated":"2018-02-27 14:45:41.000000000","message":"I guess we ought to be using sefcontext here too","commit_id":"8de9453dad89fcef17dfdcaba212b1e8f61e5bcb"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"49f58c50825e014da058b6bdc6c86bb67a79bfa0","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        - inspector_store_data_in_nginx | bool"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    - name: \"Restore SELinux context on the http_boot directory\""},{"line_number":348,"context_line":"      command: restorecon -r {{ http_boot_folder }}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    - name: Copy ironic policy file to temporary directory"},{"line_number":351,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9dbf25_6aef8787","line":348,"range":{"start_line":348,"start_character":6,"end_line":348,"end_character":13},"updated":"2018-02-27 14:23:10.000000000","message":"this will need the condition for enable_inspector and inspector_store_data_in_nginx as well?","commit_id":"8de9453dad89fcef17dfdcaba212b1e8f61e5bcb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4c1e77249384ce390b0459962a7588d8d35aa15c","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        - inspector_store_data_in_nginx | bool"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    - name: \"Restore SELinux context on the http_boot directory\""},{"line_number":348,"context_line":"      command: restorecon -r {{ http_boot_folder }}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    - name: Copy ironic policy file to temporary directory"},{"line_number":351,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9dbf25_d5a8bc78","line":348,"range":{"start_line":348,"start_character":6,"end_line":348,"end_character":13},"in_reply_to":"1f9dbf25_157aa423","updated":"2018-02-27 14:54:34.000000000","message":"Hmm, from man semanage-fcontext:\n\n       remember to run restorecon after you set the file context\n       Add file-context for everything under /web\n       # semanage fcontext -a -t httpd_sys_content_t \"/web(/.*)?\"\n       # restorecon -R -v /web\n\nThe ansible module [1] accepts a reload argument, which defaults to True. I\u0027ll use that module, and it should mean we can remove the restorecon.\n\n[1] http://docs.ansible.com/ansible/latest/sefcontext_module.html","commit_id":"8de9453dad89fcef17dfdcaba212b1e8f61e5bcb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8acd73cf9922ff375bcd9934c16992992bff173f","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        - inspector_store_data_in_nginx | bool"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    - name: \"Restore SELinux context on the http_boot directory\""},{"line_number":348,"context_line":"      command: restorecon -r {{ http_boot_folder }}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    - name: Copy ironic policy file to temporary directory"},{"line_number":351,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9dbf25_b5c89074","line":348,"range":{"start_line":348,"start_character":6,"end_line":348,"end_character":13},"in_reply_to":"1f9dbf25_6aef8787","updated":"2018-02-27 14:45:41.000000000","message":"I think it\u0027s ok like this, as it will apply configured SELinux policies to this directory in all cases. Perhaps the sefcontext module does this anyway? My SELinux-fu isn\u0027t that strong.","commit_id":"8de9453dad89fcef17dfdcaba212b1e8f61e5bcb"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"6c5e8c12d6cd85a309c05f78dc3d3a2946723d37","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        - inspector_store_data_in_nginx | bool"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    - name: \"Restore SELinux context on the http_boot directory\""},{"line_number":348,"context_line":"      command: restorecon -r {{ http_boot_folder }}"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    - name: Copy ironic policy file to temporary directory"},{"line_number":351,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9dbf25_157aa423","line":348,"range":{"start_line":348,"start_character":6,"end_line":348,"end_character":13},"in_reply_to":"1f9dbf25_b5c89074","updated":"2018-02-27 14:48:01.000000000","message":"Yep, it will not hurt, but not needed, as it will be just reapplying the policies that are already on the system","commit_id":"8de9453dad89fcef17dfdcaba212b1e8f61e5bcb"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"4f950ab9008414dfbcbd383e026de04b373abd55","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        setype: httpd_sys_content_t"},{"line_number":339,"context_line":"        state: present"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    - name: \"Add proper context on inspector data store\""},{"line_number":342,"context_line":"      sefcontext:"},{"line_number":343,"context_line":"        target: \"{{ http_boot_folder }}/ironic-inspector(/.*)?\""},{"line_number":344,"context_line":"        setype: httpd_sys_rw_content_t"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f9dbf25_a73b859a","line":341,"range":{"start_line":341,"start_character":0,"end_line":341,"end_character":4},"updated":"2018-02-27 16:32:15.000000000","message":"it looks more clear now, thx. My concern with the older restorecon, is that it was applied unconditionally, not just when enable_inspector and inspector_store_data_in_nginx was true, so it was carrying unnecessary work","commit_id":"507228a22877c5a4af8c9c7668c228f1c967fa78"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"43b4fa4ab43d104765d98da735989ae49eeb135b","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        setype: httpd_sys_content_t"},{"line_number":339,"context_line":"        state: present"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    - name: \"Add proper context on inspector data store\""},{"line_number":342,"context_line":"      sefcontext:"},{"line_number":343,"context_line":"        target: \"{{ http_boot_folder }}/ironic-inspector(/.*)?\""},{"line_number":344,"context_line":"        setype: httpd_sys_rw_content_t"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f9dbf25_67133d0f","line":341,"range":{"start_line":341,"start_character":0,"end_line":341,"end_character":4},"in_reply_to":"1f9dbf25_a73b859a","updated":"2018-02-27 16:34:09.000000000","message":"Got it, thanks.","commit_id":"507228a22877c5a4af8c9c7668c228f1c967fa78"}],"playbooks/roles/bifrost-ironic-install/templates/nginx.conf.j2":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9ba516c2c9c136151ecb034dafcf98bb5074177","unresolved":false,"context_lines":[{"line_number":47,"context_line":"\t\t\talias {{ http_boot_folder }}/;"},{"line_number":48,"context_line":"\t\t}"},{"line_number":49,"context_line":"{% if inspector_store_data_in_nginx | bool %}"},{"line_number":50,"context_line":"                location /ironic-inspector {"},{"line_number":51,"context_line":"                        return 200 \"\";"},{"line_number":52,"context_line":"                }"},{"line_number":53,"context_line":"                location /ironic-inspector/ {"},{"line_number":54,"context_line":"                        dav_methods  PUT DELETE;"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5ff73747_25d59644","line":51,"range":{"start_line":50,"start_character":16,"end_line":51,"end_character":38},"updated":"2017-04-28 12:30:19.000000000","message":"I guess this makes /httpboot/ okay for the storage folder, since AIUI it will block the ability to list, a user would have to  know the file names in advance, which in bifrost\u0027s use case is acceptable I guess.","commit_id":"d7ddb3d17ad36e6d945c04a55ec6f8f3b7868964"}],"playbooks/roles/bifrost-test-inspection/tasks/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fb8a6809534e8ccf047babd5a716196dc57fe706","unresolved":false,"context_lines":[{"line_number":14,"context_line":"---"},{"line_number":15,"context_line":"# TODO(mgoddard): Ideally we would grab inspection data from ironic inspector"},{"line_number":16,"context_line":"# rather than going direct to the web server. That would require either"},{"line_number":17,"context_line":"# installing python-openstackclient, or creating an ansible module that uses"},{"line_number":18,"context_line":"# python-ironic-inspector-client."},{"line_number":19,"context_line":"- block:"},{"line_number":20,"context_line":"    - name: Check node hardware inspection data"},{"line_number":21,"context_line":"      uri:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df7087c5_e720a0fa","line":18,"range":{"start_line":17,"start_character":52,"end_line":18,"end_character":33},"updated":"2018-03-07 14:09:43.000000000","message":"Or one that uses shade that performs the necessary rest calls to inspector\u0027s API.","commit_id":"507228a22877c5a4af8c9c7668c228f1c967fa78"}]}
