)]}'
{"playbooks/roles/bifrost-create-vm-nodes/tasks/create_vm.yml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ca85679d6ae60b72fedc8b46a571b521e796bdf2","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  - name: create tap interface"},{"line_number":77,"context_line":"    command: ip tuntap add dev \"tap-{{ vm_name }}\" mode tap"},{"line_number":78,"context_line":"    ignore_errors: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - name: set tap interface up"},{"line_number":81,"context_line":"    command: ip link set \"tap-{{ vm_name }}\" up"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa0c359_51e1f799","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":17},"updated":"2018-02-06 10:01:16.000000000","message":"why do you ignore errors here?","commit_id":"458b452620648ad5d28bedb939ee75573250f2f7"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/prepare_libvirt.yml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ca85679d6ae60b72fedc8b46a571b521e796bdf2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    name: \"{{ test_vm_network }}\""},{"line_number":63,"context_line":"    state: absent"},{"line_number":64,"context_line":"    uri: \"{{ test_vm_libvirt_uri }}\""},{"line_number":65,"context_line":"  # NOTE(TheJulia): This errors if not found. :("},{"line_number":66,"context_line":"  ignore_errors: true"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: ensure libvirt network is present"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa0c359_f194c3ea","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":17},"updated":"2018-02-06 10:01:16.000000000","message":"is it possible to check if the network exists and remove only if does?","commit_id":"458b452620648ad5d28bedb939ee75573250f2f7"}],"playbooks/roles/bifrost-create-vm-nodes/templates/net.xml.j2":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0a57c8a51273f41171ff965e6e55b05425b26923","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  \u003c/forward\u003e"},{"line_number":13,"context_line":"  \u003cip address\u003d\u0027{{ test_vm_network_ip }}\u0027 netmask\u003d\u0027{{ test_vm_network_netmask }}\u0027\u003e"},{"line_number":14,"context_line":"  {% if test_vm_network_enable_dhcp | bool %}"},{"line_number":15,"context_line":"    \u003cdhcp\u003e"},{"line_number":16,"context_line":"      \u003crange start\u003d\u0027{{ test_vm_network_dhcp_start }}\u0027 end\u003d\u0027{{ test_vm_network_dhcp_end }}\u0027/\u003e"},{"line_number":17,"context_line":"    \u003c/dhcp\u003e"},{"line_number":18,"context_line":"  {% endif %}"},{"line_number":19,"context_line":"  \u003c/ip\u003e"},{"line_number":20,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f287b81_d30b5cd3","line":17,"range":{"start_line":15,"start_character":4,"end_line":17,"end_character":11},"updated":"2017-08-29 06:38:38.000000000","message":"when neutron is enabled you don\u0027t need to run separate dhcp as neutron will provide dhcp service.","commit_id":"02cda8a581f64c49c8f302404bc8fc0229f2e0e0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25df7fb20dbabbfc76a0b6f9ad05ac98092657a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  \u003c/forward\u003e"},{"line_number":13,"context_line":"  \u003cip address\u003d\u0027{{ test_vm_network_ip }}\u0027 netmask\u003d\u0027{{ test_vm_network_netmask }}\u0027\u003e"},{"line_number":14,"context_line":"  {% if test_vm_network_enable_dhcp | bool %}"},{"line_number":15,"context_line":"    \u003cdhcp\u003e"},{"line_number":16,"context_line":"      \u003crange start\u003d\u0027{{ test_vm_network_dhcp_start }}\u0027 end\u003d\u0027{{ test_vm_network_dhcp_end }}\u0027/\u003e"},{"line_number":17,"context_line":"    \u003c/dhcp\u003e"},{"line_number":18,"context_line":"  {% endif %}"},{"line_number":19,"context_line":"  \u003c/ip\u003e"},{"line_number":20,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f287b81_4196674e","line":17,"range":{"start_line":15,"start_character":4,"end_line":17,"end_character":11},"in_reply_to":"7f287b81_d30b5cd3","updated":"2017-08-29 15:08:25.000000000","message":"Indeed, This is on the other side of the else for when there is not neutron_enabled.  In all actuality, we likely don\u0027t even need this because we start our own dhcp service for the network_interface, but I\u0027ll have to try the out separately.","commit_id":"02cda8a581f64c49c8f302404bc8fc0229f2e0e0"}],"playbooks/roles/bifrost-create-vm-nodes/templates/testvm.xml.j2":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a9e2a599a0b5f33c7ed557e3140c6e360110b768","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u003c/controller\u003e"},{"line_number":31,"context_line":"    {% if neutron_enabled is defined and neutron_enabled | bool \u003d\u003d true %}"},{"line_number":32,"context_line":"    \u003cinterface type\u003d\u0027bridge\u0027\u003e"},{"line_number":33,"context_line":"      \u003csource bridge\u003d\u0027{{ test_vm_network }}\u0027/\u003e"},{"line_number":34,"context_line":"    {% else %}"},{"line_number":35,"context_line":"    \u003cinterface type\u003d\u0027network\u0027\u003e"},{"line_number":36,"context_line":"      \u003csource network\u003d\u0027{{ test_vm_network }}\u0027/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f287b81_73e828e1","line":33,"updated":"2017-08-29 06:41:32.000000000","message":"If I understood correctly you are trying to simulate multitenancy case. Connecting VM dirrectly to bridge will not work, as interface is not present when VM is powered off, but neutron need to update vlan on it, please refer to ironic simulation where we create tap interface https://github.com/openstack/ironic/blob/master/devstack/tools/ironic/scripts/create-node.sh#L95","commit_id":"02cda8a581f64c49c8f302404bc8fc0229f2e0e0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25df7fb20dbabbfc76a0b6f9ad05ac98092657a2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u003c/controller\u003e"},{"line_number":31,"context_line":"    {% if neutron_enabled is defined and neutron_enabled | bool \u003d\u003d true %}"},{"line_number":32,"context_line":"    \u003cinterface type\u003d\u0027bridge\u0027\u003e"},{"line_number":33,"context_line":"      \u003csource bridge\u003d\u0027{{ test_vm_network }}\u0027/\u003e"},{"line_number":34,"context_line":"    {% else %}"},{"line_number":35,"context_line":"    \u003cinterface type\u003d\u0027network\u0027\u003e"},{"line_number":36,"context_line":"      \u003csource network\u003d\u0027{{ test_vm_network }}\u0027/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7f287b81_61b4c3d1","line":33,"in_reply_to":"7f287b81_73e828e1","updated":"2017-08-29 15:08:25.000000000","message":"Correct, I did take a look.  Interesting, I\u0027m going to have to ponder tap interface usage.","commit_id":"02cda8a581f64c49c8f302404bc8fc0229f2e0e0"}],"releasenotes/notes/testvm-networking-update-a7a5c338b9d0420e.yaml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"ca85679d6ae60b72fedc8b46a571b521e796bdf2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    This is due to different styles of configuration that are required"},{"line_number":10,"context_line":"    for OpenVSwitch integration, between the VMs and neutron."},{"line_number":11,"context_line":"    "},{"line_number":12,"context_line":"    In order to address this, first undefine the VMs and networks::"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        virsh undefine testvm\u003cnumber\u003e"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa0c359_11512f37","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":4},"updated":"2018-02-06 10:01:16.000000000","message":"nit, whitespace","commit_id":"458b452620648ad5d28bedb939ee75573250f2f7"}]}