)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"442ea7626c4801dcb9e2f7d925eafeafc363f2de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only install libvirt-python and python-lxml via pip"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These are required by virtualbmc, and will be upgraded when virtualbmc is"},{"line_number":10,"context_line":"installed. Pip 10 will not allow this, if are already"},{"line_number":11,"context_line":"installed by the system package manager. Let\u0027s only ever install them via"},{"line_number":12,"context_line":"pip as that\u0027s the version we want in the end anyway."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_f133c360","line":9,"updated":"2018-04-24 11:07:19.000000000","message":"I guess not by virtualbmc itself (or it will pull them via requirements) but by the virt_net ansible module","commit_id":"2b46aa94856258803195e8db001810bc9bfc4ec8"}],"playbooks/roles/bifrost-create-vm-nodes/defaults/required_defaults_CentOS.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ce361e13164d01dbb561a25d564614e166e35342","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - libvirt-daemon-driver-secret"},{"line_number":22,"context_line":" - libvirt-daemon-driver-storage"},{"line_number":23,"context_line":" - libvirt-daemon-kvm"},{"line_number":24,"context_line":" - python-lxml"},{"line_number":25,"context_line":" - pkgconfig"},{"line_number":26,"context_line":" - libvirt-devel"},{"line_number":27,"context_line":"test_vm_emulator: \"/bin/qemu-system-x86_64\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_1e053646","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":14},"updated":"2018-04-23 16:35:22.000000000","message":"I suspect this should be removed as well","commit_id":"df8b3271facc9466adc5154266394f452ebbd198"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cd7678b13a86d7194008f0b9195bf57fc9e35f24","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - libvirt-daemon-driver-secret"},{"line_number":22,"context_line":" - libvirt-daemon-driver-storage"},{"line_number":23,"context_line":" - libvirt-daemon-kvm"},{"line_number":24,"context_line":" - python-lxml"},{"line_number":25,"context_line":" - pkgconfig"},{"line_number":26,"context_line":" - libvirt-devel"},{"line_number":27,"context_line":"test_vm_emulator: \"/bin/qemu-system-x86_64\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_63437714","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":14},"in_reply_to":"9f6a8fd7_1e053646","updated":"2018-04-23 21:26:44.000000000","message":"Probably, though CI seems to be happy. I\u0027m going to leave it for now.","commit_id":"df8b3271facc9466adc5154266394f452ebbd198"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3e78c4802b1136508de172381ae73a0f7c675047","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - libvirt-daemon-driver-secret"},{"line_number":22,"context_line":" - libvirt-daemon-driver-storage"},{"line_number":23,"context_line":" - libvirt-daemon-kvm"},{"line_number":24,"context_line":" - python-lxml"},{"line_number":25,"context_line":" - pkgconfig"},{"line_number":26,"context_line":" - libvirt-devel"},{"line_number":27,"context_line":"test_vm_emulator: \"/bin/qemu-system-x86_64\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_c35123db","line":24,"range":{"start_line":24,"start_character":3,"end_line":24,"end_character":14},"in_reply_to":"9f6a8fd7_63437714","updated":"2018-04-23 21:27:19.000000000","message":"Oh, looking again maybe not. Fixing :)","commit_id":"df8b3271facc9466adc5154266394f452ebbd198"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/prepare_libvirt.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"442ea7626c4801dcb9e2f7d925eafeafc363f2de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    name: libvirt-python"},{"line_number":21,"context_line":"    extra_args: \"-c {{ upper_constraints_file }}\""},{"line_number":22,"context_line":"    virtualenv: \"{{ enable_venv | bool | ternary(bifrost_venv_dir, omit) }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: \"Restart libvirt service\""},{"line_number":25,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_1137574f","line":23,"updated":"2018-04-24 11:07:19.000000000","message":"it seems like lxml is required explicitly: http://logs.openstack.org/83/563683/3/check/bifrost-integration-tinyipa/8b483a5/job-output.txt.gz#_2018-04-23_21_41_04_387593","commit_id":"2b46aa94856258803195e8db001810bc9bfc4ec8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"28d49257171aef7029148b96e4279ec457176e05","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    name: libvirt-python"},{"line_number":21,"context_line":"    extra_args: \"-c {{ upper_constraints_file }}\""},{"line_number":22,"context_line":"    virtualenv: \"{{ enable_venv | bool | ternary(bifrost_venv_dir, omit) }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: \"Restart libvirt service\""},{"line_number":25,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_a770ad09","line":23,"in_reply_to":"9f6a8fd7_1137574f","updated":"2018-04-24 12:36:51.000000000","message":"Ugh, I removed it everywhere but forgot to add it back in here. :(","commit_id":"2b46aa94856258803195e8db001810bc9bfc4ec8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d3879a00073e5a6dbe2f096f5876aeac39f7e8f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    name: \"{{ item }}\""},{"line_number":21,"context_line":"    extra_args: \"-c {{ upper_constraints_file }}\""},{"line_number":22,"context_line":"    virtualenv: \"{{ enable_venv | bool | ternary(bifrost_venv_dir, omit) }}\""},{"line_number":23,"context_line":"  loop:"},{"line_number":24,"context_line":"    - libvirt-python"},{"line_number":25,"context_line":"    - lxml"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f6a8fd7_0221479f","line":23,"updated":"2018-04-24 12:51:02.000000000","message":"isn\u0027t it called with_items? /me has never seen loop in this context","commit_id":"7c9d5e9ec13a3000d40f8d41bea429e5fbc18f4b"}]}