)]}'
{"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6e70eb4757839d9973d17ebdd960d25af2be6e27","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Override the default route supplied by dnsmasq, which assumes the"},{"line_number":73,"context_line":"# router is the same machine as the one running dnsmasq."},{"line_number":74,"context_line":"{% if dnsmasq_router is defined %}"},{"line_number":75,"context_line":"{% if dnsmasq_router | bool \u003d\u003d false %}"},{"line_number":76,"context_line":"{% if dnsmasq_router.split(\u0027.\u0027) | length \u003d\u003d 4 %}"},{"line_number":77,"context_line":"dhcp-option\u003d3,{{dnsmasq_router}}"},{"line_number":78,"context_line":"{% else %}"},{"line_number":79,"context_line":"dhcp-option\u003d3"},{"line_number":80,"context_line":"{% endif %}"},{"line_number":81,"context_line":"{% endif %}"},{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% if dnsmasq_dns_servers is defined %}"},{"line_number":85,"context_line":"dhcp-option\u003d6,{{dnsmasq_dns_servers}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f6a8fd7_311dbb73","line":82,"range":{"start_line":74,"start_character":0,"end_line":82,"end_character":11},"updated":"2018-04-24 11:22:49.000000000","message":"I feel like the problem is with the \"| bool\" statement, because it appears to be assuming the bool filter handles strings like python truthyness e.g. only \"False\" or \"No\" should be false everything else should be true, however it handles it the other way around, only \"True\" or \"Yes\" are true everything else is False, which means even an IP address is False.\n\nSo I think we need to change this whole block to:\n\n{% if not (dnsmasq_router | default(True) | bool) %}\n{% if dnsmasq_router | ipaddr %}\ndhcp-option\u003d3,{{dnsmasq_router}}\n{% else %}\ndhcp-option\u003d3\n{% endif %}\n{% endif %}","commit_id":"85e4ace13b51418d80fe4f1271454f5ea6ebf40e"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"a8fb06fd1bfede7ce0ec9cf1f1cc66d2c115e0c6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Override the default route supplied by dnsmasq, which assumes the"},{"line_number":73,"context_line":"# router is the same machine as the one running dnsmasq."},{"line_number":74,"context_line":"{% if dnsmasq_router is defined %}"},{"line_number":75,"context_line":"{% if dnsmasq_router | bool \u003d\u003d false %}"},{"line_number":76,"context_line":"{% if dnsmasq_router.split(\u0027.\u0027) | length \u003d\u003d 4 %}"},{"line_number":77,"context_line":"dhcp-option\u003d3,{{dnsmasq_router}}"},{"line_number":78,"context_line":"{% else %}"},{"line_number":79,"context_line":"dhcp-option\u003d3"},{"line_number":80,"context_line":"{% endif %}"},{"line_number":81,"context_line":"{% endif %}"},{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"{% if dnsmasq_dns_servers is defined %}"},{"line_number":85,"context_line":"dhcp-option\u003d6,{{dnsmasq_dns_servers}}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f6a8fd7_4c3a1699","line":82,"range":{"start_line":74,"start_character":0,"end_line":82,"end_character":11},"in_reply_to":"9f6a8fd7_311dbb73","updated":"2018-04-24 11:39:30.000000000","message":"Done","commit_id":"85e4ace13b51418d80fe4f1271454f5ea6ebf40e"}]}