)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b8565fe90497471e20cbfdee40740631d4a57ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add configurable option for Ironic master tftp images path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By design, Ironic will be making hardlinks from /var/lib/ironic/master_images"},{"line_number":10,"context_line":"into /httpboot. On a machine where /var is on a separate partition, deployment"},{"line_number":11,"context_line":"will succeed but operation will fail with some errors like:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b19fcbb1","line":9,"updated":"2018-06-21 08:53:04.000000000","message":"How about:\n\nfrom the ironic TFTP image cache master path (/var/lib/ironic/master_images by default in bifrost) into /httpboot.","commit_id":"f8bdd6f9f75e8160aac066f85cb9243353ac37e4"}],"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1b8565fe90497471e20cbfdee40740631d4a57ee","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    group: \"ironic\""},{"line_number":193,"context_line":"  with_items:"},{"line_number":194,"context_line":"    - \"/var/lib/ironic\""},{"line_number":195,"context_line":"    - \"{{ ironic_tftp_master_path | default(\u0027/var/lib/ironic/master_images\u0027) }}\""},{"line_number":196,"context_line":"    - \"/var/lib/ironic/images\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: \"Set permissions for /var/log/ironic for the ironic user\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_916f2f91","line":195,"updated":"2018-06-21 08:53:04.000000000","message":"+1 Dmitry\u0027s comment.\n\nAlso, this one should go back to just \"/var/lib/ironic/master_images\" - it is for the instance image cache. The /tftpboot/master_images path in create_tftpboot.yml should be modified to use ironic_tftp_master_path.","commit_id":"f8bdd6f9f75e8160aac066f85cb9243353ac37e4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b33579756fa24a457fdb9eeb2988c91bbb06c9a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    group: \"ironic\""},{"line_number":193,"context_line":"  with_items:"},{"line_number":194,"context_line":"    - \"/var/lib/ironic\""},{"line_number":195,"context_line":"    - \"{{ ironic_tftp_master_path | default(\u0027/var/lib/ironic/master_images\u0027) }}\""},{"line_number":196,"context_line":"    - \"/var/lib/ironic/images\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: \"Set permissions for /var/log/ironic for the ironic user\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_11c0ff4f","line":195,"updated":"2018-06-21 08:50:32.000000000","message":"why not add this new variable to role defaults for better visibility and to avoid hardcoding the default in two files?","commit_id":"f8bdd6f9f75e8160aac066f85cb9243353ac37e4"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"924422cb258f98387b30b637b703a315430f2de2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    group: \"ironic\""},{"line_number":193,"context_line":"  with_items:"},{"line_number":194,"context_line":"    - \"/var/lib/ironic\""},{"line_number":195,"context_line":"    - \"{{ ironic_tftp_master_path | default(\u0027/var/lib/ironic/master_images\u0027) }}\""},{"line_number":196,"context_line":"    - \"/var/lib/ironic/images\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: \"Set permissions for /var/log/ironic for the ironic user\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_27a61956","line":195,"in_reply_to":"5f7c97a3_11c0ff4f","updated":"2018-06-21 10:39:25.000000000","message":"Done","commit_id":"f8bdd6f9f75e8160aac066f85cb9243353ac37e4"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"924422cb258f98387b30b637b703a315430f2de2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    group: \"ironic\""},{"line_number":193,"context_line":"  with_items:"},{"line_number":194,"context_line":"    - \"/var/lib/ironic\""},{"line_number":195,"context_line":"    - \"{{ ironic_tftp_master_path | default(\u0027/var/lib/ironic/master_images\u0027) }}\""},{"line_number":196,"context_line":"    - \"/var/lib/ironic/images\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: \"Set permissions for /var/log/ironic for the ironic user\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_e7610113","line":195,"in_reply_to":"5f7c97a3_916f2f91","updated":"2018-06-21 10:39:25.000000000","message":"Done","commit_id":"f8bdd6f9f75e8160aac066f85cb9243353ac37e4"}]}